From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C1382E2DFB for ; Mon, 11 Aug 2025 22:24:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754951097; cv=none; b=jrt2HK/o8MhwiOR0W+MEewqEsjdJXY6bUy4UREwK01eE4/hbQAWLY6kyuGO59J2uoSxqN6yI6X28hE0t6tu5gdn4Snsf2TnS8tDbpPhSccF3iEVWIpoeAQ3fm9SDCGynY47Xsd4WsMGWUH30Id6mmuFD3DbaPU2xNSZ/UEc0Cqo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754951097; c=relaxed/simple; bh=jj2z0+YQrFwBV9fNVQs/CSGH5y1OTl8x5T+AoBGIp34=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=F3uVxVBgJjnIGJ3wKXbecr8EnE+EVlcx46jWqt7KtCGR8hJsGyhvbD+BZSr3TCyaGO5LTABPynSYIfGcXuXQmFjdwk7gco4SC8zrGpHEcVJZD8pG0joPJTjDUkRCIzd3HE7VJeZ/rlPKvl5TP8EepEFehKboe8lDuUlQ6CQ3Jmg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=08VwzOJZ; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="08VwzOJZ" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=Xm0giLdC2Y0IBdLIJp1HJXvUP6m1alu2ljGns+8whRM=; b=08VwzOJZkCxo+EAQNgiMOtjVQ7 cn8J9newIGB7GCMYwqp9O7NwIgJJKqyG/dqB/Uv+WPCT585AwUOCr7srihg7XGi0GklUhvkSgQQp5 xkidhU+1ZdG89dbd0u9fYvhhHuU9qlJeyfcEasOm59NVT2sh+s73rAQRzwRBcyu9fEOceuNO8l6WE Hl4vJi7JX5ojXDGlmKqH+XTMDf8HYlDkEvPol7OJneD6gCMUz8+mOP3Lsy001pS6AWYEZpqfrLLIk Ssm49O1gxKhW53LDnBAXuWHa3h1uLSXqhS0yPn4qxiTT+KrhFopqg7pqLLATAdJ6n06MIRZaGn7yS x5lxlgYQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1ulawn-00000009Hke-3z2f; Mon, 11 Aug 2025 22:24:53 +0000 From: Luis Chamberlain To: Chuck Lever , Daniel Gomez , kdevops@lists.linux.dev Cc: Luis Chamberlain Subject: [PATCH 21/23] reboot-limit: fix COUNT parameter to properly override reboot count Date: Mon, 11 Aug 2025 15:24:48 -0700 Message-ID: <20250811222452.2213071-22-mcgrof@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250811222452.2213071-1-mcgrof@kernel.org> References: <20250811222452.2213071-1-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Luis Chamberlain The COUNT parameter was not being passed to ansible-playbook, causing it to always use the configured value from extra_vars.yaml instead of the runtime override. Fix by: - Adding $(KDEVOPS_EXTRA_VARS) dependency to ensure extra_vars.yaml exists - Passing reboot_limit_max as an additional --extra-vars parameter which overrides the value from extra_vars.yaml This ensures that `make reboot-limit-tests COUNT=2` properly limits the test to 2 reboots instead of using the configured maximum. Generated-by: Claude AI Signed-off-by: Luis Chamberlain --- workflows/demos/reboot-limit/Makefile | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/workflows/demos/reboot-limit/Makefile b/workflows/demos/reboot-limit/Makefile index 87b7ea10..0539720b 100644 --- a/workflows/demos/reboot-limit/Makefile +++ b/workflows/demos/reboot-limit/Makefile @@ -107,10 +107,11 @@ endif # CONFIG_REBOOT_LIMIT_ENABLE_LOOP # # The playbook reboot-limit.yml is used to run all tasks defined except those # with tags "run_tests" or "copy_results". -reboot-limit: +reboot-limit: $(KDEVOPS_EXTRA_VARS) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ playbooks/reboot-limit.yml \ - --skip-tags run_tests,copy_results + --skip-tags run_tests,copy_results \ + --extra-vars="reboot_limit_max=$(REBOOT_LIMIT_MAX)" # kdevops supports generic workflows such as the enabling you to then use the # /data/ partition to git clone linux, compile linux, install it and reboot @@ -137,17 +138,19 @@ reboot-limit: # tags "first_run" first and then "run_tests" and "copy_results". We always # use the vars tag to ensure we get variables defined which we construct on the # fly. -reboot-limit-baseline: +reboot-limit-baseline: $(KDEVOPS_EXTRA_VARS) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ --limit 'baseline' \ playbooks/reboot-limit.yml \ --tags vars,first_run,reset \ - --extra-vars=@./extra_vars.yaml + --extra-vars=@./extra_vars.yaml \ + --extra-vars="reboot_limit_max=$(REBOOT_LIMIT_MAX)" $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ --limit 'baseline' \ playbooks/reboot-limit.yml \ --tags vars,run_tests,copy_results \ - --extra-vars=@./extra_vars.yaml + --extra-vars=@./extra_vars.yaml \ + --extra-vars="reboot_limit_max=$(REBOOT_LIMIT_MAX)" # Once you know the baseline works, you may want to run the baseline in a loop # up to the number of times you define. We define this goal in kdevops as @@ -172,17 +175,19 @@ reboot-limit-baseline-reset: reboot-limit-tests: reboot-limit-baseline reboot-limit-dev # Below are the corresponding dev targets -reboot-limit-dev: +reboot-limit-dev: $(KDEVOPS_EXTRA_VARS) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ --limit 'dev' \ playbooks/reboot-limit.yml \ --tags vars,first_run,reset \ - --extra-vars=@./extra_vars.yaml + --extra-vars=@./extra_vars.yaml \ + --extra-vars="reboot_limit_max=$(REBOOT_LIMIT_MAX)" $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ --limit 'dev' \ playbooks/reboot-limit.yml \ --tags vars,run_tests,copy_results \ - --extra-vars=@./extra_vars.yaml + --extra-vars=@./extra_vars.yaml \ + --extra-vars="reboot_limit_max=$(REBOOT_LIMIT_MAX)" reboot-limit-dev-loop: $(Q)$(REBOOT_LIMIT_LOOP) dev -- 2.47.2