[PATCH 4/8] bootlinux: add git dirty check before cloning

[Luis Chamberlain <mcgrof@kernel.org>]

Add preliminary checks to detect if the git tree has local modifications
before attempting to clone or update. This provides clearer error messages
when git operations fail due to uncommitted changes.

The issue was discovered when prior kdevops commits inadvertently modified
files in the linux kernel tree through overly broad make style operations.
When git clone/update encounters a dirty tree, it fails with a generic
"Local modifications exist" error that doesn't guide users on resolution.

Each build method now checks for dirty trees:
- 9p.yml: Checks bootlinux_9p_host_path on control node
- targets.yml: Checks target_linux_dir_path on target nodes
- builder.yml: Checks target_linux_dir_path on builder nodes

The error messages provide clear resolution steps:
1. Commit or stash changes
2. Hard reset the tree
3. Remove the directory for a fresh clone

This change improves debugging by:
- Failing fast with actionable error messages
- Showing which files are modified
- Providing multiple resolution options
- Preventing confusing git errors downstream

Generated-by: Claude AI
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 playbooks/roles/bootlinux/tasks/build/9p.yml  | 43 +++++++++++++++++++
 .../roles/bootlinux/tasks/build/builder.yml   | 33 ++++++++++++++
 .../roles/bootlinux/tasks/build/targets.yml   | 33 ++++++++++++++
 3 files changed, 109 insertions(+)

diff --git a/playbooks/roles/bootlinux/tasks/build/9p.yml b/playbooks/roles/bootlinux/tasks/build/9p.yml
index 98cbcb3c..5c9489c3 100644
--- a/playbooks/roles/bootlinux/tasks/build/9p.yml
+++ b/playbooks/roles/bootlinux/tasks/build/9p.yml
@@ -73,6 +73,49 @@
   run_once: true
   delegate_to: localhost
 
+- name: Check if target directory exists for dirty check
+  stat:
+    path: "{{ bootlinux_9p_host_path }}"
+  register: git_dir_stat
+  run_once: true
+  delegate_to: localhost
+  when:
+    - not bootlinux_tree_set_by_cli|bool
+
+- name: Check if git tree is dirty
+  command: "git -C {{ bootlinux_9p_host_path }} status --porcelain"
+  register: git_status
+  changed_when: false
+  failed_when: false
+  run_once: true
+  delegate_to: localhost
+  when:
+    - not bootlinux_tree_set_by_cli|bool
+    - git_dir_stat.stat.exists
+    - git_dir_stat.stat.isdir
+
+- name: Fail if git tree has local modifications
+  fail:
+    msg: |
+      Local modifications exist in the destination: {{ bootlinux_9p_host_path }}
+
+      The git tree is dirty with uncommitted changes. This prevents safe git operations.
+
+      To resolve this, you can:
+      1. Commit or stash your changes in {{ bootlinux_9p_host_path }}
+      2. Reset the tree with: git -C {{ bootlinux_9p_host_path }} reset --hard
+      3. Remove the directory and let kdevops clone fresh: rm -rf {{ bootlinux_9p_host_path }}
+
+      Modified files:
+      {{ git_status.stdout }}
+  when:
+    - not bootlinux_tree_set_by_cli|bool
+    - git_dir_stat.stat.exists
+    - git_dir_stat.stat.isdir
+    - git_status.stdout | length > 0
+  run_once: true
+  delegate_to: localhost
+
 - name: git clone {{ target_linux_tree }} on the control node
   git:
     repo: "{{ target_linux_git }}"
diff --git a/playbooks/roles/bootlinux/tasks/build/builder.yml b/playbooks/roles/bootlinux/tasks/build/builder.yml
index 73cc6694..d36815ed 100644
--- a/playbooks/roles/bootlinux/tasks/build/builder.yml
+++ b/playbooks/roles/bootlinux/tasks/build/builder.yml
@@ -31,6 +31,39 @@
   when:
     - ref_check.rc != 0
 
+- name: Check if target directory exists for dirty check
+  stat:
+    path: "{{ target_linux_dir_path }}"
+  register: git_dir_stat
+
+- name: Check if git tree is dirty
+  command: "git -C {{ target_linux_dir_path }} status --porcelain"
+  register: git_status
+  changed_when: false
+  failed_when: false
+  when:
+    - git_dir_stat.stat.exists
+    - git_dir_stat.stat.isdir
+
+- name: Fail if git tree has local modifications
+  fail:
+    msg: |
+      Local modifications exist in the destination: {{ target_linux_dir_path }}
+
+      The git tree is dirty with uncommitted changes. This prevents safe git operations.
+
+      To resolve this, you can:
+      1. Commit or stash your changes in {{ target_linux_dir_path }}
+      2. Reset the tree with: git -C {{ target_linux_dir_path }} reset --hard
+      3. Remove the directory and let kdevops clone fresh: rm -rf {{ target_linux_dir_path }}
+
+      Modified files:
+      {{ git_status.stdout }}
+  when:
+    - git_dir_stat.stat.exists
+    - git_dir_stat.stat.isdir
+    - git_status.stdout | length > 0
+
 - name: Clone {{ target_linux_tree }}
   ansible.builtin.git:
     repo: "{{ target_linux_git }}"
diff --git a/playbooks/roles/bootlinux/tasks/build/targets.yml b/playbooks/roles/bootlinux/tasks/build/targets.yml
index 81465cc6..414602ab 100644
--- a/playbooks/roles/bootlinux/tasks/build/targets.yml
+++ b/playbooks/roles/bootlinux/tasks/build/targets.yml
@@ -32,6 +32,39 @@
   when:
     - ref_check.rc != 0
 
+- name: Check if target directory exists for dirty check
+  stat:
+    path: "{{ target_linux_dir_path }}"
+  register: git_dir_stat
+
+- name: Check if git tree is dirty
+  command: "git -C {{ target_linux_dir_path }} status --porcelain"
+  register: git_status
+  changed_when: false
+  failed_when: false
+  when:
+    - git_dir_stat.stat.exists
+    - git_dir_stat.stat.isdir
+
+- name: Fail if git tree has local modifications
+  fail:
+    msg: |
+      Local modifications exist in the destination: {{ target_linux_dir_path }}
+
+      The git tree is dirty with uncommitted changes. This prevents safe git operations.
+
+      To resolve this, you can:
+      1. Commit or stash your changes in {{ target_linux_dir_path }}
+      2. Reset the tree with: git -C {{ target_linux_dir_path }} reset --hard
+      3. Remove the directory and let kdevops clone fresh: rm -rf {{ target_linux_dir_path }}
+
+      Modified files:
+      {{ git_status.stdout }}
+  when:
+    - git_dir_stat.stat.exists
+    - git_dir_stat.stat.isdir
+    - git_status.stdout | length > 0
+
 - name: git clone {{ target_linux_tree }} on the target nodes
   git:
     repo: "{{ target_linux_git }}"
-- 
2.47.2