From: Luis Chamberlain <mcgrof@kernel.org>
To: Chuck Lever <cel@kernel.org>, Daniel Gomez <da.gomez@kruces.com>,
kdevops@lists.linux.dev
Cc: Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 8/8] monitoring: integrate monitoring collection into fstests workflow
Date: Mon, 11 Aug 2025 15:43:07 -0700 [thread overview]
Message-ID: <20250811224307.2218478-9-mcgrof@kernel.org> (raw)
In-Reply-To: <20250811224307.2218478-1-mcgrof@kernel.org>
Fix monitoring data collection to work properly during fstests runs by
changing from include_role to import_tasks. The include_role directive
with tasks_from parameter wasn't executing properly due to tag filtering
during playbook execution, preventing monitoring data from being collected.
Using import_tasks ensures the monitoring tasks are statically included
at parse time and properly executed when the appropriate tags are present.
This allows monitoring to run on all hosts and collect folio migration
statistics during test execution.
The monitoring documentation has also been updated to reflect that it's
now a shared service available to all workflows.
Generated-by: Claude AI
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
Kconfig | 4 ++++
README.md | 1 +
playbooks/roles/fstests/tasks/main.yml | 14 ++++++++++++++
3 files changed, 19 insertions(+)
diff --git a/Kconfig b/Kconfig
index 988782a9..3f2bc8cf 100644
--- a/Kconfig
+++ b/Kconfig
@@ -79,6 +79,10 @@ menu "Target workflows"
source "kconfigs/workflows/Kconfig"
endmenu
+menu "Monitors"
+source "kconfigs/monitors/Kconfig"
+endmenu
+
menu "Kdevops configuration"
source "kconfigs/Kconfig.kdevops"
endmenu
diff --git a/README.md b/README.md
index e695d088..c9f44249 100644
--- a/README.md
+++ b/README.md
@@ -306,6 +306,7 @@ Below is kdevops' recommended documentation reading.
* [kdevops' evolving make help](docs/evolving-make-help.md)
* [kdevops configuration](docs/kdevops-configuration.md)
* [kdevops mirror support](docs/kdevops-mirror.md)
+ * [kdevops monitoring services](docs/monitoring.md)
* [kdevops first run](docs/kdevops-first-run.md)
* [kdevops running make](docs/running-make.md)
* [kdevops libvirt storage pool considerations](docs/libvirt-storage-pool.md)
diff --git a/playbooks/roles/fstests/tasks/main.yml b/playbooks/roles/fstests/tasks/main.yml
index 2665f693..3e2cbf99 100644
--- a/playbooks/roles/fstests/tasks/main.yml
+++ b/playbooks/roles/fstests/tasks/main.yml
@@ -1235,6 +1235,13 @@
when:
- fstests_skip_run|bool
+# Start monitoring services before running tests
+- import_tasks: ../../monitoring/tasks/monitor_run.yml
+ when:
+ - kdevops_run_fstests|bool
+ - enable_monitoring|default(false)|bool
+ tags: [ 'oscheck', 'fstests', 'run_tests', 'monitoring', 'monitor_run' ]
+
# Recent environments runs are showing that environment variables
# set below are not propagated. So best to stuff what you need
# into the .kdevops_fstests_setup file which is sourced by root.
@@ -1281,6 +1288,13 @@
when:
- kdevops_run_fstests|bool
+# Stop monitoring services and collect data after running tests
+- import_tasks: ../../monitoring/tasks/monitor_collect.yml
+ when:
+ - kdevops_run_fstests|bool
+ - enable_monitoring|default(false)|bool
+ tags: [ 'oscheck', 'fstests', 'run_tests', 'monitoring', 'monitor_collect' ]
+
- name: Remove watchdog hint that tests have started
local_action: file path="{{ fstests_workflow_dir }}/.begin" state=absent
tags: [ 'oscheck', 'fstests', 'run_tests' ]
--
2.47.2
next prev parent reply other threads:[~2025-08-11 22:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 22:42 [PATCH 0/8] linux-ab enhancements + monitor support Luis Chamberlain
2025-08-11 22:43 ` [PATCH 1/8] bootlinux: use different kernel for A/B testing by default Luis Chamberlain
2025-08-11 22:43 ` [PATCH 2/8] bootlinux: add support for custom refs on dev kernels on the CLI Luis Chamberlain
2025-08-11 22:43 ` [PATCH 3/8] bootlinux: add git ref verification before cloning Luis Chamberlain
2025-08-11 22:43 ` [PATCH 4/8] bootlinux: add git dirty check " Luis Chamberlain
2025-08-11 22:43 ` [PATCH 5/8] bootlinux: add intelligent git repository detection and management Luis Chamberlain
2025-08-11 22:43 ` [PATCH 6/8] bootlinux: enhance A/B testing and repository management Luis Chamberlain
2025-08-11 22:43 ` [PATCH 7/8] fstests: add make target for running tests on all hosts Luis Chamberlain
2025-08-11 22:43 ` Luis Chamberlain [this message]
2025-08-11 22:46 ` [PATCH 8/8] monitoring: integrate monitoring collection into fstests workflow Luis Chamberlain
2025-08-12 0:49 ` Luis Chamberlain
2025-08-14 0:59 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250811224307.2218478-9-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=cel@kernel.org \
--cc=da.gomez@kruces.com \
--cc=kdevops@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox