From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09FDC2BDC28 for ; Wed, 27 Aug 2025 14:28:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756304915; cv=none; b=lwmsx8dDnIyEWxhUt3ffn86M1vmgrXDW+x+sqZ599f9/hWLXSC7Kfe83qLpCk2Vxy71+wY43NN1QaJlkMkOAEMjh+oiS3Vg55EgoF+ORF5nvJg5S0WfZMkvbpcx2l8qe4GxynSx4moYl9LudWsR8khNY/ijrTUFqaEH4AGNidvM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756304915; c=relaxed/simple; bh=q9NAxZZVhIttCYnhnz7Omp7eof3yiHXtwzsLbABAf0k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JqyB4ktLvAC4sSv/imXLEV3KB+XSxD3GbbTyylDn8s6afhiUTWZEC3HjQcBIl/uHij8yQY5ckND6BaexHIHbn3XdkSP9M7gIifamR04mL0zs3Ofn3wTgQfUi08oc4FKlrOuk9eTo/O0/FoNkpE666AGG6ThKTA0hmD3R/Oeg/Mw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YEG/7S1I; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YEG/7S1I" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A63B4C4CEF0; Wed, 27 Aug 2025 14:28:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756304914; bh=q9NAxZZVhIttCYnhnz7Omp7eof3yiHXtwzsLbABAf0k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YEG/7S1I/H2H7JD/q2z/m86ZAjI1u32VWGb8eqBXUcxhEk2EkOUVJKTm0lioSXvnV ts9ni9Bg8mOIkPsJqv/nLWvuV0/GN48WEipkPJd2rgOQdeqeV6gUhLyr27dw/nfJz9 8K+lLKkeghS+6HAJu2GytRmn1YJg6s9ezi+maHTdkF6+q2iSZ5cJCdOJPkNHtu+tXo g+QIy4NH5ZxcGYve/RcLtMPmNNZ97fHvaOVsuNyZOnrnPwTrnvDIqSP9r5v5YKsHeo zFaMjReekVaXhzPEkt9VSY8MWcCbqs/CVh0DQuIC10LBYwRLwjA4xZeKUsMPvkRqWf CZn5JMFDe6f8A== From: Chuck Lever To: Cc: Chuck Lever Subject: [PATCH v1 01/26] scripts: Update gen_ssh_key.sh Date: Wed, 27 Aug 2025 10:27:56 -0400 Message-ID: <20250827142832.2629291-2-cel@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250827142832.2629291-1-cel@kernel.org> References: <20250827142832.2629291-1-cel@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chuck Lever Drop the -b option. We're stuck with RSA because some cloud providers require it, but ssh-keygen's default bit length for RSA keys is 3072, which is better than the value specified here. Leaving off -b means when ssh-keygen increases its default, kdevops will get that change without human intervention. I'm also adding a -C option here because I got really confused when I looked at the terraform state imported back from the provider. The public ssh key comment was "cel@ ... ". I thought that this was my personal public key. It's is not my public key, thankfully. Rather the comment chosen by ssh-keygen happens to be the same as the one in my personal public key. So let's pick a more distinct eye-catcher to avoid future myocardial infarction. Signed-off-by: Chuck Lever --- scripts/gen_ssh_key.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/gen_ssh_key.sh b/scripts/gen_ssh_key.sh index 72bdb22694aa..4f656fe35b7c 100755 --- a/scripts/gen_ssh_key.sh +++ b/scripts/gen_ssh_key.sh @@ -5,4 +5,4 @@ source ${TOPDIR}/.config source ${TOPDIR}/scripts/lib.sh echo "Creating $KDEVOPS_SSH_PRIVKEY" -ssh-keygen -b 2048 -t rsa -f $KDEVOPS_SSH_PRIVKEY -q -N "" +ssh-keygen -t rsa -C generated-by-kdevops -f $KDEVOPS_SSH_PRIVKEY -q -N "" -- 2.51.0