From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41B6021ADC5 for ; Sun, 31 Aug 2025 04:12:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756613530; cv=none; b=dZmKY6TqSFo5j9fTxWwltBsOzfcVlvSqb6H/8WgXg1c5Ys/AGGXhdmPd+i+rC53/JkgLK2VsHcCQlAKX9vnPyZr30hB6UGuC8gfxTNlGNCUcGRxhZR+6jmlKJOyuHmZXN0qcJ5Hill8YD481PV/0Z65Y8R5TuYvNuL3tpLCzVz4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756613530; c=relaxed/simple; bh=lopwaVp1VKjsrvZJNkXFX/DlkGC4CklR/P3Iqek7lTY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mtPH3rnQg3DrKOTF+4SPYn76esAdn8lVR2/M2VwBWMlqAQM30ODS4JlJiJny09HsrzlLYOqqiD/U16szsDLInf4fAgZIf6dHqgLsF1s9zgs0oIqBQrOcNodZw7KBMcduZg5wywaZKfgtdL1mRlJ2hZKfZ4TCCArGr7FcEoi5XEo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=xC05/Bau; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="xC05/Bau" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=GCujCBr9E3uKXObMLgALtBkAL3tr4/iP58SM1D4ZCk0=; b=xC05/BauGLsTERtseOOM50bXXH tpxnYUK+8te2gorsJgVrxrhshO3lhYsJ4POWTZfJUHgZwWvICYhh9NDIkmjRbXAZ0fsOVyFjDv16F RPFuFVdSgdU/YIHl50GjJPetf6dXFd8z4vLtlLsoRpDGXZWwggbtsViG1umiQZpYWHZ6XUm7maO8u NeENgTE10hUeQMvS/B+mgCt/uZhJI9ILsBwo8TwGfiGH2AaPO/+VzAlmtAn+9HRkKBUzfmibcPeo4 I5CC2f9UHZlpshg+sFQHh0lJilTxeaytLO9AwPC7MqSdaBQIPeZxg9JBBYzMYd01R9jMeNG9Qtyw9 FHmVWQVw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1usZQE-0000000975O-3J2Q; Sun, 31 Aug 2025 04:12:06 +0000 From: Luis Chamberlain To: Chuck Lever , Daniel Gomez , kdevops@lists.linux.dev Cc: hui81.qi@samsung.com, kundan.kumar@samsung.com, Luis Chamberlain Subject: [PATCH v2 3/4] Makefile: add missing extra_vars.yaml dependencies Date: Sat, 30 Aug 2025 21:11:59 -0700 Message-ID: <20250831041202.2172115-4-mcgrof@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250831041202.2172115-1-mcgrof@kernel.org> References: <20250831041202.2172115-1-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Luis Chamberlain The ANSIBLE_INVENTORY_FILE and KDEVOPS_NODES targets both use '--extra-vars=@./extra_vars.yaml' in their ansible-playbook commands but didn't declare extra_vars.yaml as a dependency. This caused build failures when running targets like 'make minio' from a clean state. The missing dependency meant that ansible-playbook would fail with: 'No such file or directory: /data/minio/kdevops/extra_vars.yaml' This fix ensures that extra_vars.yaml is properly generated before any ansible-playbook commands that require it are executed. Generated-by: Claude AI Signed-off-by: Luis Chamberlain --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 625d775..53651cb 100644 --- a/Makefile +++ b/Makefile @@ -234,14 +234,14 @@ include scripts/bringup.Makefile endif DEFAULT_DEPS += $(ANSIBLE_INVENTORY_FILE) -$(ANSIBLE_INVENTORY_FILE): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_HOSTS_TEMPLATE) $(KDEVOPS_NODES) +$(ANSIBLE_INVENTORY_FILE): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_HOSTS_TEMPLATE) $(KDEVOPS_NODES) $(KDEVOPS_EXTRA_VARS) $(Q)ANSIBLE_LOCALHOST_WARNING=False ANSIBLE_INVENTORY_UNPARSED_WARNING=False \ ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/gen_hosts.yml \ --extra-vars=@./extra_vars.yaml DEFAULT_DEPS += $(KDEVOPS_NODES) -$(KDEVOPS_NODES): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_NODES_TEMPLATE) +$(KDEVOPS_NODES): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_NODES_TEMPLATE) $(KDEVOPS_EXTRA_VARS) $(Q)ANSIBLE_LOCALHOST_WARNING=False ANSIBLE_INVENTORY_UNPARSED_WARNING=False \ ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \ --inventory localhost, \ -- 2.50.1