From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDFA730C35F for ; Tue, 2 Sep 2025 13:54:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756821269; cv=none; b=fFCiuqJ7KPmeKCJMYtH42ILVI1KcURWn0M4Q8+BO77y7bjpmWgBVKpprtIzzsSzmKrCBOmQOApjY+7EkYJvv6KOnW7aF2wFlGm1Aq0ScGNwo8qQnuEMP5Xk9LX9WkDl4/3NDUh/7LluNxtY1T1t71iGQz3mrM6nMRp5nNJdFR9E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756821269; c=relaxed/simple; bh=jgiQw4py0MSlIb23ROJGLw58FQzgPJq23G3hxFM7ddw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dPpfwp1tdRSc/AkNs4a1dgQUMAuDAndtTG5X5uBKL9KMnBc9pMnkkFPwCLGU3yT8ooHvsfjtM+J4xHVmHKRQ/+0Vlug9o2QZz1g4qGuFmVXyM1LqjPik7dB8Zoaw71TVWKCM3bs9lot9mOSKlV5ac6CKe9f5ehDWLDVPuBFUSfw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nVSfxr5j; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nVSfxr5j" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A2DEC4CEF6; Tue, 2 Sep 2025 13:54:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756821269; bh=jgiQw4py0MSlIb23ROJGLw58FQzgPJq23G3hxFM7ddw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nVSfxr5jJGxosCdhRvz8v8FGKiE0gePET/h7/BSWKPXIWP4NnE3JT1OUHrXPirMaK b4sy8WYhlxRxOfNgRJDJ8+slCxQPEcCQfRa3EhTZpasfWrVRmW2KMQl+wJqRx2v5hh 9XkEWnLg7lZD8+er+1KeLXJ/YhftHOsPsNV7mOfBFYnlpeKUuKqIF8ziZg3x9sQRnq 2baJ1r5iTOJevRUc94xl40uR2CC/5RhpSLN7UtPV9qGmBwPMMy2tecOlCDOzJVMVBn I5RZezOGUha4FGrbsBoDOdSzF2+UwBt1pE78wA/Fj+8vAGIHHTe7RLiZ6nWATHY8yP cNbIeJ6MT0XSg== From: Chuck Lever To: Cc: Chuck Lever , Luis Chamberlain Subject: [PATCH v2 01/37] scripts: Update gen_ssh_key.sh Date: Tue, 2 Sep 2025 09:53:48 -0400 Message-ID: <20250902135426.815079-2-cel@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250902135426.815079-1-cel@kernel.org> References: <20250902135426.815079-1-cel@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chuck Lever Drop the -b option. We're stuck with RSA because some cloud providers require it, but ssh-keygen's default bit length for RSA keys is 3072, which is better than the value specified here. Leaving off -b means when ssh-keygen increases its default, kdevops will get that change without human intervention. I'm also adding a -C option here because I got really confused when I looked at the terraform state imported back from the provider. The public ssh key comment was "cel@ ... ". I thought that this was my personal public key. It's is not my public key, thankfully. Rather the comment chosen by ssh-keygen happens to be the same as the one in my personal public key. So let's pick a more distinct eye-catcher to avoid future myocardial infarction. Reviewed-by: Luis Chamberlain Signed-off-by: Chuck Lever --- scripts/gen_ssh_key.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/gen_ssh_key.sh b/scripts/gen_ssh_key.sh index 72bdb22694aa..4f656fe35b7c 100755 --- a/scripts/gen_ssh_key.sh +++ b/scripts/gen_ssh_key.sh @@ -5,4 +5,4 @@ source ${TOPDIR}/.config source ${TOPDIR}/scripts/lib.sh echo "Creating $KDEVOPS_SSH_PRIVKEY" -ssh-keygen -b 2048 -t rsa -f $KDEVOPS_SSH_PRIVKEY -q -N "" +ssh-keygen -t rsa -C generated-by-kdevops -f $KDEVOPS_SSH_PRIVKEY -q -N "" -- 2.51.0