From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6688E21254D for ; Thu, 4 Sep 2025 15:15:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756998930; cv=none; b=Ow7TDNeS9Pn+NFE2BzEGF1MA3UZDdmkm14MTWVkxEhHsdfI0zYbcylIVkkUuNTVQLRRWoGBOJc5o0kF0+DP2smSB13BLmm9z9O4UcFNeR27+ul8Gv/eLkOrNQV/Sz2rpBg8oCMNv/EGHFhrjL1xwWypMvlXpBqkAb/QdtbrwmR4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756998930; c=relaxed/simple; bh=jgiQw4py0MSlIb23ROJGLw58FQzgPJq23G3hxFM7ddw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IcUrCp22mjx6zhFuGqByhQSCERZ+9KX3ZcKYZCcxL6Ohjuh172c81Mz/qH9BX3D5yOn13UxCYVytlkvDvNZ41ak6F/3A9PEo7U9mH2fYTKSuV/pVWwTCbGs2VRQcDMdosHfRHePtYJF/KncAN1ijuy7IBcay/x5ljprOG4ya61g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RwX/xol0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RwX/xol0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A383BC4CEF7; Thu, 4 Sep 2025 15:15:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756998929; bh=jgiQw4py0MSlIb23ROJGLw58FQzgPJq23G3hxFM7ddw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RwX/xol0c7uu/TiJIvTvkTYvuuchq2QymGrEgiPKxhRM0sN76BDmtQzXm4+aBtyj0 Kk81FcMeXWw82IMuios+uqMDXZnoemDjeqM4D7HUqwpcu6LJa55K20t6Cb+ndvxfCk oUy1gl0Ip8ruNZTN6gfUjY5moBm4BrwEtdojrQBSm6iJR1tZHTR1FtC8vYBU3J1S/W 4Ztxr7yTfMnfGAOAOoFEOZ3OdMzprbBBEIU9qabhxXick4Gu7FSwSVFEhFKODnweNX Ioai7DWi5PxqwJWxkIxGf+HHLHWKAOwa72oflFGuJ9WjplOif3SgXDj3ZIIoAKLje1 ngITSK7Tfgjtg== From: Chuck Lever To: Cc: Chuck Lever , Luis Chamberlain Subject: [PATCH v3 01/36] scripts: Update gen_ssh_key.sh Date: Thu, 4 Sep 2025 11:14:49 -0400 Message-ID: <20250904151526.1596282-2-cel@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250904151526.1596282-1-cel@kernel.org> References: <20250904151526.1596282-1-cel@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chuck Lever Drop the -b option. We're stuck with RSA because some cloud providers require it, but ssh-keygen's default bit length for RSA keys is 3072, which is better than the value specified here. Leaving off -b means when ssh-keygen increases its default, kdevops will get that change without human intervention. I'm also adding a -C option here because I got really confused when I looked at the terraform state imported back from the provider. The public ssh key comment was "cel@ ... ". I thought that this was my personal public key. It's is not my public key, thankfully. Rather the comment chosen by ssh-keygen happens to be the same as the one in my personal public key. So let's pick a more distinct eye-catcher to avoid future myocardial infarction. Reviewed-by: Luis Chamberlain Signed-off-by: Chuck Lever --- scripts/gen_ssh_key.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/gen_ssh_key.sh b/scripts/gen_ssh_key.sh index 72bdb22694aa..4f656fe35b7c 100755 --- a/scripts/gen_ssh_key.sh +++ b/scripts/gen_ssh_key.sh @@ -5,4 +5,4 @@ source ${TOPDIR}/.config source ${TOPDIR}/scripts/lib.sh echo "Creating $KDEVOPS_SSH_PRIVKEY" -ssh-keygen -b 2048 -t rsa -f $KDEVOPS_SSH_PRIVKEY -q -N "" +ssh-keygen -t rsa -C generated-by-kdevops -f $KDEVOPS_SSH_PRIVKEY -q -N "" -- 2.51.0