From: Luis Chamberlain <mcgrof@kernel.org>
To: Chuck Lever <cel@kernel.org>, Daniel Gomez <da.gomez@kruces.com>,
kdevops@lists.linux.dev
Cc: Luis Chamberlain <mcgrof@kernel.org>, Daniel Gomez <da.gomez@kernel.org>
Subject: [PATCH 2/2] gen_hosts: remove 'write-your-own-template' placeholder text
Date: Mon, 8 Sep 2025 17:50:16 -0700 [thread overview]
Message-ID: <20250909005016.791529-3-mcgrof@kernel.org> (raw)
In-Reply-To: <20250909005016.791529-1-mcgrof@kernel.org>
During patch review, it was noted that the placeholder text
'write-your-own-template-for-...-workflow' was introduced in commit
71f085a4d77f ("kdevops: replace ansible hosts generation jinja2
templating") from kdevops-history and has been expanded to other
templates.
This placeholder text serves no functional purpose and should be
replaced with proper template structure. The cxl.j2 and pynfs.j2
workflow templates contained these placeholders which have now been
replaced with proper host definitions following the pattern used
by other workflow templates.
The templates now properly define:
- The workflow host in [all] section
- A [baseline] group with the workflow host
- A workflow-specific group ([cxl] or [pynfs]) with the host
- Proper ansible_python_interpreter variables for each group
This cleanup ensures consistency across all workflow templates.
Suggested-by: Daniel Gomez <da.gomez@kernel.org>
Fixes: 40df5ef72d197 ("gen_hosts: use kdevops_workflow_name directly for template selection")
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
.../roles/gen_hosts/templates/workflows/cxl.j2 | 14 +++++++++++++-
.../roles/gen_hosts/templates/workflows/pynfs.j2 | 14 +++++++++++++-
2 files changed, 26 insertions(+), 2 deletions(-)
diff --git a/playbooks/roles/gen_hosts/templates/workflows/cxl.j2 b/playbooks/roles/gen_hosts/templates/workflows/cxl.j2
index 53790f29..cf1e7083 100644
--- a/playbooks/roles/gen_hosts/templates/workflows/cxl.j2
+++ b/playbooks/roles/gen_hosts/templates/workflows/cxl.j2
@@ -1,7 +1,19 @@
{# Workflow template for CXL #}
[all]
localhost ansible_connection=local
-write-your-own-template-for-cxl-workflow
+{{ kdevops_host_prefix }}-cxl
[all:vars]
ansible_python_interpreter = "{{ kdevops_python_interpreter }}"
+
+[baseline]
+{{ kdevops_host_prefix }}-cxl
+
+[baseline:vars]
+ansible_python_interpreter = "{{ kdevops_python_interpreter }}"
+
+[cxl]
+{{ kdevops_host_prefix }}-cxl
+
+[cxl:vars]
+ansible_python_interpreter = "{{ kdevops_python_interpreter }}"
diff --git a/playbooks/roles/gen_hosts/templates/workflows/pynfs.j2 b/playbooks/roles/gen_hosts/templates/workflows/pynfs.j2
index 6145b1a0..a93b8f06 100644
--- a/playbooks/roles/gen_hosts/templates/workflows/pynfs.j2
+++ b/playbooks/roles/gen_hosts/templates/workflows/pynfs.j2
@@ -1,7 +1,19 @@
{# Workflow template for pynfs #}
[all]
localhost ansible_connection=local
-write-your-own-template-for-pynfs-workflow
+{{ kdevops_host_prefix }}-pynfs
[all:vars]
ansible_python_interpreter = "{{ kdevops_python_interpreter }}"
+
+[baseline]
+{{ kdevops_host_prefix }}-pynfs
+
+[baseline:vars]
+ansible_python_interpreter = "{{ kdevops_python_interpreter }}"
+
+[pynfs]
+{{ kdevops_host_prefix }}-pynfs
+
+[pynfs:vars]
+ansible_python_interpreter = "{{ kdevops_python_interpreter }}"
--
2.50.1
prev parent reply other threads:[~2025-09-09 0:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 0:50 [PATCH 0/2] gen_hosts: small fixes Luis Chamberlain
2025-09-09 0:50 ` [PATCH 1/2] gen_hosts: remove legacy duplicate workflow templates Luis Chamberlain
2025-09-09 0:50 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250909005016.791529-3-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=cel@kernel.org \
--cc=da.gomez@kernel.org \
--cc=da.gomez@kruces.com \
--cc=kdevops@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox