From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C28B32D8DC8 for ; Wed, 10 Sep 2025 19:38:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757533132; cv=none; b=NGXe4pNv35arMyU5HLeU83S/y4ESygeH6bvfDV3yv8U3l6kLuZQrEYpugoTzctfNr4QVO6iye//wWGl9xxBqIYzeClZdF+g8yU+/R+t/B7mTe08e0fJGhSm5zKLQOvEHM8+fgomN5IE7RMQidyAABa1qEuZn5Kuy+P3B2kM68pU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757533132; c=relaxed/simple; bh=PjgI0Me1GVRG+BcBCsngxIFu3F1yn3xPUW80MgcREvM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BThaJ57MgxRM8/o/oKEeGm6Sufi1TPIDQ2t6uHgP9CLdjbSRbpS/zVv7wX/J/mJKkEjQ+8KwUmQDqLVlmfK6Z8AQLQXMmM1+c0kTW7lks//DRF3ti0Ed6SRyNdYm5qHzojuAi9u/wxEqbSadEudTJ+k73poh8JAavIilje6s47A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fefNXCYy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fefNXCYy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25BBAC4CEEB; Wed, 10 Sep 2025 19:38:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757533132; bh=PjgI0Me1GVRG+BcBCsngxIFu3F1yn3xPUW80MgcREvM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fefNXCYyd5C9TaCnBcTwvSbey5KKEq5ISpAzljr+9lxN5BPWdAPyFl8IiupynRgkL sub8lCXDpPaCVcZnIUmzTiB3TbRiSnND/r3MFD9WUEJIf7k1KGg6XZLRRitdbzcyJc ejTn28AVtq8996rIcPqJhsa/etEnlmp+9xeV/AYEJHJUBnvVCMbUCGbju/y3V3Ix4A aJqAcJ0546oQIKKDQTUcWutePdHCFn0S2jfNFj9ofC9DDeaHE968XaL81x9yR9auqu Vv4C5AAoreDeFRglDDO3NJ0sj7K/tXdWOdKl2TDlNl6YkFDYrBs/ETEyiDaoll+7ux JKanvThpg79HA== From: Chuck Lever To: Cc: Chuck Lever Subject: [PATCH v1 3/8] gen_hosts: Get the "separate kernel builder" workflow working again Date: Wed, 10 Sep 2025 15:38:43 -0400 Message-ID: <20250910193849.779453-4-cel@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250910193849.779453-1-cel@kernel.org> References: <20250910193849.779453-1-cel@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chuck Lever The [all] group contained the wrong host name. This causes "-m wait_for_connection -i all" to hang indefinitely. The [dev] group was missing, resulting in needless warnings. The only thing the linux workflow does is run a separate kernel builder node. The separate logic for nixos and the service hosts isn't needed, AFAICT. Let's start over with a simple template. Fixes: 40df5ef72d19 ("gen_hosts: use kdevops_workflow_name directly for template selection") Signed-off-by: Chuck Lever --- .../gen_hosts/templates/workflows/linux.j2 | 97 +------------------ 1 file changed, 3 insertions(+), 94 deletions(-) diff --git a/playbooks/roles/gen_hosts/templates/workflows/linux.j2 b/playbooks/roles/gen_hosts/templates/workflows/linux.j2 index 5d9ebb67e900..6a1459d873ae 100644 --- a/playbooks/roles/gen_hosts/templates/workflows/linux.j2 +++ b/playbooks/roles/gen_hosts/templates/workflows/linux.j2 @@ -1,110 +1,19 @@ -{# Template for Linux custom kernel workflow #} +{# Template for the kernel builder workflow #} [all] localhost ansible_connection=local -{% if kdevops_enable_nixos|default(false) %} -{{ kdevops_host_prefix }} ansible_python_interpreter=/run/current-system/sw/bin/python3 -{% else %} -{{ kdevops_host_prefix }} -{% endif %} -{% if kdevops_baseline_and_dev == True %} -{% if kdevops_enable_nixos|default(false) %} -{{ kdevops_host_prefix }}-dev ansible_python_interpreter=/run/current-system/sw/bin/python3 -{% else %} -{{ kdevops_host_prefix }}-dev -{% endif %} -{% endif %} -{% if kdevops_enable_iscsi %} -{{ kdevops_host_prefix }}-iscsi -{% endif %} -{% if kdevops_nfsd_enable %} -{{ kdevops_host_prefix }}-nfsd -{% endif %} -{% if kdevops_smbd_enable|default(false) %} -{{ kdevops_host_prefix }}-smbd -{% endif %} -{% if kdevops_krb5kdc_enable|default(false) %} -{{ kdevops_host_prefix }}-kdc -{% endif %} - +{{ kdevops_hosts_prefix }}-builder [all:vars] ansible_python_interpreter = "{{ kdevops_python_interpreter }}" [baseline] -{% if kdevops_enable_nixos|default(false) %} -{{ kdevops_host_prefix }} ansible_python_interpreter=/run/current-system/sw/bin/python3 -{% else %} -{{ kdevops_host_prefix }} -{% endif %} - +{{ kdevops_hosts_prefix }}-builder [baseline:vars] ansible_python_interpreter = "{{ kdevops_python_interpreter }}" -{% if kdevops_baseline_and_dev %} [dev] -{% if kdevops_enable_nixos|default(false) %} -{{ kdevops_host_prefix }}-dev ansible_python_interpreter=/run/current-system/sw/bin/python3 -{% else %} -{{ kdevops_host_prefix }}-dev -{% endif %} - [dev:vars] ansible_python_interpreter = "{{ kdevops_python_interpreter }}" -{% endif %} - -[linux] -{{ kdevops_host_prefix }} -{% if kdevops_baseline_and_dev == True %} -{{ kdevops_host_prefix }}-dev -{% endif %} - -[linux:vars] -ansible_python_interpreter = "{{ kdevops_python_interpreter }}" - -{% if kdevops_enable_iscsi %} -[iscsi] -{{ kdevops_host_prefix }}-iscsi - -[iscsi:vars] -ansible_python_interpreter = "{{ kdevops_python_interpreter }}" -{% endif %} - -{% if kdevops_nfsd_enable %} -[nfsd] -{{ kdevops_host_prefix }}-nfsd - -[nfsd:vars] -ansible_python_interpreter = "{{ kdevops_python_interpreter }}" -{% endif %} - -{% if kdevops_smbd_enable|default(false) %} -[smbd] -{{ kdevops_host_prefix }}-smbd - -[smbd:vars] -ansible_python_interpreter = "{{ kdevops_python_interpreter }}" -{% endif %} - -{% if kdevops_krb5kdc_enable|default(false) %} -[kdc] -{{ kdevops_host_prefix }}-kdc - -[kdc:vars] -ansible_python_interpreter = "{{ kdevops_python_interpreter }}" -{% endif %} [service] -{% if kdevops_enable_iscsi %} -{{ kdevops_host_prefix }}-iscsi -{% endif %} -{% if kdevops_nfsd_enable %} -{{ kdevops_host_prefix }}-nfsd -{% endif %} -{% if kdevops_smbd_enable|default(false) %} -{{ kdevops_host_prefix }}-smbd -{% endif %} -{% if kdevops_krb5kdc_enable|default(false) %} -{{ kdevops_host_prefix }}-kdc -{% endif %} - [service:vars] ansible_python_interpreter = "{{ kdevops_python_interpreter }}" -- 2.51.0