public inbox for kdevops@lists.linux.dev
 help / color / mirror / Atom feed
From: Daniel Gomez <da.gomez@kernel.org>
To: Luis Chamberlain <mcgrof@kernel.org>,
	 Chuck Lever <chuck.lever@oracle.com>
Cc: kdevops@lists.linux.dev, Daniel Gomez <da.gomez@samsung.com>
Subject: [PATCH 1/4] workflows: linux: remove explicit inventory in ansible wrappers
Date: Wed, 17 Sep 2025 10:32:36 +0200	[thread overview]
Message-ID: <20250917-fix-groups-v1-1-d6cd940f8b6e@samsung.com> (raw)
In-Reply-To: <20250917-fix-groups-v1-0-d6cd940f8b6e@samsung.com>

From: Daniel Gomez <da.gomez@samsung.com>

The A/B testing implementation introduced back the --inventory argument
for the ansible-playbook invocation patterns. Three targets (linux,
linux-baseline, linux-dev) were using '-i hosts' instead of leveraging
the ansible.cfg inventory key + the established '--limit' or hosts:
YAML field.

Also, for bootlinux playbook case, this caused the playbook to run on
localhost, leading to failures when localhost doesn't have the required
virtualization setup:
- virtio devices (/dev/disk/by-id/virtio-kdevops0)
- 9p kernel modules and filesystem support
- target directory structure (/data/linux-stable)
- etc.

Fixes: 7f25db722 ("bootlinux: add support for A/B kernel testing")

Generated-by: Claude AI
Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
---
 workflows/linux/Makefile | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/workflows/linux/Makefile b/workflows/linux/Makefile
index 1ab9d55d..23a59968 100644
--- a/workflows/linux/Makefile
+++ b/workflows/linux/Makefile
@@ -101,8 +101,9 @@ ifeq (y,$(CONFIG_BOOTLINUX_AB_DIFFERENT_REF))
 linux: linux-baseline linux-dev
 else
 linux: $(KDEVOPS_NODES)
-	$(Q)ansible-playbook $(ANSIBLE_VERBOSE) -i \
-		hosts $(KDEVOPS_PLAYBOOKS_DIR)/bootlinux.yml \
+	$(Q)ansible-playbook $(ANSIBLE_VERBOSE) \
+		--limit 'baseline:dev' \
+		$(KDEVOPS_PLAYBOOKS_DIR)/bootlinux.yml \
 		--extra-vars="$(BOOTLINUX_ARGS)" $(LIMIT_HOSTS)
 endif
 else
@@ -116,9 +117,10 @@ endif
 PHONY += linux-baseline
 ifeq (y,$(CONFIG_KDEVOPS_BASELINE_AND_DEV))
 linux-baseline: $(KDEVOPS_NODES)
-	$(Q)ansible-playbook $(ANSIBLE_VERBOSE) -i \
-		hosts $(KDEVOPS_PLAYBOOKS_DIR)/bootlinux.yml \
-		--extra-vars="$(BOOTLINUX_ARGS)" --limit baseline
+	$(Q)ansible-playbook $(ANSIBLE_VERBOSE) \
+		--limit baseline \
+		$(KDEVOPS_PLAYBOOKS_DIR)/bootlinux.yml \
+		--extra-vars="$(BOOTLINUX_ARGS)"
 else
 linux-baseline:
 	@echo "linux-baseline requires KDEVOPS_BASELINE_AND_DEV=y"
@@ -128,9 +130,10 @@ endif
 PHONY += linux-dev
 ifeq (y,$(CONFIG_KDEVOPS_BASELINE_AND_DEV))
 linux-dev: $(KDEVOPS_NODES)
-	$(Q)ansible-playbook $(ANSIBLE_VERBOSE) -i \
-		hosts $(KDEVOPS_PLAYBOOKS_DIR)/bootlinux.yml \
-		--extra-vars="$(BOOTLINUX_ARGS)" --limit dev
+	$(Q)ansible-playbook $(ANSIBLE_VERBOSE) \
+		--limit dev \
+		$(KDEVOPS_PLAYBOOKS_DIR)/bootlinux.yml \
+		--extra-vars="$(BOOTLINUX_ARGS)"
 else
 linux-dev:
 	@echo "linux-dev requires KDEVOPS_BASELINE_AND_DEV=y"

-- 
2.50.1


  reply	other threads:[~2025-09-17  8:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-17  8:32 [PATCH 0/4] Fix inconsistent ansible-playbook patterns across kdevops Daniel Gomez
2025-09-17  8:32 ` Daniel Gomez [this message]
2025-09-17  8:32 ` [PATCH 2/4] workflows: fix inconsistent ansible-playbook patterns and invalid host groups Daniel Gomez
2025-09-17  8:32 ` [PATCH 3/4] docs: remove deprecated -i hosts pattern from CLAUDE.md example Daniel Gomez
2025-09-17  8:32 ` [PATCH 4/4] terraform: remove redundant ansible inventory and connection overrides Daniel Gomez
2025-09-17 14:28 ` [PATCH 0/4] Fix inconsistent ansible-playbook patterns across kdevops Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250917-fix-groups-v1-1-d6cd940f8b6e@samsung.com \
    --to=da.gomez@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=da.gomez@samsung.com \
    --cc=kdevops@lists.linux.dev \
    --cc=mcgrof@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox