From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25FB42E0927 for ; Wed, 17 Sep 2025 08:33:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758097988; cv=none; b=hOT8ptj4jQi2ertuMIgXZO60Fb+6wmn4nD6l20W5QnT2g9ov0CtOvP1lkEnPq/KdOPXVZSN9Z58u9t98W5So/xKKvfVv3sVAYKOrylacDDUUTYsOv5vgB6ClKF9cgY44jdQxD14z1E5dHQv8uqLvnA4gu1XnUECSswspkmyR74g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758097988; c=relaxed/simple; bh=tVWYr9ilWnwInyCSb0I0GNGuuWdcsjASXD3PPUB1MPg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Bx1UVcUeIyEHVhsCse2kgqsY5E/wemIvNFLEvoKyE+SxsPikaEHh23+PZhyDZMcWlw8shVcBJ2pCK5IM7RZDaALBgB4BTWXnzyPIMBkB/iVKUvk491kCBOWpOZMKILRHKG7jrSxxnRrUqji5sJuytd7n89cdCkbgda/ATQ7CTeU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sfYF0k5c; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sfYF0k5c" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E79D1C4CEF0; Wed, 17 Sep 2025 08:33:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758097987; bh=tVWYr9ilWnwInyCSb0I0GNGuuWdcsjASXD3PPUB1MPg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=sfYF0k5cLGI1n5K9SjBu/bT/4dkM1KInOhlGnWaSNp7/9l/YFzUH3yIciCUPWjd3f v16RhLfmItNOQ4DZO/X6N5X+vDeck8yuE+rzSw+NLFJ9LrUeZUZyZ3Pbt/azTE5jwu 8tLgRDutF/KEVZ6oJaJx/94ERJzVzoWO7+lnCo0BmVAXQsBuTEkUj79Dj7Q/XLtGtH AI3lfCpT79oc3fyW8RiOQJL5VwLkUTGu8l3jXCJXgQUUKoLWtRt/v/QswwhyoBaJFm 9u26RTO67zX7q6SsMBaI2XYX5iYfc0N6RGeXumHdfByvpyJRgNZ06VThoUsvgRckhX j3z0dvR9HHPAQ== From: Daniel Gomez Date: Wed, 17 Sep 2025 10:32:37 +0200 Subject: [PATCH 2/4] workflows: fix inconsistent ansible-playbook patterns and invalid host groups Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250917-fix-groups-v1-2-d6cd940f8b6e@samsung.com> References: <20250917-fix-groups-v1-0-d6cd940f8b6e@samsung.com> In-Reply-To: <20250917-fix-groups-v1-0-d6cd940f8b6e@samsung.com> To: Luis Chamberlain , Chuck Lever Cc: kdevops@lists.linux.dev, Daniel Gomez X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=9379; i=da.gomez@samsung.com; h=from:subject:message-id; bh=w6EUnEvKNASONEBxD59jIeI4z9RbpgJGElcOm3Z4UaQ=; b=owEBbQKS/ZANAwAIAUCeo8QfGVH7AcsmYgBoynI3//NdE+x9/b+JftIDGdVoLdfuTy2dqv54R 1UWC9HUHbuJAjMEAAEIAB0WIQTvdRrhHw9z4bnGPFNAnqPEHxlR+wUCaMpyNwAKCRBAnqPEHxlR +2VlD/4zh45I/5xtkEF26RbTiEZZ4Ctdeqs6lIeBo9KOCSCGMv8VPfvHgqSVhsHc4hHM5q7Lpk+ FsUfU2DiKxZlCR6P1P/0J2VmS/nvgEjz6SunENDtX9VUzCBneU/6y/dU1teuMwd1jj6OtO6GK1m Yw7M5I6ZnbEa0GHMjBwPXY0kMBv+IWJgBiAW0loCeAJA+jQmvnWE9AYYV+NkPiHK+QCzdStbuJx wd28aroAV4fPJTljMyNiz0rOOHqPaCTTrWCMoBTVUGSliUiXay/3AmJcyZILWXs5E6tAU7QQ1mY ZCtB4KFq1laos/e0lMTBwv4d6RZBfJ9i+pPmntNiETiEiNyv4hCgyMI4kIqGQ4LJiqeHVriNct9 nYx2iHgrQ0AKWhqMGfKHB4ejy/IzHqMOYmf1EJY7y5dZVuEF8AkEkQ7cwAfXqG9TK3z8+CTV4Cv BW+0FuG9YtHtQgh2enaVpL0SGJ8FyGGY8woW47jjvagsiqqrgZxdpqNauvpW8kKj+N4xpyGt2b3 PcAyaHJSU2YHDBbViBv/Ef2kXmJLBO4OBnaXQWY7+kBnzfy5MpRKwOXwhXdpLJ2HBeIyn7kPUwK H7eSlf9xRQqyDCFxdA+OqgGQM7AxoHtC9uMe/KO8Nh5LG34KBYD4O1xetpQWCK5ZmJDAzv91RXG KyySIN1sN3iDeeA== X-Developer-Key: i=da.gomez@samsung.com; a=openpgp; fpr=B2A7A9CFDD03B540FF58B27185F56EA4E9E8138F From: Daniel Gomez Multiple issues were introduced in commit 7f25db722: 1. Workflow Makefiles using "-i hosts" explicitly instead of relying on ansible.cfg inventory configuration 2. AI and minio workflows incorrectly using custom host groups "ai" and "minio" instead of standard kdevops host groups 3. Redundant "-f" fork parameters when ansible.cfg already configures forks The only valid host groups in kdevops are: all, baseline, dev, and service. Custom workflow-specific host groups violate the established architecture. This removes invalid groups, the -i/--inventory arguments, -f/--forks parameters + leverages the ansible.cfg configuration. Fixes: 7f25db722 ("bootlinux: add support for A/B testing different kernel refs") Generated-by: Claude AI Signed-off-by: Luis Chamberlain --- playbooks/ai_benchmark.yml | 2 +- playbooks/ai_destroy.yml | 2 +- playbooks/ai_install.yml | 2 +- playbooks/ai_results.yml | 2 +- playbooks/ai_setup.yml | 2 +- playbooks/ai_tests.yml | 6 +++--- playbooks/ai_uninstall.yml | 2 +- playbooks/minio.yml | 10 +++++----- workflows/ai/Makefile | 14 -------------- workflows/minio/Makefile | 8 ++++---- 10 files changed, 18 insertions(+), 32 deletions(-) diff --git a/playbooks/ai_benchmark.yml b/playbooks/ai_benchmark.yml index 85fc117c..5ce45fdc 100644 --- a/playbooks/ai_benchmark.yml +++ b/playbooks/ai_benchmark.yml @@ -1,6 +1,6 @@ --- - name: Run Milvus Vector Database Benchmarks - hosts: ai + hosts: baseline:dev vars: ai_vector_db_milvus_benchmark_enable: true roles: diff --git a/playbooks/ai_destroy.yml b/playbooks/ai_destroy.yml index eef07b2a..ba1a31b5 100644 --- a/playbooks/ai_destroy.yml +++ b/playbooks/ai_destroy.yml @@ -1,6 +1,6 @@ --- - name: Destroy Milvus Vector Database - hosts: ai + hosts: baseline:dev become: true tasks: - name: Stop Milvus containers diff --git a/playbooks/ai_install.yml b/playbooks/ai_install.yml index 38e6671c..1cc2f6c2 100644 --- a/playbooks/ai_install.yml +++ b/playbooks/ai_install.yml @@ -1,6 +1,6 @@ --- - name: Install Milvus Vector Database - hosts: ai + hosts: baseline:dev become: true become_user: root roles: diff --git a/playbooks/ai_results.yml b/playbooks/ai_results.yml index 881295eb..64216d61 100644 --- a/playbooks/ai_results.yml +++ b/playbooks/ai_results.yml @@ -1,6 +1,6 @@ --- - name: Collect and analyze AI benchmark results - hosts: ai + hosts: baseline:dev roles: - ai_collect_results tags: ['ai', 'ai_results'] diff --git a/playbooks/ai_setup.yml b/playbooks/ai_setup.yml index f0007ee2..eceda156 100644 --- a/playbooks/ai_setup.yml +++ b/playbooks/ai_setup.yml @@ -1,6 +1,6 @@ --- - name: Setup AI benchmark environment - hosts: ai + hosts: baseline:dev roles: - ai_setup tags: ['ai', 'ai_setup'] diff --git a/playbooks/ai_tests.yml b/playbooks/ai_tests.yml index 1a5638fc..728196bd 100644 --- a/playbooks/ai_tests.yml +++ b/playbooks/ai_tests.yml @@ -3,7 +3,7 @@ # This ensures AI infrastructure is setup before running benchmarks - name: AI Tests - Ensure Milvus is installed - hosts: ai + hosts: baseline:dev become: true become_user: root roles: @@ -12,7 +12,7 @@ tags: ['ai', 'milvus', 'setup'] - name: AI Tests - Vector Database Benchmarks - hosts: ai + hosts: baseline:dev become: true vars: # Skip infrastructure setup when running tests @@ -23,7 +23,7 @@ tags: ['ai', 'benchmark'] - name: AI Tests - Results Collection - hosts: ai + hosts: baseline:dev become: true roles: - role: ai_collect_results diff --git a/playbooks/ai_uninstall.yml b/playbooks/ai_uninstall.yml index fb537664..3894ef05 100644 --- a/playbooks/ai_uninstall.yml +++ b/playbooks/ai_uninstall.yml @@ -1,6 +1,6 @@ --- - name: Uninstall AI benchmark components - hosts: ai + hosts: baseline:dev roles: - ai_uninstall tags: ['ai', 'ai_uninstall'] diff --git a/playbooks/minio.yml b/playbooks/minio.yml index bf80bbf4..2855a8fe 100644 --- a/playbooks/minio.yml +++ b/playbooks/minio.yml @@ -2,7 +2,7 @@ # MinIO S3 Storage Benchmarking Playbook - name: Install MinIO and setup - hosts: minio + hosts: baseline:dev become: true become_user: root tags: ['minio_install'] @@ -21,7 +21,7 @@ minio_docker_network: "{{ minio_docker_network_name }}" - name: Run MinIO Warp benchmarks - hosts: minio + hosts: baseline:dev become: true become_user: root tags: ['minio_warp'] @@ -29,7 +29,7 @@ - role: minio_warp_run - name: Uninstall MinIO - hosts: minio + hosts: baseline:dev become: true become_user: root tags: ['minio_uninstall'] @@ -37,7 +37,7 @@ - role: minio_uninstall - name: Destroy MinIO and cleanup - hosts: minio + hosts: baseline:dev become: true become_user: root tags: ['minio_destroy'] @@ -45,7 +45,7 @@ - role: minio_destroy - name: Analyze MinIO results - hosts: minio + hosts: baseline:dev become: true become_user: root tags: ['minio_results'] diff --git a/workflows/ai/Makefile b/workflows/ai/Makefile index 7e9b8af2..62731bae 100644 --- a/workflows/ai/Makefile +++ b/workflows/ai/Makefile @@ -31,9 +31,7 @@ export AI_ARGS_SEPARATED := $(subst $(space),$(comma),$(AI_ARGS)) # Main AI workflow targets ai: $(KDEVOPS_NODES) $(ANSIBLE_INVENTORY_FILE) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts \ playbooks/ai.yml \ - -f 10 \ --extra-vars=@$(KDEVOPS_EXTRA_VARS) \ --extra-vars="$(AI_ARGS) $(AI_MANUAL_ARGS)" \ $(LIMIT_HOSTS) @@ -47,9 +45,7 @@ ai-dev: # AI Testing/Benchmark targets ai-tests: $(KDEVOPS_NODES) $(ANSIBLE_INVENTORY_FILE) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts \ playbooks/ai_tests.yml \ - -f 10 \ --extra-vars=@$(KDEVOPS_EXTRA_VARS) \ --extra-vars="$(AI_ARGS) $(AI_MANUAL_ARGS)" \ $(LIMIT_HOSTS) @@ -58,9 +54,7 @@ ai-tests: $(KDEVOPS_NODES) $(ANSIBLE_INVENTORY_FILE) ai-tests-baseline: $(KDEVOPS_NODES) $(ANSIBLE_INVENTORY_FILE) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ -l baseline \ - -i hosts \ playbooks/ai_tests.yml \ - -f 10 \ --extra-vars=@$(KDEVOPS_EXTRA_VARS) \ --extra-vars="$(AI_ARGS) $(AI_MANUAL_ARGS)" $(Q)$(MAKE) ai-results-baseline @@ -68,9 +62,7 @@ ai-tests-baseline: $(KDEVOPS_NODES) $(ANSIBLE_INVENTORY_FILE) ai-tests-dev: $(KDEVOPS_NODES) $(ANSIBLE_INVENTORY_FILE) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ -l dev \ - -i hosts \ playbooks/ai_tests.yml \ - -f 10 \ --extra-vars=@$(KDEVOPS_EXTRA_VARS) \ --extra-vars="$(AI_ARGS) $(AI_MANUAL_ARGS)" $(Q)$(MAKE) ai-results-dev @@ -78,9 +70,7 @@ ai-tests-dev: $(KDEVOPS_NODES) $(ANSIBLE_INVENTORY_FILE) # Target to only run results analysis and graph generation ai-tests-results: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts \ playbooks/ai_tests.yml \ - -f 10 \ --extra-vars=@$(KDEVOPS_EXTRA_VARS) \ --extra-vars="$(AI_ARGS) $(AI_MANUAL_ARGS)" \ --tags="results" \ @@ -89,7 +79,6 @@ ai-tests-results: # Results collection targets ai-results: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts \ playbooks/ai_results.yml \ --extra-vars=@$(KDEVOPS_EXTRA_VARS) \ --extra-vars="$(AI_ARGS) $(AI_MANUAL_ARGS)" \ @@ -103,7 +92,6 @@ ai-results-dev: ai-setup: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts \ playbooks/ai_setup.yml \ --extra-vars=@$(KDEVOPS_EXTRA_VARS) \ --extra-vars="$(AI_ARGS) $(AI_MANUAL_ARGS)" \ @@ -111,7 +99,6 @@ ai-setup: ai-uninstall: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts \ playbooks/ai_uninstall.yml \ --extra-vars=@$(KDEVOPS_EXTRA_VARS) \ --extra-vars="$(AI_ARGS) $(AI_MANUAL_ARGS)" \ @@ -119,7 +106,6 @@ ai-uninstall: ai-destroy: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -i hosts \ playbooks/ai_destroy.yml \ --extra-vars=@$(KDEVOPS_EXTRA_VARS) \ --extra-vars="$(AI_ARGS) $(AI_MANUAL_ARGS)" \ diff --git a/workflows/minio/Makefile b/workflows/minio/Makefile index c543ed3b..05b822a0 100644 --- a/workflows/minio/Makefile +++ b/workflows/minio/Makefile @@ -14,25 +14,25 @@ $(MINIO_DATA_TARGET): $(ANSIBLE_INVENTORY_FILE) $(MINIO_DATA_TARGET_INSTALL): $(ANSIBLE_INVENTORY_FILE) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -f 30 -i hosts $(MINIO_PLAYBOOK) \ + $(MINIO_PLAYBOOK) \ --extra-vars=@$(KDEVOPS_EXTRA_VARS) \ --tags vars,minio_install $(MINIO_DATA_TARGET_UNINSTALL): $(ANSIBLE_INVENTORY_FILE) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -f 30 -i hosts $(MINIO_PLAYBOOK) \ + $(MINIO_PLAYBOOK) \ --extra-vars=@$(KDEVOPS_EXTRA_VARS) \ --tags vars,minio_uninstall $(MINIO_DATA_TARGET_DESTROY): $(ANSIBLE_INVENTORY_FILE) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -f 30 -i hosts $(MINIO_PLAYBOOK) \ + $(MINIO_PLAYBOOK) \ --extra-vars=@$(KDEVOPS_EXTRA_VARS) \ --tags vars,minio_destroy $(MINIO_DATA_TARGET_RUN): $(ANSIBLE_INVENTORY_FILE) $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - -f 30 -i hosts $(MINIO_PLAYBOOK) \ + $(MINIO_PLAYBOOK) \ --extra-vars=@$(KDEVOPS_EXTRA_VARS) \ --tags vars,minio_warp -- 2.50.1