From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 898162165EA for ; Wed, 17 Sep 2025 08:33:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758097990; cv=none; b=sh8sFvCRs1Txl6M8yY+KR6vtT3ODZJFxAovY5bCkUaaf5OeBoEvpQ7nIqYA+jbluW1S855OkN4vny2bA1s/9drcy9OUaM/qD1nIwyVmC0FdD+T3ujvXkbUlP7xriH4Pws8dlSbCqpFN3RhVLfGtrv6oiyp/mNIvHTlQ7ZvjGsQM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758097990; c=relaxed/simple; bh=W/GxqRGrJyRxQOcQmh6udPkEGaEM4OzQBvefdKlLJRY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Q6l3+RMfC7Q73ytoNZ+IHYl8achytQWYf8z1c08v8zTe0JvD1SQyJ+aukvW9bYQNwm6o2Ir48by8KhiVtTTTCNVnCS5eDqIiszy3s9KYW3qSHFohO+13dk+CK9rP4ILg0qo7Gj4THw5E+ZDbS7HPQetUJ1Yg/f096cBY1k/zA2E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NvJ1jIG3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NvJ1jIG3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58FBDC4CEFB; Wed, 17 Sep 2025 08:33:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758097990; bh=W/GxqRGrJyRxQOcQmh6udPkEGaEM4OzQBvefdKlLJRY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=NvJ1jIG3PLNJmZ61VFZxcDzhVxUJEPfiAwNtBL9l0qY0763sy3Hl6noJx0nZFDcPR rEALlTCGSz8o3mw5cbaBWyjFZ/Qonb2S8JHUryttVM+oSkhOuB66NS8Aofb0hMbE97 y+h7nU+y7HYQFKFlnWxRaBDDNUYZD+RPztheW5I3cew7YGPmfZBH+GfCH6GA/AT6DG Xpezo35ONeDvR1i9w7BG+86oYejvtRPaJg4DiQ+zPcJ7FaA+J14315EVGOxkWAZ3MM WgLetMJwXZsvgz/KLWSEL2NSYnzBVoFlDpr9NFUUB/Rg4qUjel+wKHTu1PG3s//aJA 5ofG6NmlNXQ1Q== From: Daniel Gomez Date: Wed, 17 Sep 2025 10:32:39 +0200 Subject: [PATCH 4/4] terraform: remove redundant ansible inventory and connection overrides Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250917-fix-groups-v1-4-d6cd940f8b6e@samsung.com> References: <20250917-fix-groups-v1-0-d6cd940f8b6e@samsung.com> In-Reply-To: <20250917-fix-groups-v1-0-d6cd940f8b6e@samsung.com> To: Luis Chamberlain , Chuck Lever Cc: kdevops@lists.linux.dev, Daniel Gomez X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=2558; i=da.gomez@samsung.com; h=from:subject:message-id; bh=zkbxrfTecQxrIImCAur/52kHZebv5ArSPTumOYP8Yho=; b=owEBbQKS/ZANAwAIAUCeo8QfGVH7AcsmYgBoynI8fHFi8fXWuyuYFAED04fnh2LwmQ4vKNJyp xOB4nIADRGJAjMEAAEIAB0WIQTvdRrhHw9z4bnGPFNAnqPEHxlR+wUCaMpyPAAKCRBAnqPEHxlR +8HHD/0a2lw2i3wYNxZFvMe1pcgV5UqnCnq0fjSlbuJW8/gnrSgFSMfag/nHnJWJi5eiQlkBmjR BvE6XWD5YO3HHOO93YPp30ffAHPu4Qzvujqq5MC1PBkZ6ZgGpmsyVpHwdIdezkk72wGoZAuw3Al Sxw3/l0Qz9WOCdC6sBcjlq/izov7jKGCPf5kLeNuu5UL8l+0ClSIXhzhFQ4VU/rnY36Vdz8FuJa 0gXirDkhkP3BWupLJGLelrmMeRg4SY0J7LojOdDYXR/NanrCjJ1sgSBtrxSE82SroZPy4yDuGtN F0fokHB+Xy2yOZZ5tWfk9mZ6Q+VF7/gsOODoCu1vs0BxTFK54l5borMfsfby6hP/NuMQWQTvTSm R1tkLc3OxitWPbbfVYZ8znJomVeeKfFsVF2MJhp3T80Bp73qaTpeDTpiK+MAXDFw0Rv9PJ0K+gC iyYnijEtNhki18OFdrH4rLk1ob8otJJ1Y2qVg4Z2uDkcyHIF2WgWBY2eXveDgjMHn4t8Ej4SQaF rnGXCGoowJl5PQB1dvpGWE8NelPcBrO15Ordg8r9dIzLMXXWy5gEVCzGXDtiu9Q5YrTxPcJvU9k 4Rd9pgD10QxKRkfGs+moQXlZQedbxltHMkviZzs4dYWiSKnvxqul2fN5Bj/Ij5k9O4Vi8F2ctSH 9YkKBOEtoP+bUJQ== X-Developer-Key: i=da.gomez@samsung.com; a=openpgp; fpr=B2A7A9CFDD03B540FF58B27185F56EA4E9E8138F From: Daniel Gomez Remove unnecessary --inventory localhost, and connection: local parameters and embrace the ansible.cfg and playbook hosts fields. Generated-by: Claude AI Signed-off-by: Daniel Gomez --- playbooks/gen_tfvars.yml | 1 - playbooks/terraform.yml | 1 - scripts/terraform.Makefile | 7 +------ 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/playbooks/gen_tfvars.yml b/playbooks/gen_tfvars.yml index 11437fa2..9d75c868 100644 --- a/playbooks/gen_tfvars.yml +++ b/playbooks/gen_tfvars.yml @@ -1,6 +1,5 @@ --- - name: Generate Terraform variables file (terraform/terraform.tfvars) - connection: local hosts: localhost roles: - role: gen_tfvars diff --git a/playbooks/terraform.yml b/playbooks/terraform.yml index a740f79f..61a16a2c 100644 --- a/playbooks/terraform.yml +++ b/playbooks/terraform.yml @@ -1,6 +1,5 @@ --- - name: Manage infrastructure lifecycle and SSH access with Terraform - connection: local hosts: localhost gather_facts: false roles: diff --git a/scripts/terraform.Makefile b/scripts/terraform.Makefile index 4d738c82..ef11e0e3 100644 --- a/scripts/terraform.Makefile +++ b/scripts/terraform.Makefile @@ -203,23 +203,20 @@ endif bringup_terraform: lambdalabs-ssh-check $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - --inventory localhost, \ playbooks/terraform.yml --tags bringup \ --extra-vars=@./extra_vars.yaml $(KDEVOPS_PROVISIONED_SSH): $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - --inventory localhost, \ playbooks/terraform.yml --tags ssh \ --extra-vars=@./extra_vars.yaml $(Q)ansible $(ANSIBLE_VERBOSE) \ - -i hosts baseline:dev:service \ + baseline:dev:service \ -m wait_for_connection $(Q)touch $(KDEVOPS_PROVISIONED_SSH) status_terraform: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - --inventory localhost, \ playbooks/terraform.yml --tags status \ --extra-vars=@./extra_vars.yaml @@ -227,13 +224,11 @@ destroy_terraform: destroy_terraform_base lambdalabs-ssh-clean-after destroy_terraform_base: $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - --inventory localhost, \ playbooks/terraform.yml --tags destroy \ --extra-vars=@./extra_vars.yaml $(Q)rm -f $(KDEVOPS_PROVISIONED_SSH) $(KDEVOPS_PROVISIONED_DEVCONFIG) $(KDEVOPS_TFVARS): $(KDEVOPS_TFVARS_TEMPLATE) .config $(Q)ansible-playbook $(ANSIBLE_VERBOSE) \ - --inventory localhost, \ $(KDEVOPS_PLAYBOOKS_DIR)/gen_tfvars.yml \ --extra-vars=@./extra_vars.yaml -- 2.50.1