From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEFDD2749CF for ; Mon, 22 Sep 2025 09:36:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758533819; cv=none; b=OwbLlPxrHApzaq7pUG5FS4NhOtFMp0VqlCJ/VPNqwbXKNFJI5pl8E/38424ZOelZxMFfDrRPWfdzi8rM1T3/eEmM5RQap0s/lKvmxTjepakemXZEWXP6GHwEQGWOL2oSmagD3tXnACHkxdXhTBIuZ+8ABJr6S4AVEBvowoyp49U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758533819; c=relaxed/simple; bh=hYiWlviZuJbmqHT6Wutcae/qB4v7Vv/dM7mpAz/YznE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PicI+cw+5RFafswl3IO4ZGQbsIC9Xwa9x1D5v+JHU9fh5ORqww67BisWoUh7/EsJgtMEu0FVcNyAe8qMMHQ2xYhE4lH7B0ZbS+QDXlW91gSBnrJ1YWe/2J4BQY7GiDgzVvOLhe5y2Y1IY6Iw64DKVbQqQpNBCs2Sl1xx1vG5oHw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=a+ro4AvK; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="a+ro4AvK" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=+DnMHgGxUcXGAZ+nitZBgsT0Cw9hO0/nAkjw1guwN3c=; b=a+ro4AvKOUTcu8rWgy9wku7Bz8 I22kMU8HDA6Nk9ZJacckGNLorkGH0uhK71AbxP7s/UguVpLMAbFVti7mMyerLPm6J0AUM5QvCmYpn uw9b1EcIlOiSkZp9JG73TTjvAasO8z6S8iBXohHctzsKYZh0Ti0rmJVMauHQZAEPAoOaJYT+WWLkf ofsHlFCl3K0DJLeEtr6m20zYPXOAGE8KY7gcPxzw/hcuBL6UWb2nLEP7cnTYiV6DC5wtKpK1Q6cZQ wdMv0cBWugiT3KBz4AT1acjlAOtrUwu5lkmXqR1biAjrQrI2gkgSXTMVxZVZLIvAN/ohRP+lmjdVw /C09mIog==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1v0cyf-00000009uDi-2qwm; Mon, 22 Sep 2025 09:36:57 +0000 From: Luis Chamberlain To: Chuck Lever , Daniel Gomez , kdevops@lists.linux.dev Cc: Luis Chamberlain Subject: [PATCH 02/13] devconfig: exclude nfsd from journal upload client configuration Date: Mon, 22 Sep 2025 02:36:44 -0700 Message-ID: <20250922093656.2361016-3-mcgrof@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250922093656.2361016-1-mcgrof@kernel.org> References: <20250922093656.2361016-1-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Luis Chamberlain The NFS server (nfsd group) should not run systemd-journal-upload service as it acts as the journal remote server, not a client. The journal upload service is for clients that send logs to the remote server. Add condition to exclude 'nfsd' group members from journal upload client configuration tasks in both devconfig and fstests roles. This fixes the failure where systemd-journal-upload.service was not found on NFS server nodes, as they should only run the journal remote receiver service, not the upload client. Generated-by: Claude AI Signed-off-by: Luis Chamberlain --- playbooks/roles/devconfig/tasks/main.yml | 3 +++ playbooks/roles/fstests/tasks/main.yml | 1 + 2 files changed, 4 insertions(+) diff --git a/playbooks/roles/devconfig/tasks/main.yml b/playbooks/roles/devconfig/tasks/main.yml index ae16a698..3499f744 100644 --- a/playbooks/roles/devconfig/tasks/main.yml +++ b/playbooks/roles/devconfig/tasks/main.yml @@ -565,6 +565,7 @@ lstrip_blocks: true when: - devconfig_enable_systemd_journal_remote|bool + - "'nfsd' not in group_names" - name: Enable and restart systemd-journal-upload.service on the client tags: ["journal", "journal-upload-restart"] @@ -578,6 +579,7 @@ daemon_reload: true when: - devconfig_enable_systemd_journal_remote|bool + - "'nfsd' not in group_names" - name: Ensure systemd-journal-remote.service is running on the server tags: ["journal-status"] @@ -602,6 +604,7 @@ state: started when: - devconfig_enable_systemd_journal_remote|bool + - "'nfsd' not in group_names" - name: Set up the client /etc/systemd/timesyncd.conf tags: ["timesyncd"] diff --git a/playbooks/roles/fstests/tasks/main.yml b/playbooks/roles/fstests/tasks/main.yml index 3a57a73b..8f44c109 100644 --- a/playbooks/roles/fstests/tasks/main.yml +++ b/playbooks/roles/fstests/tasks/main.yml @@ -1137,6 +1137,7 @@ state: started when: - devconfig_enable_systemd_journal_remote|bool + - "'nfsd' not in group_names" - name: Hint to watchdog tests are about to kick off ansible.builtin.file: -- 2.51.0