From: Luis Chamberlain <mcgrof@kernel.org>
To: Chuck Lever <cel@kernel.org>, Daniel Gomez <da.gomez@kruces.com>,
kdevops@lists.linux.dev
Cc: Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 05/13] nfsd/fstests: fix pNFS block layout iSCSI configuration
Date: Mon, 22 Sep 2025 02:36:47 -0700 [thread overview]
Message-ID: <20250922093656.2361016-6-mcgrof@kernel.org> (raw)
In-Reply-To: <20250922093656.2361016-1-mcgrof@kernel.org>
For pNFS block layout testing, the NFS server must run the iSCSI
target service. Fix the Ansible role execution by:
1. Remove invalid delegate_to from include_role in fstests role
2. Add iSCSI target setup to nfsd role when pNFS is enabled
3. Keep iSCSI initiator setup with correct target hostname
The iSCSI target now runs on the NFS server itself, and test
nodes connect to it as initiators for pNFS block layout access.
Generated-by: Claude AI
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
playbooks/roles/fstests/tasks/main.yml | 8 --------
playbooks/roles/nfsd/tasks/main.yml | 6 ++++++
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/playbooks/roles/fstests/tasks/main.yml b/playbooks/roles/fstests/tasks/main.yml
index 357e33c4..831f5324 100644
--- a/playbooks/roles/fstests/tasks/main.yml
+++ b/playbooks/roles/fstests/tasks/main.yml
@@ -27,14 +27,6 @@
tags: ["oscheck", "git", "fstests"]
when: "fstests_xfs_build_custom_xfsprogs|bool"
-- name: Set up iSCSI target on NFS server for pNFS block layout
- ansible.builtin.include_role:
- name: iscsi
- delegate_to: "{{ fstests_nfs_server_host }}"
- when:
- - fstests_nfs_section_pnfs|bool
- - fstests_nfs_use_kdevops_nfsd|bool
-
- name: Set up an iSCSI initiator on target nodes
ansible.builtin.include_role:
name: iscsi
diff --git a/playbooks/roles/nfsd/tasks/main.yml b/playbooks/roles/nfsd/tasks/main.yml
index cdd53ac9..3a32386d 100644
--- a/playbooks/roles/nfsd/tasks/main.yml
+++ b/playbooks/roles/nfsd/tasks/main.yml
@@ -22,6 +22,12 @@
group: root
mode: "0644"
+- name: Set up iSCSI target on NFS server for pNFS block layout
+ ansible.builtin.include_role:
+ name: iscsi
+ when:
+ - fstests_nfs_section_pnfs|default(false)|bool
+
- name: Set up an iSCSI initiator
ansible.builtin.include_role:
name: iscsi
--
2.51.0
next prev parent reply other threads:[~2025-09-22 9:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 9:36 [PATCH 00/13] nfs: few fixes and enhancements Luis Chamberlain
2025-09-22 9:36 ` [PATCH 01/13] defconfigs: add NFS testing configurations Luis Chamberlain
2025-09-22 9:36 ` [PATCH 02/13] devconfig: exclude nfsd from journal upload client configuration Luis Chamberlain
2025-09-22 9:36 ` [PATCH 03/13] iscsi: add missing initiator packages for Debian Luis Chamberlain
2025-09-22 9:36 ` [PATCH 04/13] fstests: fix pNFS block layout iSCSI setup Luis Chamberlain
2025-09-22 9:36 ` Luis Chamberlain [this message]
2025-09-22 9:36 ` [PATCH 06/13] fstests: set up iSCSI target on NFS server before test nodes Luis Chamberlain
2025-09-22 9:36 ` [PATCH 07/13] fstests: move conditional to play level for iSCSI setup Luis Chamberlain
2025-09-22 9:36 ` [PATCH 08/13] fstests: temporarily disable iSCSI setup for pNFS Luis Chamberlain
2025-09-22 9:36 ` [PATCH 09/13] nfsd_add_export: fix become method for filesystem formatting Luis Chamberlain
2025-09-22 9:36 ` [PATCH 10/13] workflows: fstests: fix incorrect pNFS export configuration Luis Chamberlain
2025-09-22 9:36 ` [PATCH 11/13] nfstest: add results visualization support Luis Chamberlain
2025-09-22 9:36 ` [PATCH 12/13] fstests: add soak duration to nfs template Luis Chamberlain
2025-09-22 9:36 ` [PATCH 13/13] pynfs: add visualization support for test results Luis Chamberlain
2025-09-22 9:46 ` [PATCH 00/13] nfs: few fixes and enhancements Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250922093656.2361016-6-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=cel@kernel.org \
--cc=da.gomez@kruces.com \
--cc=kdevops@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox