From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55A18286D70 for ; Mon, 22 Sep 2025 09:36:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758533819; cv=none; b=OLfhloB1QCk3ECMXTlyPhcZJeBN8YviMlrf9lRiR0sv3go9wbmPxVbTBUpoI6Jz4u6j3BTwnpUoY5P7hvkkRrxdDmdobAOAtlj3HzMfVOpqmV/zScvvacCft7uDD1DvNva4qq8dtRS35iAgl/ulk4MAB6m9bEflCfgQ4ReVtzPo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758533819; c=relaxed/simple; bh=YRMgrNjcwoBa1Oery0s/CQaoF6h9rBawxUZjfo4RA8M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iZCL4Y2pV1AZoLP6082hqFXUAY/yjCnAj8HG+imY3BhuevMxAcf2BptC6U3XjUOhTLIXFXtJcyV8GSaZkN/4ma3TIAeOuj+HECEHLKpYOJd+Ehs2mPQyjE+Nzxcla/DdDKSt3FFirI7j3ys/2Pa4+rbCon8w6aEw8xC1MbEfxw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=jDo/vXXG; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="jDo/vXXG" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=CsIzYkKXJ4HVAham4xsdcxvATzi3xLB0asAuwm3uW7c=; b=jDo/vXXGcVTyfB/hMTjQStbhD0 jGyeqGmLmJeNqE/afW2qvsey0aEL2D5mlOFgWnfqvIqUT2GTKwg+l9WGp4V9XaG7Tvw4rB7JT0UP4 MhGCZt+bnHwiQmN+l+wVDTurazx5rsAoy+8rIZ1bnLJXDfh+bXeiaMGx6gIRm4lEKcMU1ep3rvke9 fyEksr3GgqscI/H4hkWDDKOHP0qu5R7VQIMpi36eKyR89N0wyP0TnwgOALhIazxaFOvHLtQoU1ZLv Xy3qvqasC6InBgjc2EL7FvogcOWjO6DDgYkXqwXl7Jxjs1SKgB0FGEazyW8SRNrXDYJexJ7WF0lD6 OYjdklOg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1v0cyf-00000009uE1-3I1J; Mon, 22 Sep 2025 09:36:57 +0000 From: Luis Chamberlain To: Chuck Lever , Daniel Gomez , kdevops@lists.linux.dev Cc: Luis Chamberlain Subject: [PATCH 05/13] nfsd/fstests: fix pNFS block layout iSCSI configuration Date: Mon, 22 Sep 2025 02:36:47 -0700 Message-ID: <20250922093656.2361016-6-mcgrof@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250922093656.2361016-1-mcgrof@kernel.org> References: <20250922093656.2361016-1-mcgrof@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Luis Chamberlain For pNFS block layout testing, the NFS server must run the iSCSI target service. Fix the Ansible role execution by: 1. Remove invalid delegate_to from include_role in fstests role 2. Add iSCSI target setup to nfsd role when pNFS is enabled 3. Keep iSCSI initiator setup with correct target hostname The iSCSI target now runs on the NFS server itself, and test nodes connect to it as initiators for pNFS block layout access. Generated-by: Claude AI Signed-off-by: Luis Chamberlain --- playbooks/roles/fstests/tasks/main.yml | 8 -------- playbooks/roles/nfsd/tasks/main.yml | 6 ++++++ 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/playbooks/roles/fstests/tasks/main.yml b/playbooks/roles/fstests/tasks/main.yml index 357e33c4..831f5324 100644 --- a/playbooks/roles/fstests/tasks/main.yml +++ b/playbooks/roles/fstests/tasks/main.yml @@ -27,14 +27,6 @@ tags: ["oscheck", "git", "fstests"] when: "fstests_xfs_build_custom_xfsprogs|bool" -- name: Set up iSCSI target on NFS server for pNFS block layout - ansible.builtin.include_role: - name: iscsi - delegate_to: "{{ fstests_nfs_server_host }}" - when: - - fstests_nfs_section_pnfs|bool - - fstests_nfs_use_kdevops_nfsd|bool - - name: Set up an iSCSI initiator on target nodes ansible.builtin.include_role: name: iscsi diff --git a/playbooks/roles/nfsd/tasks/main.yml b/playbooks/roles/nfsd/tasks/main.yml index cdd53ac9..3a32386d 100644 --- a/playbooks/roles/nfsd/tasks/main.yml +++ b/playbooks/roles/nfsd/tasks/main.yml @@ -22,6 +22,12 @@ group: root mode: "0644" +- name: Set up iSCSI target on NFS server for pNFS block layout + ansible.builtin.include_role: + name: iscsi + when: + - fstests_nfs_section_pnfs|default(false)|bool + - name: Set up an iSCSI initiator ansible.builtin.include_role: name: iscsi -- 2.51.0