public inbox for kdevops@lists.linux.dev
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Chuck Lever <cel@kernel.org>, Daniel Gomez <da.gomez@kruces.com>,
	kdevops@lists.linux.dev
Cc: Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 07/13] fstests: move conditional to play level for iSCSI setup
Date: Mon, 22 Sep 2025 02:36:49 -0700	[thread overview]
Message-ID: <20250922093656.2361016-8-mcgrof@kernel.org> (raw)
In-Reply-To: <20250922093656.2361016-1-mcgrof@kernel.org>

Move the pNFS conditional from role level to play level in the
fstests playbook. The when condition needs to be at the play
level to properly evaluate the variable.

Generated-by: Claude AI
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 playbooks/fstests.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/playbooks/fstests.yml b/playbooks/fstests.yml
index 4cb74783..79e27c45 100644
--- a/playbooks/fstests.yml
+++ b/playbooks/fstests.yml
@@ -8,7 +8,7 @@
   hosts: nfsd
   roles:
     - role: iscsi
-      when: fstests_nfs_section_pnfs|default(false)|bool
+  when: fstests_nfs_section_pnfs|default(false)|bool
 
 - name: Configure and run the filesystem testing suite workflow
   hosts: baseline:dev
-- 
2.51.0


  parent reply	other threads:[~2025-09-22  9:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-22  9:36 [PATCH 00/13] nfs: few fixes and enhancements Luis Chamberlain
2025-09-22  9:36 ` [PATCH 01/13] defconfigs: add NFS testing configurations Luis Chamberlain
2025-09-22  9:36 ` [PATCH 02/13] devconfig: exclude nfsd from journal upload client configuration Luis Chamberlain
2025-09-22  9:36 ` [PATCH 03/13] iscsi: add missing initiator packages for Debian Luis Chamberlain
2025-09-22  9:36 ` [PATCH 04/13] fstests: fix pNFS block layout iSCSI setup Luis Chamberlain
2025-09-22  9:36 ` [PATCH 05/13] nfsd/fstests: fix pNFS block layout iSCSI configuration Luis Chamberlain
2025-09-22  9:36 ` [PATCH 06/13] fstests: set up iSCSI target on NFS server before test nodes Luis Chamberlain
2025-09-22  9:36 ` Luis Chamberlain [this message]
2025-09-22  9:36 ` [PATCH 08/13] fstests: temporarily disable iSCSI setup for pNFS Luis Chamberlain
2025-09-22  9:36 ` [PATCH 09/13] nfsd_add_export: fix become method for filesystem formatting Luis Chamberlain
2025-09-22  9:36 ` [PATCH 10/13] workflows: fstests: fix incorrect pNFS export configuration Luis Chamberlain
2025-09-22  9:36 ` [PATCH 11/13] nfstest: add results visualization support Luis Chamberlain
2025-09-22  9:36 ` [PATCH 12/13] fstests: add soak duration to nfs template Luis Chamberlain
2025-09-22  9:36 ` [PATCH 13/13] pynfs: add visualization support for test results Luis Chamberlain
2025-09-22  9:46 ` [PATCH 00/13] nfs: few fixes and enhancements Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250922093656.2361016-8-mcgrof@kernel.org \
    --to=mcgrof@kernel.org \
    --cc=cel@kernel.org \
    --cc=da.gomez@kruces.com \
    --cc=kdevops@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox