From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FCCA33EC for ; Sun, 28 Sep 2025 15:53:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759074824; cv=none; b=BUrmtMdVHyC/qJIRRzO6IVnB3jCgH+LZEfqXXpOHaWHhi28O42hsqn/n/7K4fThnh7K2DZRRouPI4TKu2qM0/9kBdIfjb/hk0y91zcZbCT6FDo8HADRd5DF2EmHTgouIcBndR8zuwuqwPgYsh/9oo6V7fKZ1erolJU3lM0j9+3U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759074824; c=relaxed/simple; bh=1s5UABYtPFigzTWNC52MSXIhOjnHpUpXmpo65MSM5uY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pHfGr5ocvL5ouMp62WGN6Qflnq64uvhQgF2RvB4oXSoQo61YmfSFH7k3M73crBiTzWXmqfUeJkPvbW9EQyID65s4s15dIWDchQ3ioXfHexHGFxBefxqovfcM74OUF54v5TYrsBKwhfq6hlhNeBOUfZa8UUw5v8NAbV3N3UpjemY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qWpe3q13; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qWpe3q13" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D99EC4CEF0; Sun, 28 Sep 2025 15:53:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759074823; bh=1s5UABYtPFigzTWNC52MSXIhOjnHpUpXmpo65MSM5uY=; h=From:To:Cc:Subject:Date:From; b=qWpe3q13er4GjW4ULHYyS8meprqcpQsBHgktoyyIKg7ZgEbij/Zq6lYkZBNIelyJY I4VZIvMAHRTU2wBMcRM+Stklr6fYEGqZE0apEXFrejMSDuXBORwIm0JkgGPtwhxsjo +RH3uhJ6UmAlrusqnicLAHwkRTEbb4Z4yfF4hM6tt4wpGjineiidckgGRD3z1Vtu0M ZYgzwh7cHa/+eiev8DRzCMRvJZzOKBCJoVeuxKLR5ROG28iyKsfEtKkKRJaxWKhiZh lPbMLzcpJ30qCkVWuDA/ebY/QUW4pcLeAZn5Bc9nYhhhv40SXLApm31z2xPVVhyyEp YA1McF9WVKwGg== From: Chuck Lever To: Daniel Gomez Cc: , Chuck Lever Subject: [RFC PATCH] Makefile: terraform wasn't building the kdevops_nodes file Date: Sun, 28 Sep 2025 11:53:41 -0400 Message-ID: <20250928155341.901825-1-cel@kernel.org> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chuck Lever When "make bringup" runs "terraform plan", it complains that the kdevops_nodes variable isn't set. extra_vars.yaml does contain the variable, but I'm guessing that somehow gen_nodes runs after gen_tfvars now? Not really sure. Fixes: 5457b742d611 ("Makefile: fix target dependency order") Signed-off-by: Chuck Lever --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index fb7e9b816dbc..c1dd1232c7ff 100644 --- a/Makefile +++ b/Makefile @@ -258,7 +258,7 @@ ifneq (,$(KDEVOPS_BRING_UP_DEPS)) include scripts/bringup.Makefile endif -$(ANSIBLE_INVENTORY_FILE): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_HOSTS_TEMPLATE) $(KDEVOPS_EXTRA_VARS) +$(ANSIBLE_INVENTORY_FILE): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_HOSTS_TEMPLATE) $(KDEVOPS_NODES) $(KDEVOPS_EXTRA_VARS) $(Q)ANSIBLE_LOCALHOST_WARNING=False ANSIBLE_INVENTORY_UNPARSED_WARNING=False \ ansible-playbook $(ANSIBLE_VERBOSE) \ $(KDEVOPS_PLAYBOOKS_DIR)/gen_hosts.yml \ -- 2.51.0