From: Chuck Lever <cel@kernel.org>
To: <kdevops@lists.linux.dev>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH v2 2/8] devconfig: exclude nfsd from journal upload client configuration
Date: Fri, 3 Oct 2025 16:19:50 -0400 [thread overview]
Message-ID: <20251003201958.24452-3-cel@kernel.org> (raw)
In-Reply-To: <20251003201958.24452-1-cel@kernel.org>
From: Luis Chamberlain <mcgrof@kernel.org>
The NFS server (nfsd group) should not run systemd-journal-upload
service as it acts as the journal remote server, not a client.
The journal upload service is for clients that send logs to the
remote server.
Add condition to exclude 'nfsd' group members from journal upload
client configuration tasks in both devconfig and fstests roles.
This fixes the failure where systemd-journal-upload.service was
not found on NFS server nodes, as they should only run the
journal remote receiver service, not the upload client.
Generated-by: Claude AI
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
playbooks/roles/devconfig/tasks/main.yml | 3 +++
playbooks/roles/fstests/tasks/main.yml | 1 +
2 files changed, 4 insertions(+)
diff --git a/playbooks/roles/devconfig/tasks/main.yml b/playbooks/roles/devconfig/tasks/main.yml
index ae16a6982322..3499f74443ad 100644
--- a/playbooks/roles/devconfig/tasks/main.yml
+++ b/playbooks/roles/devconfig/tasks/main.yml
@@ -565,6 +565,7 @@
lstrip_blocks: true
when:
- devconfig_enable_systemd_journal_remote|bool
+ - "'nfsd' not in group_names"
- name: Enable and restart systemd-journal-upload.service on the client
tags: ["journal", "journal-upload-restart"]
@@ -578,6 +579,7 @@
daemon_reload: true
when:
- devconfig_enable_systemd_journal_remote|bool
+ - "'nfsd' not in group_names"
- name: Ensure systemd-journal-remote.service is running on the server
tags: ["journal-status"]
@@ -602,6 +604,7 @@
state: started
when:
- devconfig_enable_systemd_journal_remote|bool
+ - "'nfsd' not in group_names"
- name: Set up the client /etc/systemd/timesyncd.conf
tags: ["timesyncd"]
diff --git a/playbooks/roles/fstests/tasks/main.yml b/playbooks/roles/fstests/tasks/main.yml
index f12bfdaeba03..c3dcecf538b8 100644
--- a/playbooks/roles/fstests/tasks/main.yml
+++ b/playbooks/roles/fstests/tasks/main.yml
@@ -1137,6 +1137,7 @@
state: started
when:
- devconfig_enable_systemd_journal_remote|bool
+ - "'nfsd' not in group_names"
- name: Hint to watchdog tests are about to kick off
ansible.builtin.file:
--
2.51.0
next prev parent reply other threads:[~2025-10-03 20:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 20:19 [PATCH v2 0/8] nfs: few fixes and enhancements Chuck Lever
2025-10-03 20:19 ` [PATCH v2 1/8] defconfigs: add NFS testing configurations Chuck Lever
2025-10-03 20:19 ` Chuck Lever [this message]
2025-10-03 20:19 ` [PATCH v2 3/8] iscsi: add missing initiator packages for Debian Chuck Lever
2025-10-03 20:19 ` [PATCH v2 4/8] nfsd_add_export: fix become method for filesystem formatting Chuck Lever
2025-10-03 20:19 ` [PATCH v2 5/8] workflows: fstests: fix incorrect pNFS export configuration Chuck Lever
2025-10-03 20:19 ` [PATCH v2 6/8] nfstest: add results visualization support Chuck Lever
2025-10-03 20:19 ` [PATCH v2 7/8] fstests: add soak duration to nfs template Chuck Lever
2025-10-03 20:19 ` [PATCH v2 8/8] pynfs: add visualization support for test results Chuck Lever
2025-10-03 22:57 ` [PATCH v2 0/8] nfs: few fixes and enhancements Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251003201958.24452-3-cel@kernel.org \
--to=cel@kernel.org \
--cc=kdevops@lists.linux.dev \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox