From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56C02227B94 for ; Fri, 3 Oct 2025 20:20:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759522802; cv=none; b=ukaBnYTh4r+rAOrkNyQnfLGEfMAhptWwbNANlAzn+9z8tq/eiZvJv0J522WQ4lrmB5UeZitc6dh7FjCQdc1EOlrhi60zi5G74yad+eF63DZv8bP2sQAQXJkeIiym7DBT2HEmBfY6TFywBPOQuC4Q2/jIY7WjjatAVJ7snM1xHY4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759522802; c=relaxed/simple; bh=KF6iHcTABYo1zuur7zmAgA8LSeOh+zVVuH+D6E5T/wU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H3BBLIGTmENXY63YQTKFj+GUVekA0N+rmuDMkJJZ1ZgFqX8FAq/NQHeZisleNvgP6sglm09D4J5S/+NHkP64uymrvZdHgXdEp1oE2AzRFP2xKS9fe3xvVKafYeTFl7FkeTMVbTeOgvbW4fQFj2Gggd9qrs8tm+v5jqwGnL5q+d8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mlpQk4HA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mlpQk4HA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9917CC4AF09; Fri, 3 Oct 2025 20:20:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759522801; bh=KF6iHcTABYo1zuur7zmAgA8LSeOh+zVVuH+D6E5T/wU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mlpQk4HAlNtk+fuC8UGdAYuJOl1Uh3MB6Dr5sugL5u3Sq9Qrz8VxjSlISm8CcSz0d kuhaYEED/yRWREYcahCsbzItYHfywk5gDxxUPY8j+Iff+ZrH640reL00pOK1pfy+Kj EyD+6/t6g+JDhaKEcLyUUjdYBznMIFOZgdkR5ZxMQhfGSu633NJjoG0oVRpDQGk1r5 tqm+/7pPsmPqeJoos1plRzmcBBLWaX0J/St1o6EX8U5uCRM8rRrXjw+oE0ozzJLSHJ RXp927z9hRgIuPc0WmxgDoOOonS0+/LYKtHALnPaGrD6h6lVQXM8eo1HBQn3gDzUR6 PiIZdWD3QPdUA== From: Chuck Lever To: Cc: Luis Chamberlain Subject: [PATCH v2 2/8] devconfig: exclude nfsd from journal upload client configuration Date: Fri, 3 Oct 2025 16:19:50 -0400 Message-ID: <20251003201958.24452-3-cel@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251003201958.24452-1-cel@kernel.org> References: <20251003201958.24452-1-cel@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Luis Chamberlain The NFS server (nfsd group) should not run systemd-journal-upload service as it acts as the journal remote server, not a client. The journal upload service is for clients that send logs to the remote server. Add condition to exclude 'nfsd' group members from journal upload client configuration tasks in both devconfig and fstests roles. This fixes the failure where systemd-journal-upload.service was not found on NFS server nodes, as they should only run the journal remote receiver service, not the upload client. Generated-by: Claude AI Signed-off-by: Luis Chamberlain Signed-off-by: Chuck Lever --- playbooks/roles/devconfig/tasks/main.yml | 3 +++ playbooks/roles/fstests/tasks/main.yml | 1 + 2 files changed, 4 insertions(+) diff --git a/playbooks/roles/devconfig/tasks/main.yml b/playbooks/roles/devconfig/tasks/main.yml index ae16a6982322..3499f74443ad 100644 --- a/playbooks/roles/devconfig/tasks/main.yml +++ b/playbooks/roles/devconfig/tasks/main.yml @@ -565,6 +565,7 @@ lstrip_blocks: true when: - devconfig_enable_systemd_journal_remote|bool + - "'nfsd' not in group_names" - name: Enable and restart systemd-journal-upload.service on the client tags: ["journal", "journal-upload-restart"] @@ -578,6 +579,7 @@ daemon_reload: true when: - devconfig_enable_systemd_journal_remote|bool + - "'nfsd' not in group_names" - name: Ensure systemd-journal-remote.service is running on the server tags: ["journal-status"] @@ -602,6 +604,7 @@ state: started when: - devconfig_enable_systemd_journal_remote|bool + - "'nfsd' not in group_names" - name: Set up the client /etc/systemd/timesyncd.conf tags: ["timesyncd"] diff --git a/playbooks/roles/fstests/tasks/main.yml b/playbooks/roles/fstests/tasks/main.yml index f12bfdaeba03..c3dcecf538b8 100644 --- a/playbooks/roles/fstests/tasks/main.yml +++ b/playbooks/roles/fstests/tasks/main.yml @@ -1137,6 +1137,7 @@ state: started when: - devconfig_enable_systemd_journal_remote|bool + - "'nfsd' not in group_names" - name: Hint to watchdog tests are about to kick off ansible.builtin.file: -- 2.51.0