From: Luis Chamberlain <mcgrof@kernel.org>
To: Chuck Lever <cel@kernel.org>, Daniel Gomez <da.gomez@kruces.com>,
kdevops@lists.linux.dev
Cc: Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 5/8] base_image: relax base image permissions
Date: Fri, 17 Oct 2025 19:31:50 -0700 [thread overview]
Message-ID: <20251018023154.2239688-6-mcgrof@kernel.org> (raw)
In-Reply-To: <20251018023154.2239688-1-mcgrof@kernel.org>
Base images created by virt-builder have default root:root 600
permissions which prevent the systemd services from reading them.
We want to let others and systemd services be able to read these
base images.
Generated-by: Claude AI
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
.../roles/base_image/tasks/base-image.yml | 18 ++++++++++++++++++
.../roles/base_image/tasks/custom-image.yml | 6 ++++--
2 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/playbooks/roles/base_image/tasks/base-image.yml b/playbooks/roles/base_image/tasks/base-image.yml
index d1f99a77..fc022649 100644
--- a/playbooks/roles/base_image/tasks/base-image.yml
+++ b/playbooks/roles/base_image/tasks/base-image.yml
@@ -72,6 +72,24 @@
when:
- not libvirt_uri_system|bool
+- name: Set proper ownership on base image for rcloud access (system libvirt)
+ become: true
+ become_method: ansible.builtin.sudo
+ ansible.builtin.file:
+ path: "{{ base_image_pathname }}"
+ owner: root
+ group: "{{ libvirt_qemu_group | default('libvirt-qemu') }}"
+ mode: "0640"
+ when:
+ - libvirt_uri_system|bool
+
+- name: Set proper permissions on base image (user libvirt)
+ ansible.builtin.file:
+ path: "{{ base_image_pathname }}"
+ mode: "0644"
+ when:
+ - not libvirt_uri_system|bool
+
- name: Clean up the virt-builder command file
ansible.builtin.file:
path: "{{ command_file.path }}"
diff --git a/playbooks/roles/base_image/tasks/custom-image.yml b/playbooks/roles/base_image/tasks/custom-image.yml
index 121fa112..75c48e8f 100644
--- a/playbooks/roles/base_image/tasks/custom-image.yml
+++ b/playbooks/roles/base_image/tasks/custom-image.yml
@@ -347,11 +347,13 @@
- custom_image_stat.stat.exists or custom_image_download is changed
- custom_image != base_image_pathname
-- name: Set proper permissions on base image
+- name: Set proper ownership on base image for rcloud access
become: true
become_method: ansible.builtin.sudo
ansible.builtin.file:
path: "{{ base_image_pathname }}"
- mode: "u=rw,g=r,o=r"
+ owner: root
+ group: "{{ libvirt_qemu_group | default('libvirt-qemu') }}"
+ mode: "0640"
when:
- custom_image_stat.stat.exists or custom_image_download is changed
--
2.51.0
next prev parent reply other threads:[~2025-10-18 2:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-18 2:31 [PATCH 0/8] guestfs / base_images: fixes Luis Chamberlain
2025-10-18 2:31 ` [PATCH 1/8] guestfs: Fix Debian 13 (Trixie) APT sources file path Luis Chamberlain
2025-10-18 2:31 ` [PATCH 2/8] guestfs: Don't delete APT sources copied from host Luis Chamberlain
2025-10-18 2:31 ` [PATCH 3/8] guestfs: Fix dracut-config-rescue removal for Debian systems Luis Chamberlain
2025-10-18 18:16 ` Chuck Lever
2025-10-21 16:56 ` Luis Chamberlain
2025-10-18 2:31 ` [PATCH 4/8] base_image: put a guard check before adding kdevops user Luis Chamberlain
2025-10-18 2:31 ` Luis Chamberlain [this message]
2025-10-18 2:31 ` [PATCH 6/8] guestfs: Use sudo for base image copy with system libvirt Luis Chamberlain
2025-10-18 2:31 ` [PATCH 7/8] guestfs: Fix base_image_pathname for custom images Luis Chamberlain
2025-10-18 2:31 ` [PATCH 8/8] playbooks: Fix host pattern for single-node setups Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251018023154.2239688-6-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=cel@kernel.org \
--cc=da.gomez@kruces.com \
--cc=kdevops@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox