From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C417A3644DE for ; Wed, 22 Apr 2026 22:16:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776896212; cv=none; b=OwNw61G/d9fbqSv6HVy1evXU5L5hq20JIaw8HyBNBRNUjmMEM54KUGka0NaxaeDleOe3HoIsJUlX6iURHFPUSrtyLr7xEa7bS/LBx7pT1i5fgmf1GLPYo8CY7w7MP/K6by7UJmSiXJk2SkzHB9gg18lW/ngIbNIZ4Smur7KFvDk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776896212; c=relaxed/simple; bh=LIlc3FFiLRjNe8A/QhqWZziyyuO8WQoYKVqCiQQ3zGQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Vvu3J9D+ZVTX9JOWX/ZmI7nn67j9phw7xN1JbGOdtVSPk1rSOtWgn2ibSYUYvhhEEbLjJZ5EwHxH6DkF63yzFRkv8jtdX8XtavTxrmJvoi0nl0tCiagciStVRx37Wsj8rUTEZgdNwidXoJ/0GZBXxY/YOVcAWgQ0w3AvFEyMEBA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TmeI3JmL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TmeI3JmL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 356B5C2BCB3; Wed, 22 Apr 2026 22:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776896212; bh=LIlc3FFiLRjNe8A/QhqWZziyyuO8WQoYKVqCiQQ3zGQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=TmeI3JmLcvRhetuzhP0Rl1CQpq28APb8/jk8/4m6JNZZxwotWCjYiLxVFDnRWCoB5 TUs3BUkFmthFiyxWUWGj6QC/0Z3NsDDtdhp243L5RYFSVHxPuTYFsyN8rzTLDxfshy DnpFrZkJjSnFeMVYm5cH31sw/tUceAlu6Te3db2u3fXIKkM6DW7+PBP+Vbh4AL4408 +4xOPLcZrToWo17ngCU/OTEXturepJHAvMYSf9T+vaJW1qwdvMjshfnBugb3WQ2Zyn fRSOS3dYiWZGs5YVusaxlVVW3nwf4R0/OqET4l61fhOdo8LZCqMRY+iJBNs4acrIwj HHFQ+7L7Vi4Yw== From: Daniel Gomez Date: Thu, 23 Apr 2026 00:16:42 +0200 Subject: [PATCH 1/8] nixos: remove duplicate nixos_channel extra-var from Makefile Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260423-kdevops-series-a-fixes-v1-1-69a82d0e1631@samsung.com> References: <20260423-kdevops-series-a-fixes-v1-0-69a82d0e1631@samsung.com> In-Reply-To: <20260423-kdevops-series-a-fixes-v1-0-69a82d0e1631@samsung.com> To: Luis Chamberlain , Chuck Lever Cc: kdevops@lists.linux.dev, Daniel Gomez , Daniel Gomez X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776896208; l=1292; i=da.gomez@samsung.com; s=20240621; h=from:subject:message-id; bh=P8ewIGFRWeEwylQg+bXy7HdH1uCr28XmiYrx+/rS1Eg=; b=V9a/qbPLucGkI4Cj152WoyR6SWDdkJaCFtSRdLdL/P6+WimUxc8cNhXzb/W5T7CjphBaI65iO tVFsCa9AuH/CperDoRMsfh/6kXS3l7JppRMC984YKYOBAZCUr0M+qee X-Developer-Key: i=da.gomez@samsung.com; a=ed25519; pk=BqYk31UHkmv0WZShES6pIZcdmPPGay5LbzifAdZ2Ia4= From: Daniel Gomez scripts/nixos.Makefile injected nixos_channel=\$(CONFIG_NIXOS_CHANNEL) into ANSIBLE_EXTRA_ARGS, but Kconfig.nixos already declares config NIXOS_CHANNEL with "output yaml", which writes the same key and value into .extra_vars_auto.yaml on every defconfig regeneration. The Ansible extra_vars therefore contained the mapping twice, which ansible-core rightly warns about: [WARNING]: Found duplicate mapping key 'nixos_channel'. Origin: extra_vars.yaml:90:1 Drop the redundant Make assignment. The Kconfig-exported value is authoritative and already drives every consumer. Fixes: 3089c3fec57 ("nixos: add NixOS support as third bringup option with libvirt integration") Generated-by: Claude AI Signed-off-by: Daniel Gomez --- scripts/nixos.Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/nixos.Makefile b/scripts/nixos.Makefile index 1d8c4e47..d0ad0bf5 100644 --- a/scripts/nixos.Makefile +++ b/scripts/nixos.Makefile @@ -9,7 +9,6 @@ export KDEVOPS_PROVISIONED_SSH := $(KDEVOPS_PROVISIONED_SSH_DEFAULT_GUARD) NIXOS_ARGS += nixos_path='$(TOPDIR_PATH)/nixos' NIXOS_ARGS += data_home_dir=/home/kdevops -NIXOS_ARGS += nixos_channel=$(CONFIG_NIXOS_CHANNEL) NIXOS_ARGS += libvirt_provider=True -- 2.53.0