From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03DDB34752D for ; Wed, 22 Apr 2026 22:16:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776896215; cv=none; b=IAvfSiDI699h467n2/UuO0VPacZN3VFMiABhVtVUYGLha+oAHadyOAdujAo6xASdwFLfH40GB57yKmMrZEgKpyn08kgnyzRjjDzbvvJwQsmK+P7RXYH4rVxSi6U6YAfcq2ffVas70KJLdkT7/J72YWy2xyno/hHN400mNXhhZJQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776896215; c=relaxed/simple; bh=OQqCUwzCAbFwHnLedAkN56Ki25cltdK2XlZ774n8IvU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GGMM2RrpcVlNUwrrVchleppiZAC4tmcT08TLDWbL23PuIYI1fqjF0IUI2ZQzDEsVMEG89Ku3AMuhAXCIQhu13StId9/leD5mzCNSnR8AybQ7hS297YEROepAS8Xc+uKVKUcZsbNWDd5hUJURweCdIIcZ+toK6cwr9JOXbedQIa8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=m2amjDOS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="m2amjDOS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44EFFC2BCB3; Wed, 22 Apr 2026 22:16:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776896214; bh=OQqCUwzCAbFwHnLedAkN56Ki25cltdK2XlZ774n8IvU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=m2amjDOS8lKZ/yxWa6hQi0HMnQw274oTd+rb3/iCmbgJdG0IKLctV/jSDis64pYqj a++Ywz36uDmzPo5guWRZbtwtNKQ2X5BhLFMGhfFZiSphPNvndv8BQwkgjl0lkzu+S6 7kzG+PN9EyXxDChUtKm1RPGmUDbZ705gAckaCX150J14xJ58UItvcqkzlg1UDD63ot VgHcy3XHJ5r+lgqgdLeSri5HBHcPzGIuaBl8OzulldT7zds0y9/mR0EytQ0VQFAgq9 hDBNIrj3Lzbh20Xpdd9rF/vssOtRMeZmrj8ulrrHXSLen5A2jUoWPDQbeXNObooGpc Ai92uqMJSnGag== From: Daniel Gomez Date: Thu, 23 Apr 2026 00:16:43 +0200 Subject: [PATCH 2/8] nixos: do not emit comment-only recipe lines under $(Q) Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260423-kdevops-series-a-fixes-v1-2-69a82d0e1631@samsung.com> References: <20260423-kdevops-series-a-fixes-v1-0-69a82d0e1631@samsung.com> In-Reply-To: <20260423-kdevops-series-a-fixes-v1-0-69a82d0e1631@samsung.com> To: Luis Chamberlain , Chuck Lever Cc: kdevops@lists.linux.dev, Daniel Gomez , Daniel Gomez X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776896208; l=1490; i=da.gomez@samsung.com; s=20240621; h=from:subject:message-id; bh=+qg0UB1IvxWszmm5v68W+cymXMdbqYXJNKN7Em3auGQ=; b=yoNk23BXYe8EMLUhg+BaUy5sqDpI8/PPsBFBMh7XEVqP2nOJwRTP+CmpemWLV7kpA6b4ya+Ky p5fnRCwbzF5BdtllI6NdO72INLvyn6oQTEq6QriqOFtNiXJXBPGObKK X-Developer-Key: i=da.gomez@samsung.com; a=ed25519; pk=BqYk31UHkmv0WZShES6pIZcdmPPGay5LbzifAdZ2Ia4= From: Daniel Gomez Under CONFIG_KDEVOPS_MAKE_VERBOSE=y (or V=1) $(Q) expands to a prefix that ends in "&& set -x &&", so a recipe line of the form "$(Q)# comment" becomes "... && set -x && # comment"; the shell treats "#" as a comment, the trailing "&&" loses its right-hand operand, and the recipe aborts with a syntax error. Move prose to Make-level comments above the target so every recipe line is a real command that $(Q) can wrap safely in either verbosity mode. Fixes: 3089c3fec57 ("nixos: add NixOS support as third bringup option with libvirt integration") Generated-by: Claude AI Signed-off-by: Daniel Gomez --- scripts/nixos.Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/nixos.Makefile b/scripts/nixos.Makefile index d0ad0bf5..7ed49b05 100644 --- a/scripts/nixos.Makefile +++ b/scripts/nixos.Makefile @@ -44,9 +44,10 @@ libvirt_pcie_passthrough_permissions: $(Q)ansible-playbook \ playbooks/libvirt_pcie_passthrough.yml +# SSH connectivity is verified during NixOS VM provisioning: VMs get +# DHCP IPs and SSH is tested directly in the playbook. The marker +# below just records that the provisioning reached that point. $(KDEVOPS_PROVISIONED_SSH): $(KDEVOPS_HOSTS_PREFIX) - $(Q)# The SSH connectivity is verified during NixOS VM provisioning - $(Q)# VMs get DHCP IPs and SSH is tested directly in the playbook $(Q)touch $(KDEVOPS_PROVISIONED_SSH) install_nixos_deps: -- 2.53.0