From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id E036B34752D
	for <kdevops@lists.linux.dev>; Wed, 22 Apr 2026 22:16:57 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1776896218; cv=none; b=MyFk0G+VAeecph4QfMMYwynk0dHuNrFm83DcMOjmLcypQy56RxS5cvLhVrQXg0Gkek+btywd9AtqfegEs8ZDTBckRF+iYEbWDEIsiB79RamhwsFdr/UUwrjEmLEWK6gV1rS9t2yrpIc8WbgJoOpPcPil4qZ7assd3GL6dCfmbDk=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1776896218; c=relaxed/simple;
	bh=IW+R5/na+Gk2S7nHbG+x1mr0Vu7UHY7R1LARf6vAIg8=;
	h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:
	 In-Reply-To:To:Cc; b=kNLB+vklC2/xf41cc9nED88GaDh3F23N9Ynu3GxN6GILx60b6ZmnPjBbzeCeCZNyGXYUoFUXLU4aHJMoR+6XJInUFWotJhCvWYn6cDSjuZOJOdEyhZiNUYC1xmHF4tbxiUqk6hBw5Tc93EWemSSId1LDcbHG9RF4i7S+vZIMzHw=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SAEXDymn; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SAEXDymn"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 824C0C19425;
	Wed, 22 Apr 2026 22:16:55 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1776896217;
	bh=IW+R5/na+Gk2S7nHbG+x1mr0Vu7UHY7R1LARf6vAIg8=;
	h=From:Date:Subject:References:In-Reply-To:To:Cc:From;
	b=SAEXDymn3egEpKe5KnPF0ChER+mGrTjNKsHdmNOZPgMQ1WGq6AUI4E/dsR1F/J/V0
	 98YbAwUWdEYlTa2tN7PY7Dtjb3pDQnxRucbmANz1EpoAKwh7mCFum1SDFzpnXmb+zr
	 pru2JyOoRUy/e2O5TgYn14MsCHvHF3PlcoamwDRGWxyUMHgh8HJQf0Sma7s0OkoZQ5
	 zDjnqzVSUMsHGY8rztZYGYfHlbOupC6EDaWrdAPTBJAYbB1mlVlPuvKZJXkLcZ94oH
	 +9PS10SMP/w7m8EOH7AGsx5oaJAIfXeABh6TKHz0AMAFs92FyEji3Khi3GTz+ImOVL
	 BRleKgmiuXiCQ==
From: Daniel Gomez <da.gomez@kernel.org>
Date: Thu, 23 Apr 2026 00:16:44 +0200
Subject: [PATCH 3/8] nixos: drop hardcoded qxl video model from libvirt XML
Precedence: bulk
X-Mailing-List: kdevops@lists.linux.dev
List-Id: <kdevops.lists.linux.dev>
List-Subscribe: <mailto:kdevops+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:kdevops+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20260423-kdevops-series-a-fixes-v1-3-69a82d0e1631@samsung.com>
References: <20260423-kdevops-series-a-fixes-v1-0-69a82d0e1631@samsung.com>
In-Reply-To: <20260423-kdevops-series-a-fixes-v1-0-69a82d0e1631@samsung.com>
To: Luis Chamberlain <mcgrof@kernel.org>, 
 Chuck Lever <chuck.lever@oracle.com>
Cc: kdevops@lists.linux.dev, Daniel Gomez <da.gomez@kernel.org>, 
 Daniel Gomez <da.gomez@samsung.com>
X-Mailer: b4 0.15.2
X-Developer-Signature: v=1; a=ed25519-sha256; t=1776896208; l=1619;
 i=da.gomez@samsung.com; s=20240621; h=from:subject:message-id;
 bh=L2JzgLP9ZSn02bBllEw1oMcv9ceSGesMbDaovUumBwI=;
 b=IwP2HwUY0o0OcNzEiED84MW0d3liWVs/cJUqtkZ0wr+0Q6BtGs3OVPTrNB98ROCh61LLYjaOL
 J4nm1jWVKlABezVMJCEdBYsRu9H/l76IriFIfPcrxQPQ920FV/2+95l
X-Developer-Key: i=da.gomez@samsung.com; a=ed25519;
 pk=BqYk31UHkmv0WZShES6pIZcdmPPGay5LbzifAdZ2Ia4=

From: Daniel Gomez <da.gomez@samsung.com>

The NIXOS bringup template hardcoded a <video model='qxl'/> stanza,
which libvirt refuses when the host QEMU build lacks the spice/qxl
package. That package is optional on Debian server-class installs
of qemu-system-x86, so virsh define silently failed on otherwise
healthy hosts. The playbook's failed_when: false masked the error
until a later task tried to start the absent domain, producing an
opaque "Ensure VM is running" failure.

Remove the explicit <video> stanza entirely. Libvirt picks a
compatible video model automatically based on the machine type,
matching how the GUESTFS bringup operates. VNC graphics access is
unchanged.

Fixes: 3089c3fec57 ("nixos: add NixOS support as third bringup option with libvirt integration")
Generated-by: Claude AI
Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
---
 playbooks/templates/nixos/vm-libvirt.xml.j2 | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/playbooks/templates/nixos/vm-libvirt.xml.j2 b/playbooks/templates/nixos/vm-libvirt.xml.j2
index 915a6090..2ace5784 100644
--- a/playbooks/templates/nixos/vm-libvirt.xml.j2
+++ b/playbooks/templates/nixos/vm-libvirt.xml.j2
@@ -79,11 +79,6 @@
       <listen type='address' address='127.0.0.1'/>
     </graphics>
 
-    <video>
-      <model type='qxl' ram='65536' vram='65536' vgamem='16384' heads='1' primary='yes'/>
-      <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
-    </video>
-
     <memballoon model='virtio'>
       <address type='pci' domain='0x0000' bus='0x00' slot='0x06' function='0x0'/>
     </memballoon>

-- 
2.53.0