From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24F8535AC38 for ; Wed, 22 Apr 2026 22:16:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776896219; cv=none; b=D4a9T4UCHo9LNIsft/owVhLi/Euu6HKw8h7NN10JQxJ51bBTRMm4v4fvxrvk7EWk+Nj5Yk1lXOxozPHAsRbAYLarfTKEIzBWWORVDVklM3fPMmCH8zAyHa1r2b4UzP30Ckgg3LnBKRcupRYId3RffU2NP5L4IaZq4k44xwY4mEw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776896219; c=relaxed/simple; bh=+0qfefz4+Jv6KxmvLyfmXWtkNGR+pRvXO8ZHNyZfOY4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LhSSnc+6GHYAClIHOzTfZRflOliEyAykrA2s8OlYmTdEnrJNTeQ5Lj30HwxPB7QGwGtfb3AMBtSQjJkExOLPny7cVG2k9BkuzfyqcSOS8lfN2GTCjHZ2lzH85DuqUDRy2hr6CAb5J+m2kzoio/YnuU9l5KkekUnah5qBTfqjrWU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GQ/Klz4/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GQ/Klz4/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81DFDC2BCB3; Wed, 22 Apr 2026 22:16:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776896218; bh=+0qfefz4+Jv6KxmvLyfmXWtkNGR+pRvXO8ZHNyZfOY4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=GQ/Klz4/6WHJGcfpH4/ajgVGSaxqSm+hKibI9lCiwHCUzVTNsFrwaTWbDwu1/lDFa jI0Oqc1NQpVo6qVxOjFxjQgdFgYVULDX7tGzzFqt6Zr9IGEPmKcoejtPuLQoN1YjLo VuHQ5ZnMS9XOdBEjR1r0ZNkio+d29BYHPEsaTuAFtybWA3xKblIdJ/S4rAHcSTsOBm TlEZbTWt3q/fOXvGcPWBiIba31mW0WjcT5ccO2pIecp2Yp4DEtrz/MvDU7vO2U+sF4 kWrUKWEFXXsPxbJP8yR205G+/6QUhAKs5kNGFUvUAnp+EjNsITp/SkTYafMUis+uNh ih71ZHf7EzJSQ== From: Daniel Gomez Date: Thu, 23 Apr 2026 00:16:45 +0200 Subject: [PATCH 4/8] nixos: destroy the libvirt domain before cleaning up local artefacts Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260423-kdevops-series-a-fixes-v1-4-69a82d0e1631@samsung.com> References: <20260423-kdevops-series-a-fixes-v1-0-69a82d0e1631@samsung.com> In-Reply-To: <20260423-kdevops-series-a-fixes-v1-0-69a82d0e1631@samsung.com> To: Luis Chamberlain , Chuck Lever Cc: kdevops@lists.linux.dev, Daniel Gomez , Daniel Gomez X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776896208; l=1745; i=da.gomez@samsung.com; s=20240621; h=from:subject:message-id; bh=Pv2le35e2AQQKIHxObyvgD+TMQKzs1Zif9jsLAtVT5M=; b=QjX/oVQpaXsjzS+OnYVllz13MFe3zpNOk5YU6avqoZ8zZz0hnPvVBYkWyXebc96n26pP07klv /xcUSR6r3jFDg8ITy2GSQXAtuEtBbiuvk0yQgLrIjg9QaeNxDrnqyI5 X-Developer-Key: i=da.gomez@samsung.com; a=ed25519; pk=BqYk31UHkmv0WZShES6pIZcdmPPGay5LbzifAdZ2Ia4= From: Daniel Gomez The destroy play tore down the local disk image, wrapper script and symlink but never told libvirt about it, so domains brought up through the libvirt bringup path stayed defined and running after make destroy reported success. Add virsh destroy and virsh undefine under the same LIBVIRT_DEFAULT_URI the bringup play uses, both failed_when: false so a partial state across the guest inventory does not abort the rest of the teardown. Fixes: 3089c3fec57 ("nixos: add NixOS support as third bringup option with libvirt integration") Generated-by: Claude AI Signed-off-by: Daniel Gomez --- playbooks/nixos.yml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/playbooks/nixos.yml b/playbooks/nixos.yml index 26285520..d6aa2283 100644 --- a/playbooks/nixos.yml +++ b/playbooks/nixos.yml @@ -471,6 +471,20 @@ - "{{ playbook_dir }}/../extra_vars.yaml" tags: [destroy, never] tasks: + - name: Shut down VMs via libvirt + ansible.builtin.command: virsh destroy "{{ item }}" + loop: "{{ groups['all'] | reject('equalto', 'localhost') | list }}" + failed_when: false + environment: + LIBVIRT_DEFAULT_URI: "{{ libvirt_uri }}" + + - name: Remove VM definitions from libvirt + ansible.builtin.command: virsh undefine "{{ item }}" + loop: "{{ groups['all'] | reject('equalto', 'localhost') | list }}" + failed_when: false + environment: + LIBVIRT_DEFAULT_URI: "{{ libvirt_uri }}" + - name: Stop VMs using wrapper scripts ansible.builtin.command: "{{ nixos_storage_dir }}/run-{{ item }}-wrapper.sh stop" loop: "{{ groups['all'] | reject('equalto', 'localhost') | list }}" -- 2.53.0