Re: [PATCH v2 2/9] Makefile: suppress Ansible warnings during configuration generation

[Daniel Gomez <da.gomez@kernel.org>]

On 30/07/2025 08.01, Luis Chamberlain wrote:
> The initial configuration generation playbooks (ansible_cfg.yml,
> gen_hosts.yml, and gen_nodes.yml) run without a proper inventory file
> by design, as they are responsible for creating the configuration files
> that will be used by subsequent playbooks.
> 
> This causes Ansible to emit warnings about:
> - "No inventory was parsed, only implicit localhost is available"
> - "provided hosts list is empty, only localhost is available"
> 
> These warnings are harmless but create noise in the build output,
> potentially confusing users who might think something is wrong.

Agree.

> 
> Add ANSIBLE_LOCALHOST_WARNING=False and ANSIBLE_INVENTORY_UNPARSED_WARNING=False
> environment variables to these three ansible-playbook invocations to
> suppress these specific warnings. This makes the build output cleaner
> while maintaining the same functionality.
> 
> The warnings were appearing because:
> 1. ansible_cfg.yml creates the ansible.cfg file
> 2. gen_hosts.yml creates the hosts inventory file
> 3. gen_nodes.yml creates the kdevops_nodes.yaml file
> 
> All three intentionally run with "--connection=local" and minimal
> inventory since they're bootstrapping the configuration that other
> playbooks will use.
> 
> Generated-by: Claude AI
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
>  Makefile | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 37c2522b..31f544e9 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -195,7 +195,8 @@ include scripts/gen-nodes.Makefile
>  	false)
>  
>  $(ANSIBLE_CFG_FILE): .config
> -	$(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \
> +	$(Q)ANSIBLE_LOCALHOST_WARNING=False ANSIBLE_INVENTORY_UNPARSED_WARNING=False \
> +		ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \
>  		--inventory localhost, \
>  		$(KDEVOPS_PLAYBOOKS_DIR)/ansible_cfg.yml \
>  		--extra-vars=@./.extra_vars_auto.yaml
> @@ -226,13 +227,15 @@ endif
>  
>  DEFAULT_DEPS += $(ANSIBLE_INVENTORY_FILE)
>  $(ANSIBLE_INVENTORY_FILE): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_HOSTS_TEMPLATE)
> -	$(Q)ansible-playbook $(ANSIBLE_VERBOSE) \
> +	$(Q)ANSIBLE_LOCALHOST_WARNING=False ANSIBLE_INVENTORY_UNPARSED_WARNING=False \
> +		ansible-playbook $(ANSIBLE_VERBOSE) \
>  		$(KDEVOPS_PLAYBOOKS_DIR)/gen_hosts.yml \
>  		--extra-vars=@./extra_vars.yaml
>  
>  DEFAULT_DEPS += $(KDEVOPS_NODES)
>  $(KDEVOPS_NODES): .config $(ANSIBLE_CFG_FILE) $(KDEVOPS_NODES_TEMPLATE)
> -	$(Q)ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \
> +	$(Q)ANSIBLE_LOCALHOST_WARNING=False ANSIBLE_INVENTORY_UNPARSED_WARNING=False \

I think at this point we have the inventory file with all guests/hosts
and the ansible.cfg. If that is correct I think we may not need to disable
ANSIBLE_INVENTORY_UNPARSED_WARNING and ANSIBLE_LOCALHOST_WARNING here. And 
we can probably remove --connection=local and --inventory localhost, arguments.

> +		ansible-playbook $(ANSIBLE_VERBOSE) --connection=local \
>  		--inventory localhost, \
>  		$(KDEVOPS_PLAYBOOKS_DIR)/gen_nodes.yml \
>  		--extra-vars=@./extra_vars.yaml

But in general it makes sense to enable these variables only for these specific
ansible-playbook invocations. I initially thought we could inject them into
the ansible.cfg and wrap ansible-playbook with the new environment, allowing
subsequent invocations to leverage that. But we don't want the rest of the
ansible-playbook runs to suppress these warnings, in case they do exist, as that
would hide errors.

Thanks!

Reviewed-by: Daniel Gomez <da.gomez@samsung.com>