From: Daniel Gomez <da.gomez@kernel.org>
To: Chuck Lever <cel@kernel.org>
Cc: kdevops@lists.linux.dev, Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [RFC PATCH] Makefile: terraform wasn't building the kdevops_nodes file
Date: Sun, 28 Sep 2025 22:08:21 +0200 [thread overview]
Message-ID: <2edf03fe-949d-4cd0-948d-e3262705ee0b@kernel.org> (raw)
In-Reply-To: <5e9174d9-caed-4adc-824f-81ac02357cdd@kernel.org>
On 28/09/2025 21.57, Chuck Lever wrote:
> On 9/28/25 12:53 PM, Daniel Gomez wrote:
>> I think both approaches work because nodes do not seem to be requiring hosts.
>> The questions is whether we need both changes? I think we need to ensure
>> nodes are consistent with inventory changes. And they other way around in
>> case the user deletes any of the files. So, what do you think about adding
>> this on top of the above?
>
> I don't understand the Makefile well enough to have an informed opinion!
> But I can try out both alternatives this afternoon.
>
No worries. I've tried all options myself and the sequence is the only thing
that changes between them. But I think is important to include nodes into
DEFAULT_DEPS after the provision path is triggered.
So, I'd go with my last suggestion which includes all changes.
next prev parent reply other threads:[~2025-09-28 20:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-28 15:53 [RFC PATCH] Makefile: terraform wasn't building the kdevops_nodes file Chuck Lever
2025-09-28 19:53 ` Daniel Gomez
2025-09-28 19:57 ` Chuck Lever
2025-09-28 20:08 ` Daniel Gomez [this message]
2025-09-28 20:30 ` Chuck Lever
2025-09-29 19:16 ` Daniel Gomez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2edf03fe-949d-4cd0-948d-e3262705ee0b@kernel.org \
--to=da.gomez@kernel.org \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=kdevops@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox