From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CB9617B425 for ; Sun, 28 Sep 2025 20:08:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759090104; cv=none; b=Y8m0ht4cPsvkaXpWSHPZ8ScEHCjcEMUXBfbG9/wf1onHvVT6Pb6XGRiTZ8NWACnmo2MrAiSLiiiZ0WygZ/alU6enxQfjlntYAcS9qpkjSVRkVV9skjNbWHT+nKUKkxOXLlk+vqHOWZMRIVHsqil9uyhjkIdHM7s1JSUnZ8U2pAs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759090104; c=relaxed/simple; bh=NZjBIyGZ4Hg/NnsBYe1JS6YxEIYDFW1d1d9S1JZHpAU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HMhcSBYSU/zNuTKjy9k9LExSeDlQJB+1w4qUBCB51E50dBs8itNOuq3/c6etMGkzNHOONJB1cLmjt8znM2ZpqYEMFW0rQELH0/Wkonjb41Wx4Rs//ivq6NvN6pUymD3lUBHS942KC8JSoDOLDNSKiPwUd9FM3lX2N87ngHbXF7c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RdKW1r0H; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RdKW1r0H" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76BA5C4CEF0; Sun, 28 Sep 2025 20:08:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759090104; bh=NZjBIyGZ4Hg/NnsBYe1JS6YxEIYDFW1d1d9S1JZHpAU=; h=Date:Reply-To:Subject:To:Cc:References:From:In-Reply-To:From; b=RdKW1r0HqlLGbqv+9/jlWEHu51emZYci+o051e7f7csFm4E4R9+MkUGSc2Td4EnlB FppJ6KH99DjE1W64Cupu2abHC9nt3pwwmUH7gtREknb0HecMuULrI35reYzc/Q27sB d+7e6IuXOUuglwDHLguM3cpFbS0F53YxEo4JO48zSmlXZm3UTBAn8+hKL3TI2vfhpR +HKzWaOaX9IUlga/QI70TkhJfz2VE2p54xvMjI1zFlyzltOSd3WOTkcgV6tFHGnpnH Db+56zZBD9PfQmMpw3/4zUM+OS9Tb5iO4zyNKMlJAqnmyq8IT8d5KZA/wKZzcO+8BZ 2fB8lfGurgClw== Message-ID: <2edf03fe-949d-4cd0-948d-e3262705ee0b@kernel.org> Date: Sun, 28 Sep 2025 22:08:21 +0200 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Daniel Gomez Subject: Re: [RFC PATCH] Makefile: terraform wasn't building the kdevops_nodes file To: Chuck Lever Cc: kdevops@lists.linux.dev, Chuck Lever References: <20250928155341.901825-1-cel@kernel.org> <827d1b8e-d489-46a9-a49b-b3cf3a4fe097@kernel.org> <5e9174d9-caed-4adc-824f-81ac02357cdd@kernel.org> Content-Language: en-US From: Daniel Gomez Organization: kernel.org In-Reply-To: <5e9174d9-caed-4adc-824f-81ac02357cdd@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 28/09/2025 21.57, Chuck Lever wrote: > On 9/28/25 12:53 PM, Daniel Gomez wrote: >> I think both approaches work because nodes do not seem to be requiring hosts. >> The questions is whether we need both changes? I think we need to ensure >> nodes are consistent with inventory changes. And they other way around in >> case the user deletes any of the files. So, what do you think about adding >> this on top of the above? > > I don't understand the Makefile well enough to have an informed opinion! > But I can try out both alternatives this afternoon. > No worries. I've tried all options myself and the sequence is the only thing that changes between them. But I think is important to include nodes into DEFAULT_DEPS after the provision path is triggered. So, I'd go with my last suggestion which includes all changes.