From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13250502BE for ; Thu, 25 Sep 2025 14:29:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758810578; cv=none; b=ROsio4eMkKqN5LgATIoy9TZ8JIjrHhUs5EXAa4k2Rcoinj5Ox9B7LiSrR45xkffBO7RBpp9uqHuD8ku5UDd8AVzztjsf0D7NrKVtBTUuuvdkZtf1kQi5KbvO56HFC7HJU6Jkh8AyGjQd5afzByrk0DBC7ACsL8fW85+AQkUk058= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758810578; c=relaxed/simple; bh=KNbed9UQI4OE+jHQ42N+r/sYAlkmMb7Bybb37PmFSqM=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=bbTlLEA/YobZAcpQWXB23Id+TLmlsWp/Y7HK02XJwY00/Xt3p0iffuvyMl13KPd0CIelglsdGnGdksCdVwFAzo/nPgqpEDOtqYyNltVSL31U45Fbjhhpb13QlEZoDG1/zZSd3DCJKX9mp7KGzddc/oy6vuns9fJGr2L1MlDSbBQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Hp29U/ZI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Hp29U/ZI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEC01C4CEF0; Thu, 25 Sep 2025 14:29:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758810577; bh=KNbed9UQI4OE+jHQ42N+r/sYAlkmMb7Bybb37PmFSqM=; h=Date:Reply-To:Subject:To:References:From:In-Reply-To:From; b=Hp29U/ZICp0vth0MQrB51YlRohTzVl7xsiYZAkw01n+K+1xJ1RwhAD4v/GOueCIQQ 7YGLnLLGBD4VEz1HtVyJQxQfcuilqq2XMymub3NHivk3srHt0ZFtZ9kzzEamYFybip vP9V/9mTyXKhNcssPamf5Xcf0HGY9Yml5BMtA3GZedkaGPFkesZWI3dTDEiyeW+G1v xgtKl9ZaVPg4SUzL3Ui8eDBXQ/hu+EufltW8BanzyU8uccVXcsyTbb6TDQmAAAF2xn mP2PP13jW0RQ7sKpQRwK3ex2dzcXwkHJlhLwcAfzIx4fG2nxdDqb7nzUhuw5hv9TvI 5oOgpiYor/oMg== Message-ID: <36b5d7f2-2726-4a48-9ff5-bcd0b8cfddd3@kernel.org> Date: Thu, 25 Sep 2025 16:29:34 +0200 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Daniel Gomez Subject: Re: [PATCH] devconfig: add a default for kdevops_enable_terraform To: Jeff Layton , Chuck Lever , kdevops@lists.linux.dev References: <20250924194212.323964-1-jlayton@kernel.org> <1753aeff-7f06-4cf6-afe2-1d17fc08cb81@oracle.com> <59d08e3ca1161d0be7c35ab94147fb22d11f77c9.camel@kernel.org> Content-Language: en-US From: Daniel Gomez Organization: kernel.org In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 24/09/2025 22.14, Jeff Layton wrote: > On Wed, 2025-09-24 at 15:57 -0400, Chuck Lever wrote: >> On 9/24/25 12:55 PM, Jeff Layton wrote: >>> On Wed, 2025-09-24 at 15:48 -0400, Chuck Lever wrote: >>>> On 9/24/25 12:42 PM, Jeff Layton wrote: >>>>> Fixes: 7710a1e2e820 ("devconfig: Remove "dnf update" optimizations for terraform hosts") >>>>> Signed-off-by: Jeff Layton >>>>> --- >>>>> playbooks/roles/devconfig/defaults/main.yml | 1 + >>>>> 1 file changed, 1 insertion(+) >>>>> >>>>> diff --git a/playbooks/roles/devconfig/defaults/main.yml b/playbooks/roles/devconfig/defaults/main.yml >>>>> index c5c06e01b06d..b5d4724d37ef 100644 >>>>> --- a/playbooks/roles/devconfig/defaults/main.yml >>>>> +++ b/playbooks/roles/devconfig/defaults/main.yml >>>>> @@ -59,3 +59,4 @@ distro_debian_has_hop1_sources: false >>>>> unattended_upgrades_installed: false >>>>> workflow_infer_user_and_group: false >>>>> kdevops_use_declared_hosts: false >>>>> +kdevops_enable_terraform: false >>>> >>>> Yeah. "output yaml" doesn't work the way I expect. >>>> >>> >>> The way these defaults get set seems very random and fragmented to me. >>> >>> Can I take your "Yeah" as a R-b? >> >> I didn't give a full-throated R-b because I'm wondering if there's >> a better way to approach this general problem. >> > > That's the way I feel too. I don't get the logic of when to set > variables in a limited way like this and when to do it more globally. > For now, this at least gets things running again for me. > >> But OK: >> >> Reviewed-by: Chuck Lever >> > > Thanks! What are we fixing exactly? What does it mean "output yaml" doesn't work as expected? I assume Ansible complains about kdevops_enable_terraform not being defined. In that case, if we have kconfig yaml output, the devconfig playbook should parse it via .extra_vars_auto.yaml. Note that the extra_vars.yaml way with *_EXTRA_VARS should be removed at some point to make things easier. At this point we are supporting multiple ways to share variables from Kconfig -> Ansible and we don't want that. But i don't see Kconfig support for this variable... git grep -i kdevops_enable_terraform playbooks/roles/codereadyrepo/defaults/main.yml:kdevops_enable_terraform: false playbooks/roles/codereadyrepo/tasks/main.yml: - kdevops_enable_terraform playbooks/roles/codereadyrepo/tasks/main.yml: - kdevops_enable_terraform playbooks/roles/codereadyrepo/tasks/main.yml: - kdevops_enable_terraform playbooks/roles/create_data_partition/defaults/main.yml:kdevops_enable_terraform: false playbooks/roles/create_data_partition/tasks/main.yml: - kdevops_enable_terraform|bool playbooks/roles/devconfig/tasks/install-deps/redhat/main.yml: - not kdevops_enable_terraform|bool playbooks/roles/devconfig/tasks/install-deps/redhat/main.yml: - not kdevops_enable_terraform|bool playbooks/roles/gen_nodes/defaults/main.yml:kdevops_enable_terraform: false playbooks/roles/gen_tfvars/tasks/main.yml: - kdevops_enable_terraform playbooks/roles/volume_group/defaults/main.yml:kdevops_enable_terraform: false playbooks/roles/volume_group/tasks/main.yml: - kdevops_enable_terraform|bool scripts/terraform.Makefile:TERRAFORM_EXTRA_VARS += kdevops_enable_terraform='True'