Re: [PATCH v3 01/10] playbooks: fix playbook name for all hosts plays

[Daniel Gomez <da.gomez@kernel.org>]

On 17/05/2025 21.43, Chuck Lever wrote:
> On 5/16/25 8:51 AM, Daniel Gomez wrote:
>>
>>
>> On 06/05/2025 22.39, Chuck Lever wrote:
>>> On 5/5/25 5:24 PM, Daniel Gomez wrote:
>>>> From: Daniel Gomez <da.gomez@samsung.com>
>>>>
>>>> Fix name rule by naming all the playbooks that run in all hosts.
>>>>
>>>> https://ansible.readthedocs.io/projects/lint/rules/name/
>>>
>>> Nit: name[casing] states these names must begin with an upper case
>>> letter. Ditto for 02/10.
>>>
>>> Would be slightly nicer, perhaps, if these names were documentary
>>> sentences, as they are in the roles themselves.
>>
>> I'm getting a bit of “buddy” assistance on some playbooks I'm less/not
>> familiar with. Here's the first pass covering about half of them.
> 
> Some suggestions below.

Thanks!

> 
> 
>> --- a/playbooks/blktests.yml
>> +++ b/playbooks/blktests.yml
>> -- name: blktests
>> +- name: Linux kernel block layer tests (blktests)
> 
> "Configure and run the block layer testing workflow"
> 
> 
>> --- a/playbooks/bootlinux-local.yml
>> +++ b/playbooks/bootlinux-local.yml
>> -- name: bootlinux-local
>> +- name: Bootlinux (localhost only)
> 
> I have a patch or two that folds this role into bootlinux.
> Should I send it now, or wait until your clean-up is merged?
I still need to test the crash CI script and update the playbook 
description. That said, I'd go ahead and send the bootlinux cleanup 
patches now as they will also be helpful for the bisect workflow.


> 
> 
>> --- a/playbooks/bringup_guestfs.yml
>> +++ b/playbooks/bringup_guestfs.yml
>> -- name: bringup_guestfs
>> +- name: Bringup Guests (libguestfs)
> 
> "Bring up libvirt target nodes"
> 
> 
>> --- a/playbooks/build_qemu.yml
>> +++ b/playbooks/build_qemu.yml
>> -- name: build_qemu
>> +- name: Build QEMU
>> --- a/playbooks/common.yml
>> +++ b/playbooks/common.yml
>> -- name: common
>> +- name: Common (shared role)
> 
> "Common tasks"
> 
> 
>> --- a/playbooks/create_data_partition.yml
>> +++ b/playbooks/create_data_partition.yml
>> -- name: create_data_partition
>> +- name: Create Directory Data Path (e.g. /data partition)
>> --- a/playbooks/devconfig.yml
>> +++ b/playbooks/devconfig.yml
>> -- name: devconfig
>> +- name: Configure developer environment on target systems
>> --- a/playbooks/fstests.yml
>> +++ b/playbooks/fstests.yml
>> -- name: fstests
>> +- name: "Filesystem testing suite setup - (x)fstests (control node only)"
>> -- hosts: baseline:dev
>> +- name: Filesystem testing suite setup - (x)fstests
>> +  hosts: baseline:dev
>> --- a/playbooks/pynfs.yml
>> +++ b/playbooks/pynfs.yml
>> -- name: pynfs
>> +- name: Configure and run pynfs testing workflow
>> --- a/playbooks/reboot-limit.yml
>> +++ b/playbooks/reboot-limit.yml
>> -- name: reboot-limit
>> +- name: reboot-limit stability test workflow
> 
> "Configure and run the reboot-limit workflow"
> 
> 
>> --- a/playbooks/rxe.yml
>> +++ b/playbooks/rxe.yml
>> -- name: rxe
>> +- name: Set up software-emulated RoCE RDMA over Ethernet (rxe) via udev
>> --- a/playbooks/selftests.yml
>> +++ b/playbooks/selftests.yml
>> -- name: selftests
>> +- name: Set up and run Linux kernel selftests (kselftests)
>> --- a/playbooks/siw.yml
>> +++ b/playbooks/siw.yml
>> -- name: siw
>> +- name: Set up software-emulated iWARP RDMA over TCP/IP (siw) via udev
>> --- a/playbooks/smbd.yml
>> +++ b/playbooks/smbd.yml
>> -- name: smbd
>> +- name: Set up Samba server with shared volume and system integration
>> --- a/playbooks/sysbench.yml
>> +++ b/playbooks/sysbench.yml
>> -- name: sysbench
>> +- name: Sysbench workflow
> 
> "Configure and run the sysbench workflow"
> 
> 
>> --- a/playbooks/terraform.yml
>> +++ b/playbooks/terraform.yml
>> -- name: terraform
>> +- name: Manage infrastructure lifecycle and SSH access with Terraform
>> --- a/playbooks/update_etc_hosts.yml
>> +++ b/playbooks/update_etc_hosts.yml
>> -- name: update_etc_hosts
>> +- name: Update target /etc/hosts with all targets and disable cloud-init
>> --- a/playbooks/update_ssh_config_guestfs.yml
>> +++ b/playbooks/update_ssh_config_guestfs.yml
>> -- name: update_ssh_config_guestfs
>> +- name: Update OpenSSH client configuration file (libguestfs)
>>
>>
> 
>