Re: [RFT] scripts: add fix_ansible_lint.py

[Daniel Gomez <da.gomez@kernel.org>]

On 23/08/2025 03.29, Luis Chamberlain wrote:
> Add a script which fixes all fatal ansible-lint errors.
> 
> Usage examples:
> python3 scripts/fix_ansible_lint.py --changes-only
> 
> python3 scripts/fix_ansible_lint.py
> 
> python3 scripts/fix_ansible_lint.py playbooks/foo.yml playbooks/bar*.yml
> 
> python3 scripts/fix_ansible_lint.py --dry-run
> 
> python3 scripts/fix_ansible_lint.py --changes-only --check
> 
> This tool goes beyond ansible-lint --fix by handling more issue types
> and providing better control over what gets fixed.
> 
> Generated-by: Claude AI
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>

This is great!

I think we just need to be able to apply recursively and one rule at a time.

And it would be great to have these 2 combined:
https://github.com/dkruces/kdevops/blob/ansible-lint-wrapper/scripts/ansible-lint-fix-rules.py

The ansible-lint-fix-rules is just an ansible-lint --fix=<rule_id> wrapper. It
creates a commit based on a template with the appropriate Generated by: tag and
rule applied. I adapt the template last minute before pushing the linter fixes
as it was too verbose. Adapting that would be great too.

I think we can add these features to the fix_ansible_lint.py script. BTW, I
really like the option to apply it only to the last commit's lines. I tried
implementing it myself but had some trouble. Thanks!

...

Here's the combination of both scripts, and the missing linter fixes:
https://github.com/linux-kdevops/kdevops/tree/dagomez/more-ansible-lint-fixes

I did not manage to split the manual rules in smaller sub-groups/rules. That's
the last piece missing, I think. I've sent this branch to the CI for testing.

Here the entire claude development branch:
https://github.com/dkruces/kdevops/commits/ansible-lint-comprehensive-fixer/