Re: [PATCH v2 24/37] base_image: Skip "locales-all" package on Fedora

[Daniel Gomez <da.gomez@kernel.org>]

On 02/09/2025 15.54, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
> 
> Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>  playbooks/roles/base_image/templates/virt-builder.j2 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/playbooks/roles/base_image/templates/virt-builder.j2 b/playbooks/roles/base_image/templates/virt-builder.j2
> index 7df4229405e7..138d06eede6b 100644
> --- a/playbooks/roles/base_image/templates/virt-builder.j2
> +++ b/playbooks/roles/base_image/templates/virt-builder.j2
> @@ -11,7 +11,7 @@ mkdir {{ target_dir }}
>  copy-in {{ guestfs_distro_source_and_dest_file }}:{{ target_dir }}
>  {% endif %}
>  
> -install sudo,qemu-guest-agent,python3,bash,locales-all
> +install sudo,qemu-guest-agent,python3,bash

I think this also applies to Debian, not Fedora only.

The reason was added was to fix a local warning when ssh into a Debian guest.

Let me check if this is still needed.

>  run-command useradd {{ kdevops_uid }} -s /bin/bash -m kdevops
>  append-line /etc/sudoers.d/kdevops:kdevops   ALL=(ALL)       NOPASSWD: ALL
>  edit /etc/default/grub:s/^GRUB_CMDLINE_LINUX_DEFAULT=.*/GRUB_CMDLINE_LINUX_DEFAULT="console=ttyS0"/