From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 839A134A302 for ; Tue, 2 Sep 2025 19:57:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756843077; cv=none; b=KJsYh3VS/KVhe7mFkwSS+5N/OA3nC5kB3SW5/leNxT4E6Iw512YHSrvEaR9WracEG9AJmjnmBcHVCNtK6WGGNN0/KTvz/YQQEJ9FAhiulqrWuHUl3zwkzouXE5Xs9px12mZjKNxR8OHojjwwNv7RNUHbr1j6e/DqGmwN/qacrkU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756843077; c=relaxed/simple; bh=sG1fMgok8UEg+g57kjltbIR7ZOjN7WaK8seOaEuk7tk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=E9JHMEfi6SK9zBmqycxRXVd3cAmnLbFQWCSaD/cTZ5LDHW/QFTbfX+cqTPOzf2INt90iCq2rLAbrTndEPAq/WfoR7btMW0gK4jxDmNpwhenRbFZdt+GBFHNEBvtlc02rSc+JA/2theO7zSr8rThh/fe82HbraxMFQlZ7GHx3y9c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XDrtvzkL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XDrtvzkL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 395C1C4CEED; Tue, 2 Sep 2025 19:57:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756843077; bh=sG1fMgok8UEg+g57kjltbIR7ZOjN7WaK8seOaEuk7tk=; h=Date:Reply-To:Subject:To:Cc:References:From:In-Reply-To:From; b=XDrtvzkLfpOlXY7IGK+vPdwJmf5xZjaa2y6ZeXw6z83HoA/hQ+qRGJoClDuAI/sSW pk7KeZfdboDLI9PT52JztRxJki+AJ7E86mtWclyfUxSUzv9N6gCa34csiCWs5RlLil faQDDOVNW90hL7f+0zy9Gm/3+nl1K+2aQ8OFYRKOS0Dk5FzE2SuGQlX4TJTJRMbnpd xAvOf4hUBKDD5kEihtRjaXc7ZrYnhJQW3LiyCuAIcIMITOaNrTfTG5vVqAWMRrGWzH yCWLSVeoSPItaNA3srdR8CjNi4/wQGo4MH8X0d3t3uTFYTnE9Ir2FCW1EcFffbWDTS GXGzHM6VaOp5A== Message-ID: <437bc430-c04f-4e12-86e7-029baf0a6422@kernel.org> Date: Tue, 2 Sep 2025 21:57:54 +0200 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Daniel Gomez Subject: Re: [PATCH v2 24/37] base_image: Skip "locales-all" package on Fedora To: Chuck Lever , kdevops@lists.linux.dev Cc: Chuck Lever , Luis Chamberlain References: <20250902135426.815079-1-cel@kernel.org> <20250902135426.815079-25-cel@kernel.org> Content-Language: en-US From: Daniel Gomez Organization: kernel.org In-Reply-To: <20250902135426.815079-25-cel@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 02/09/2025 15.54, Chuck Lever wrote: > From: Chuck Lever > > Reviewed-by: Luis Chamberlain > Signed-off-by: Chuck Lever > --- > playbooks/roles/base_image/templates/virt-builder.j2 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/playbooks/roles/base_image/templates/virt-builder.j2 b/playbooks/roles/base_image/templates/virt-builder.j2 > index 7df4229405e7..138d06eede6b 100644 > --- a/playbooks/roles/base_image/templates/virt-builder.j2 > +++ b/playbooks/roles/base_image/templates/virt-builder.j2 > @@ -11,7 +11,7 @@ mkdir {{ target_dir }} > copy-in {{ guestfs_distro_source_and_dest_file }}:{{ target_dir }} > {% endif %} > > -install sudo,qemu-guest-agent,python3,bash,locales-all > +install sudo,qemu-guest-agent,python3,bash I think this also applies to Debian, not Fedora only. The reason was added was to fix a local warning when ssh into a Debian guest. Let me check if this is still needed. > run-command useradd {{ kdevops_uid }} -s /bin/bash -m kdevops > append-line /etc/sudoers.d/kdevops:kdevops ALL=(ALL) NOPASSWD: ALL > edit /etc/default/grub:s/^GRUB_CMDLINE_LINUX_DEFAULT=.*/GRUB_CMDLINE_LINUX_DEFAULT="console=ttyS0"/