From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14FF61C1F13 for ; Thu, 2 Oct 2025 20:38:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759437533; cv=none; b=msFaV/FGLOl4ykwaUKMj1MKpBHhxDzudvdSTI70rtaKgwj5+U5p0W2oeq83beLkhghlQUDzGCWHjL5Im0aTeltCB5Jw36uYhG3iWJik+z/HAhXI4FrWn/M8cwpakrF787O9rb3MXSkKcpQvED0zJbg+fFmuOzR/cYppTdkLC9/Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759437533; c=relaxed/simple; bh=No/4Oh6IhcmKt+hKtIr26N2ACigP7JklD/AXjU3dahk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OrTUNQmCluZdtdjvsWOZmdqrsGbWgDE0qilSu+k2Z0qp7pysHVC6LoJIu9s0hp42r2WpXmcoDCgc4EVJmjdGZKrEvhrh+gY359ZbEBcOX2yTvaQ0Rn8APIgIYlnXuzHYc265nfmdgo9m96P+hlBZrbR0KzwMAW/OZh7U11EWd3s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SZj+5D+7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SZj+5D+7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00D4DC4CEF4; Thu, 2 Oct 2025 20:38:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759437532; bh=No/4Oh6IhcmKt+hKtIr26N2ACigP7JklD/AXjU3dahk=; h=Date:Reply-To:Subject:To:Cc:References:From:In-Reply-To:From; b=SZj+5D+7VPY1EfL5a9+W4VEmfdYVuW2tSGV7pUzN+1p3ZTNpwKhFBYaYV6Ig8ZIDt fviIBUKHR5zKpnggzIIZXEYmlGthFWEg3vUz9+FQ7Dg6dCDODbrIdSMdZjC/AhPyr3 MZonbpSmMgcF06yVRdYXx87G14tbTCc/7ZHl1KpiVEbm4YMvgJJ9EJ0yBH+4n0PZCH EJDWa7piK6h2dNElY7lXX/XtATDK3NoMHduKnrRcwDJi7JIGZ810Cuj4e7r6yo9SG4 42ab3sUuOt/WvZwlKc2HAZz52A5V7jwz94O7aehnd4G6YDbBIilLTRCFLEpnZLsyEH fcFmV4I+A2S5g== Message-ID: <485cd40b-981e-4032-bac2-471a86ba4927@kernel.org> Date: Thu, 2 Oct 2025 22:38:48 +0200 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Daniel Gomez Subject: Re: [PATCH] Makefile: terraform wasn't building the kdevops_nodes file To: Chuck Lever Cc: kdevops@lists.linux.dev References: <20251002201338.3592784-1-cel@kernel.org> Content-Language: en-US From: Daniel Gomez Organization: kernel.org In-Reply-To: <20251002201338.3592784-1-cel@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 02/10/2025 22.13, Chuck Lever wrote: > From: Daniel Gomez > > When "make bringup" runs "terraform plan", it complains that the > kdevops_nodes variable isn't set. > > extra_vars.yaml does contain the variable, but I'm guessing that > somehow gen_nodes runs after gen_tfvars now? Not really sure. > > Daniel suggests: >> I think it'd be best to move KDEVOPS_NODES just after we assign >> the filename to it (provision.Makefile -> guestfs.Makefile): > > Fixes: 5457b742d611 ("Makefile: fix target dependency order") > Signed-off-by: Daniel Gomez > --- > Makefile | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > Daniel, I've totally lost the plot. Is this patch adequate for fixing > the "terraform plan" failures, or do you have something else in mind? Yes, that is correct becuase we want/need to fill DEFAULT_DEPS after KDEVOPS_NODES is generated. And sorry if I made it so confusing!