From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7626721ADA9 for ; Mon, 19 May 2025 18:55:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747680932; cv=none; b=LbbWn5oHpIcNkETRDed4yD7k2i9rXiPTQovTBrBPZHqPXIajRzI0N68LD0Z1RTYPuQ/sLztgaL7BqWXjyQAyCpjABmMpfoBj9SCPAAak7tEyeIf9rcRU9cDsTp9TpWzE+EO5XjyQMkBKyaRymmatncrXiX6yZsXMQCNm4SxwkBQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747680932; c=relaxed/simple; bh=xJG0gBgKS2Y0CERRl01tTbRLpx0hdO2QA+35ewqXrOU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jhVAjz/aasf1e2WTRB9fZBn72vQ6rXeHd/rLR2KxD3HsLTShlut+f4voDmunqF4Rw8EwmId5zcsKFhqgetwRfogYyLcHkQl88LWhurAh7YkJg1v0gUYsy2ILoA+gWTYPioS/AM3qi7k8u1gKocD/dAwSKL6Ka1r3XTy3tlTdC7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NCAApoIE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NCAApoIE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4ACA7C4CEF1; Mon, 19 May 2025 18:55:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747680930; bh=xJG0gBgKS2Y0CERRl01tTbRLpx0hdO2QA+35ewqXrOU=; h=Date:Reply-To:Subject:To:Cc:References:From:In-Reply-To:From; b=NCAApoIEzd/RahFvgoQKWIzasoD5xBauddPWqMHSfMy8dxNytWt4DC2SkNfGuvL8Y WSxQUjt+ouDJqi+i2zM/UdOkZzEbdHbed0YYTvrhNwtiqvA5FbQNjRIosI5eCfa5Qo PhwajxQ3eAgIyYr1wZYeCx9KkUOU52yLtrtxzpmiHRHof/cXDX5IlLJ4vL5WpRLwd1 ujFvfImZt4qrRvr/q0JjCUX4oAhGyzYSILAY/1ORu2OLUcLYhuxzELyFN21oKwjBk4 PHKR45gCjr/pJ29zLMpEoAuDjBeS2fRWJI4Pxvu3v9x3KVmCRJdmTlZnxa1pO780R5 km+hq0AWgYFHA== Message-ID: <49a696f8-3909-4cc5-81d5-7b3291090b1a@kernel.org> Date: Mon, 19 May 2025 20:55:28 +0200 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: da.gomez@kernel.org Subject: Re: file (/root/.ssh/config) is absent, cannot continue To: Chuck Lever Cc: "kdevops@lists.linux.dev" References: Content-Language: en-US From: Daniel Gomez Organization: kernel.org In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 19/05/2025 20.34, Chuck Lever wrote: > I updated to the tip of the kdevops branch just now, and > update_ssh_config_guestfs is suddenly failing: > > > task path: > /home/cel/src/kdevops/buildbot-configs/playbooks/roles/update_ssh_config_guestfs/tasks/main.yml:73 > fatal: [localhost]: FAILED! => { > "changed": false, > "path": "/root/.ssh/config", > "state": "absent" > } > > MSG: > > file (/root/.ssh/config) is absent, cannot continue Looks weird it's trying to access the ./ssh/config for root instead of cel. Line 73 points to: - name: Ensure ~/.ssh/config permissions become: true become_flags: 'su - -c' become_method: ansible.builtin.sudo ansible.builtin.file: path: ~/.ssh/config mode: "0600" which I think is missing: when: ssh_config.stat.exists Added by the change f301c9a ("guestfs: ensure right permissions for ssh config"). I don't think we need to use sudo in that task either: become_flags: 'su - -c' become_method: ansible.builtin.sudo Can you try adding the when conditional and sudo? > > > Could be commit 5095f06310c0 ("update_ssh_config_guestfs: fix broken > conditionals") -- I reverted that commit and the issue goes away. > This commit just adds | bool to the conditions. That might have been silently masking the issue.