file (/root/.ssh/config) is absent, cannot continue

file (/root/.ssh/config) is absent, cannot continue

[Chuck Lever]

I updated to the tip of the kdevops branch just now, and
update_ssh_config_guestfs is suddenly failing:


task path:
/home/cel/src/kdevops/buildbot-configs/playbooks/roles/update_ssh_config_guestfs/tasks/main.yml:73
fatal: [localhost]: FAILED! => {
    "changed": false,
    "path": "/root/.ssh/config",
    "state": "absent"
}

MSG:

file (/root/.ssh/config) is absent, cannot continue


Could be commit 5095f06310c0 ("update_ssh_config_guestfs: fix broken
conditionals") -- I reverted that commit and the issue goes away.

-- 
Chuck Lever

Re: file (/root/.ssh/config) is absent, cannot continue

[Daniel Gomez]

On 19/05/2025 20.34, Chuck Lever wrote:
> I updated to the tip of the kdevops branch just now, and
> update_ssh_config_guestfs is suddenly failing:
> 
> 
> task path:
> /home/cel/src/kdevops/buildbot-configs/playbooks/roles/update_ssh_config_guestfs/tasks/main.yml:73
> fatal: [localhost]: FAILED! => {
>      "changed": false,
>      "path": "/root/.ssh/config",
>      "state": "absent"
> }
> 
> MSG:
> 
> file (/root/.ssh/config) is absent, cannot continue

Looks weird it's trying to access the ./ssh/config for root instead of cel.

Line 73 points to:

- name: Ensure ~/.ssh/config permissions
   become: true
   become_flags: 'su - -c'
   become_method: ansible.builtin.sudo
   ansible.builtin.file:
     path: ~/.ssh/config
     mode: "0600"

which I think is missing:

   when: ssh_config.stat.exists

Added by the change f301c9a ("guestfs: ensure right permissions for ssh 
config").

I don't think we need to use sudo in that task either:

   become_flags: 'su - -c'
   become_method: ansible.builtin.sudo


Can you try adding the when conditional and sudo?

> 
> 
> Could be commit 5095f06310c0 ("update_ssh_config_guestfs: fix broken
> conditionals") -- I reverted that commit and the issue goes away.
> 
This commit just adds | bool to the conditions. That might have been 
silently masking the issue.

Re: file (/root/.ssh/config) is absent, cannot continue

[Chuck Lever]

On 5/19/25 2:55 PM, Daniel Gomez wrote:
> 
> 
> On 19/05/2025 20.34, Chuck Lever wrote:
>> I updated to the tip of the kdevops branch just now, and
>> update_ssh_config_guestfs is suddenly failing:
>>
>>
>> task path:
>> /home/cel/src/kdevops/buildbot-configs/playbooks/roles/
>> update_ssh_config_guestfs/tasks/main.yml:73
>> fatal: [localhost]: FAILED! => {
>>      "changed": false,
>>      "path": "/root/.ssh/config",
>>      "state": "absent"
>> }
>>
>> MSG:
>>
>> file (/root/.ssh/config) is absent, cannot continue
> 
> Looks weird it's trying to access the ./ssh/config for root instead of cel.

The pathname should be KDEVOPS_SSH_CONFIG, but that needs to be
fixed throughout update_ssh_config_guestfs.yml.


> Line 73 points to:
> 
> - name: Ensure ~/.ssh/config permissions
>   become: true
>   become_flags: 'su - -c'
>   become_method: ansible.builtin.sudo
>   ansible.builtin.file:
>     path: ~/.ssh/config
>     mode: "0600"
> 
> which I think is missing:
> 
>   when: ssh_config.stat.exists
> 
> Added by the change f301c9a ("guestfs: ensure right permissions for ssh
> config").
> 
> I don't think we need to use sudo in that task either:
> 
>   become_flags: 'su - -c'
>   become_method: ansible.builtin.sudo
> 
> 
> Can you try adding the when conditional and sudo?

I tested:

diff --git a/playbooks/roles/update_ssh_config_guestfs/tasks/main.yml
b/playbooks/roles/update_ssh_config_guestfs/tasks/main.yml
index 6c6c49034d8a..ee144b3f4796 100644
--- a/playbooks/roles/update_ssh_config_guestfs/tasks/main.yml
+++ b/playbooks/roles/update_ssh_config_guestfs/tasks/main.yml
@@ -71,9 +71,7 @@
       Include ~/.ssh/config_kdevops_*

 - name: Ensure ~/.ssh/config permissions
-  become: true
-  become_flags: 'su - -c'
-  become_method: ansible.builtin.sudo
   ansible.builtin.file:
     path: ~/.ssh/config
     mode: "0600"
+    when: ssh_config.stat.exists

I'm not able to reproduce the issue.


>> Could be commit 5095f06310c0 ("update_ssh_config_guestfs: fix broken
>> conditionals") -- I reverted that commit and the issue goes away.
>>
> This commit just adds | bool to the conditions. That might have been
> silently masking the issue.
> 


-- 
Chuck Lever