Re: [PATCH v5 07/12] gen_hosts: add service group to inventory templates

[Daniel Gomez <da.gomez@kernel.org>]

On 24/07/2025 22.02, Chuck Lever wrote:
> On 7/24/25 3:36 PM, Daniel Gomez wrote:
>> From: Daniel Gomez <da.gomez@samsung.com>
>>
>> Introduce a new 'service' group in all inventory templates that includes
>> service hosts (iscsi, nfsd, smbd, kdc). This provides a convenient way
>> to target all service hosts collectively for operations like guestfs
>> bringup and SSH configuration.
>>
>> The service group includes:
>> - iscsi hosts (when kdevops_enable_iscsi is enabled)
>> - nfsd hosts (when kdevops_nfsd_enable is enabled)
>> - smbd hosts (when kdevops_smbd_enable is enabled)
>> - kdc hosts (when kdevops_krb5_enable is enabled)
>>
>> This addresses issues where operations limited to 'baseline:dev' would
>> miss required service hosts, causing workflow failures.
>>
>> Generated-by: Claude AI
>>
>> Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
>> ---
>>  playbooks/roles/gen_hosts/templates/fstests.j2 | 15 +++++++++++++++
>>  playbooks/roles/gen_hosts/templates/gitr.j2    |  9 +++++++++
>>  playbooks/roles/gen_hosts/templates/hosts.j2   |  9 +++++++++
>>  playbooks/roles/gen_hosts/templates/nfstest.j2 |  9 +++++++++
>>  playbooks/roles/gen_hosts/templates/pynfs.j2   |  7 +++++++
>>  5 files changed, 49 insertions(+)
>>
>> diff --git a/playbooks/roles/gen_hosts/templates/fstests.j2 b/playbooks/roles/gen_hosts/templates/fstests.j2
>> index abcdafd..a489c12 100644
>> --- a/playbooks/roles/gen_hosts/templates/fstests.j2
>> +++ b/playbooks/roles/gen_hosts/templates/fstests.j2
>> @@ -69,3 +69,18 @@ ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
>>  [krb5:vars]
>>  ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
>>  {% endif %}
>> +[service]
>> +{% if kdevops_enable_iscsi %}
>> +{{ kdevops_hosts_prefix }}-iscsi
>> +{% endif %}
>> +{% if kdevops_nfsd_enable %}
>> +{{ kdevops_hosts_prefix }}-nfsd
>> +{% endif %}
>> +{% if kdevops_smbd_enable %}
>> +{{ kdevops_hosts_prefix }}-smbd
>> +{% endif %}
>> +{% if kdevops_krb5_enable %}
>> +{{ kdevops_hosts_prefix }}-kdc
>> +{% endif %}
>> +[service:vars]
>> +ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
>> diff --git a/playbooks/roles/gen_hosts/templates/gitr.j2 b/playbooks/roles/gen_hosts/templates/gitr.j2
>> index b8f393d..41aee2b 100644
>> --- a/playbooks/roles/gen_hosts/templates/gitr.j2
>> +++ b/playbooks/roles/gen_hosts/templates/gitr.j2
>> @@ -37,3 +37,12 @@ ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
>>  [nfsd:vars]
>>  ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
>>  {% endif %}
>> +[service]
>> +{% if kdevops_enable_iscsi %}
>> +{{ kdevops_hosts_prefix }}-iscsi
>> +{% endif %}
>> +{% if kdevops_nfsd_enable %}
>> +{{ kdevops_hosts_prefix }}-nfsd
>> +{% endif %}
>> +[service:vars]
>> +ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
>> diff --git a/playbooks/roles/gen_hosts/templates/hosts.j2 b/playbooks/roles/gen_hosts/templates/hosts.j2
>> index 5032f59..639f5a4 100644
>> --- a/playbooks/roles/gen_hosts/templates/hosts.j2
>> +++ b/playbooks/roles/gen_hosts/templates/hosts.j2
>> @@ -44,4 +44,13 @@ ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
>>  [nfsd:vars]
>>  ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
>>  {% endif %}
>> +[service]
>> +{% if kdevops_enable_iscsi %}
>> +{{ kdevops_hosts_prefix }}-iscsi
>> +{% endif %}
>> +{% if kdevops_nfsd_enable %}
>> +{{ kdevops_hosts_prefix }}-nfsd
>> +{% endif %}
>> +[service:vars]
>> +ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
>>  {% endif %}
>> diff --git a/playbooks/roles/gen_hosts/templates/nfstest.j2 b/playbooks/roles/gen_hosts/templates/nfstest.j2
>> index 6a0d6cd..fb47471 100644
>> --- a/playbooks/roles/gen_hosts/templates/nfstest.j2
>> +++ b/playbooks/roles/gen_hosts/templates/nfstest.j2
>> @@ -37,3 +37,12 @@ ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
>>  [nfsd:vars]
>>  ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
>>  {% endif %}
>> +[service]
>> +{% if kdevops_enable_iscsi %}
>> +{{ kdevops_hosts_prefix }}-iscsi
>> +{% endif %}
>> +{% if kdevops_nfsd_enable %}
>> +{{ kdevops_hosts_prefix }}-nfsd
>> +{% endif %}
>> +[service:vars]
>> +ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
>> diff --git a/playbooks/roles/gen_hosts/templates/pynfs.j2 b/playbooks/roles/gen_hosts/templates/pynfs.j2
>> index c018c54..cac6fc6 100644
>> --- a/playbooks/roles/gen_hosts/templates/pynfs.j2
>> +++ b/playbooks/roles/gen_hosts/templates/pynfs.j2
>> @@ -22,3 +22,10 @@ ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
>>  {{ kdevops_hosts_prefix }}-nfsd
>>  [nfsd:vars]
>>  ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
>> +[service]
>> +{% if kdevops_enable_iscsi %}
>> +{{ kdevops_hosts_prefix }}-iscsi
>> +{% endif %}
>> +{{ kdevops_hosts_prefix }}-nfsd
>> +[service:vars]
>> +ansible_python_interpreter =  "{{ kdevops_python_interpreter }}"
>>
> 
> The issue with the pynfs workflow is that the "nfsd" host is also where
> the tests run. I think what you're doing is adding that host into both
> the test-runners group and the new "service" group, which is probably
> OK.

That is correct.

> 
> Would it be better if the pynfs workflow created a separate test runner
> and nfsd host? Or even two test runners, one for NFSv4.0 and one for
> NFSv4.1 ? That way the pynfs workflow would operate like the others.

You mean like in fstests, right?
FSTESTS_NFS_SECTION_V42
FSTESTS_NFS_SECTION_V41
FSTESTS_NFS_SECTION_V40

I agree pynfs is not consistent with the rest of the workflows. But I'm not
familiar with pynfs to agree if your suggestion make sense. Can you clarify if
your suggestion means having 2 kdevops profiles (i.e. 2 separate guests/vms)
with NFSv4.0 and NFS4.1 with both the option to run CONFIG_PYNFS_PNFS_BLOCK
or not. How is it done now? Does the test switch between NFS versions or uses
2 different NFS mount points to run the pynfs suite tests on them? Would nfsd
guest support both new vms?

> 
> Just a random thought, not an objection.

Would you agree to do this separately?