From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAE952FD1AD for ; Fri, 17 Oct 2025 23:06:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760742415; cv=none; b=Qr+Y9ECFY+uzk1A6u91HDluQzQiaXS3cTGwhGjhGvt5YdjV85eLO+foj6wtClGJJczKzRR3+/t+n3DLQbOpOesmZjbsAJN7v7Mvd6FvR9VTVVysXN3Ca286ym0BvBQtmT0oDPB1ymdyAP4YOD7hNJ9boStZu9tI3BXqiBoWXXX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760742415; c=relaxed/simple; bh=T7RpKUzJQwDlGR86hUqu55Q9BYJDLgEeX+d+OYB93ds=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=kUqUlvuYPDHpXy9U5o/3CZXNJ681Cgb0qh47iJGXb1HPx0O+AZZ1VauahumM9OokglfTcmhdjwlqK7jfPza/VC8LqpqTnCmqVzUGXPL4gd2Q1OItx2lQCCtF1JoVljngVaZ5CaiDKBpKE/1BtfX6lrzl7LphSM2tkltUCvxu4kY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SlaeqEbG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SlaeqEbG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9726BC4CEE7; Fri, 17 Oct 2025 23:06:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760742414; bh=T7RpKUzJQwDlGR86hUqu55Q9BYJDLgEeX+d+OYB93ds=; h=Date:Reply-To:Subject:From:To:Cc:References:In-Reply-To:From; b=SlaeqEbGKkGAbbog6m1czYGIflz4QhcZadU41GHkSCK/eCxhXeq7XlYYHFVuyaFct AnIp14IgkUnWh1x0MnrLcPc1JAmo2Ms8D12775Hhy88gofY2wUKvOmiMXeeOtXcm6V +yBrk/1ZUnOiF3r5gTAvMZhnLiTFq/powYU7mZUZ7mJS+w8/JwSdRe0hqSGtAqPSzS YoUcm/jr5lA8PHgHHKpiVTKalxtzgNp7z255h+LQUUXpr6NeMHCNgGwmyAqJH82+Qa dBLWNvi6mLyDoMl9moq6PVAClOEtaABNZ8DGg1SPWDHl/x7ePlmxdwDep1MJCWkr5t vTkE7pZIj1PJA== Message-ID: <59b3dd1e-da72-45b2-93ff-79c79e9c7e33@kernel.org> Date: Sat, 18 Oct 2025 01:06:48 +0200 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Daniel Gomez Subject: Re: [PATCH 0/2] Locales fixes From: Daniel Gomez To: Chuck Lever , Daniel Gomez Cc: kdevops@lists.linux.dev, Luis Chamberlain References: <20250929-locales-all-removal-v1-0-4177411d3e44@samsung.com> <176046492150.25480.9143422994519608848.b4-ty@samsung.com> <38357052-2ee3-4940-a747-76ec3266dbf5@oracle.com> <4c7ff2e5-eba8-4b0f-8314-96c3f6f9d588@oracle.com> <410fd616-811d-423c-b2ed-25f86d851b51@oracle.com> Content-Language: en-US Organization: kernel.org In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 18/10/2025 00.53, Daniel Gomez wrote: > > > On 17/10/2025 23.59, Chuck Lever wrote: >> On 10/16/25 2:56 PM, Chuck Lever wrote: >>> On 10/15/25 5:17 PM, Chuck Lever wrote: >>>>> Note, I can't fully test this or the patch, as it appears to be broken (at least >>>>> for me) when using a Debian host and a Fedora guest with kdevops/libguestfs: >>>>> >>>>> virt-builder fedora-41 --arch x86_64 -o /xfs1/libvirt/images/kdevops/guestfs/base_images/fedora-41.raw --size 20G --format raw --commands-from-file /tmp/ansible.8r5zc3so >>>>> [ 3.7] Downloading: http://builder.libguestfs.org/fedora-41.xz >>>>> ###################################################################################################################################################################################################### 100.0% >>>>> [ 140.6] Planning how to build this image >>>>> [ 140.6] Uncompressing >>>>> [ 141.7] Resizing (using virt-resize) to expand the disk to 20.0G >>>>> [ 171.5] Opening the new disk >>>>> [ 181.7] Setting a random seed >>>>> [ 181.7] Installing packages: sudo qemu-guest-agent python3 bash policycoreutils-python-utils >>>>> [ 194.7] Uninstalling packages: dracut-config-rescue >>>>> [ 195.0] Deleting: /boot/*rescue* >>>>> [ 195.0] Deleting: /boot/loader/entries/*rescue* >>>>> [ 195.0] Running: useradd -u 1012 -s /bin/bash -m kdevops >>>>> [ 195.1] Appending line to /etc/sudoers.d/kdevops >>>>> [ 195.1] Editing: /etc/default/grub >>>>> [ 195.2] Running: /usr/sbin/grub2-mkconfig -o /boot/grub2/grub.cfg >>>>> [ 195.9] Installing packages: isc-dhcp-client ifupdown >>>>> Updating and loading repositories: >>>>> Fedora 41 - x86_64 100% | 221.4 KiB/s | 30.3 KiB | 00m00s >>>>> Fedora 41 - x86_64 - Updates 100% | 289.6 KiB/s | 29.0 KiB | 00m00s >>>>> Fedora 41 openh264 (From Cisco) - x86_ 100% | 3.2 KiB/s | 986.0 B | 00m00s >>>>> Fedora 41 - x86_64 100% | 241.7 KiB/s | 480.5 KiB | 00m02s >>>>> Fedora 41 - x86_64 - Updates 100% | 4.4 MiB/s | 11.5 MiB | 00m03s >>>>> Fedora 41 openh264 (From Cisco) - x86_ 100% | 7.3 KiB/s | 5.8 KiB | 00m01s >>>>> Repositories loaded. >>>>> Package "sudo-1.9.15-5.p5.fc41.x86_64" is already installed. >>>>> ... >>>>> Complete! >>>>> Generating grub configuration file ... >>>>> Adding boot menu entry for UEFI Firmware Settings ... >>>>> done >>>>> Updating and loading repositories: >>>>> Repositories loaded. >>>>> Failed to resolve the transaction: >>>>> No match for argument: isc-dhcp-client >>>>> No match for argument: ifupdown >>>>> You can try to add to command line: >>>>> --skip-unavailable to skip unavailable packages >>>>> virt-builder: error: dnf -y install 'isc-dhcp-client' 'ifupdown': command >>>>> exited with an error >>>>> >>>>> If reporting bugs, run virt-builder with debugging enabled and include the >>>>> complete output: >>>>> >>>>> virt-builder -v -x [...] >>>> This appears to come from the new base_image virt_builder template, >>>> where we have: >>>> >>>> {% if distro_debian_based is defined and distro_debian_based %} >>>> {# Ugh, debian has to be told to bring up the network and regenerate ssh >>>> keys #} >>>> {# Hope we get that interface name right! #} >>>> install isc-dhcp-client,ifupdown >>>> mkdir /etc/network/interfaces.d/ >>>> >>>> Which I would expect to apply only when the /guest/ is Debian, not >>>> the host. It could be that the distro detection logic works only when >>>> both the host and guest are the same? >>> >>> I think the problem arises because the new base_image role uses these >>> distro checks instead of what bringup_guestfs.sh did, which was select >>> these commands based on {{ virtbuilder_os_version }} >>> >>> virt-builder.j2 needs to use virtbuilder_os_version for these checks. >> virtbuild_os_version doesn't give us quite everything that is needed. >> Looks like the template needs to add some more cruft if Trixie is in >> use. So I've put together a possible fix, pushed to the cel-fixes branch >> in linux-kdevops. Please have a look. >> >> Passes some (very) light testing with a Fedora 41 host and all of a >> Debian 12, Debian 13, or Fedora 42 guest. Bringup gets past the >> virt-builder stage now for all three. >> >> > > FYI, I tested this on Debian Trixie with a Fedora 41 guestfs image. It didn't > fully work, but it got further than before. The guest now runs, though with many > issues, likely due to low disk space. I suspect the resize task didn't run. > > systemd[1]: tmp.mount: Start request repeated too quickly. > systemd[1]: tmp.mount: Failed with result 'exit-code'. > systemd[1]: Failed to mount tmp.mount - Temporary Directory /tmp. > systemd[1]: systemd-oomd.service: Start request repeated too quickly. > systemd[1]: systemd-oomd.service: Failed with result 'exit-code'. > systemd[1]: Failed to start systemd-oomd.service - Userspace Out-Of-Memory (OOM) Killer > > update_ssh_config_guestfs : Check if the new fixed include directive was used ----------------- 0.00s > + LIBVIRT_DEFAULT_URI=qemu:///system > + .//scripts/update_ssh_config_guestfs.py > Traceback (most recent call last): > File "/home/dagomez.linux/src/kdevops/.//scripts/update_ssh_config_guestfs.py", line 109, in > main() > ~~~~^^ > File "/home/dagomez.linux/src/kdevops/.//scripts/update_ssh_config_guestfs.py", line 96, in main > addr = get_addr(name) > File "/home/dagomez.linux/src/kdevops/.//scripts/update_ssh_config_guestfs.py", line 40, in get_addr > raise Exception(f"Unable to get an address for {name} after 60s") > Exception: Unable to get an address for dagomez-xarray after 60s > make: *** [scripts/guestfs.Makefile:59: .provisioned_once_ssh] Error 1 > > On the other hand, images look size-wise just fine: > > ls -lhsta /var/lib/libvirt/images/kdevops/guestfs/base_images/fedora-41.raw > 1.8G -rw-r--r-- 1 root root 20G Oct 18 00:19 /var/lib/libvirt/images/kdevops/guestfs/base_images/fedora-41.raw > $ ls -lhsta /var/lib/libvirt/images/kdevops/guestfs/dagomez-xarray/root.raw > 1.8G -rw-r--r-- 1 libvirt-qemu libvirt-qemu 20G Oct 18 00:39 /var/lib/libvirt/images/kdevops/guestfs/dagomez-xarray/root.raw I've added support to select the guestfs image (e.g. debian-13/fedora-41) from GitHub manual actions when in use with branch: ci-testing/fedora-locales-fix. The server (Debian) reproduces the error above. You have full kdevops logs here: https://github.com/linux-kdevops/kdevops/actions/runs/18606712456/job/53057523581 The branch also includes the patch discussed and tested to fix fedora hosts (controller node). I'll push to main when it passes.