Re: [PATCH v2 7/9] all: run black

[Chuck Lever <cel@kernel.org>]

On 8/1/25 12:29 PM, Daniel Gomez wrote:
> 
> 
> On 01/08/2025 14.55, Chuck Lever wrote:
>> On 8/1/25 4:12 AM, Daniel Gomez wrote:
>>>
>>>
>>> On 31/07/2025 14.57, Daniel Gomez wrote:
>>>> On 30/07/2025 08.01, Luis Chamberlain wrote:
>>>>> Run black to fix tons of styling issues with tons of Python scripts.
>>>>> In order to help bots ensure they don't add odd styling we need a
>>>>> convention.
>>>>>
>>>>> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
>>>>
>>>> Acked-by: Daniel Gomez <da.gomez@samsung.com>
>>>>
>>>> FYI, I'm working on b4 check stuff mentioned in the other thread. I think this
>>>> is really nice but it would be awesome to also extend it to Ansible files using
>>>> the Ansible linter:
>>>>
>>>> ansible-lint --help
>>>> {...}
>>>> --fix [WRITE_LIST]    Allow ansible-lint to perform auto-fixes, including YAML
>>>> reformatting
>>
>> I use ansible-lint extensively before commit. Linting existing kdevops
>> files is still a bit of jungle, so ansible-lint would have to be
>> directed only at new files.
> 
> It's wild. I've sent an RFC with this:
> 
> git show --shortstat HEAD
> 234 files changed, 5308 insertions(+), 5098 deletions(-)
> git show HEAD | grep -c '^@@'
> 735
> 
> Hopefully this will raise a bit the bar with the format. Next challenge is to
> try to keep it.

I generally try to fix things up as I encounter lint complaints, as I
am a fan of static analysis. Even though the "actual positive" rate can
be low, some discovered issues have been significant, IME.

However, there is risk in making changes when static checkers throw
warnings. Not infrequently, an otherwise innocent clean-up can result
in unintended behavior changes. So I try to keep the churn to a minimum
and test thoroughly.

There have been several enormous patch series that have come through in
the past week; difficult to review all of that. Even though tools like
Claude and black can generate a very high quantity of patches, there's
nothing that guarantees these are quality changes. I would like to see
things slow down a little so us humans can have a chance to paw through
them.

So +1 on the use of lint tools! But also let's tread carefully.


>>>> So, these changes with black/ansible-lint, etc make sense if:
>>>> 1. Add b4 integration
>>>> 2. Make CI run the scripts as well (make style, make check, etc)
>>>>
>>>> But I suspect a minimal testing may be needed.
>>>>
>>>> Thoughts?
>>>
>>> I'll send an RFC with more details.
>>
> 


-- 
Chuck Lever