From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43FFE13B58D for ; Fri, 1 Aug 2025 16:55:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754067359; cv=none; b=ulSxTGsqJ+cps94kqSSpSGYszrkexZpKtEZ5amWiZoqqyyQYUxVRrJkWYeAu6d4WGLzh8ZjnplYrRwxMa/C2JK630fw+e6c8776pkWENkaYBoZzCDXSpbMLyQGufz2NiZwlWWrfaDFW+i57ltJW5iUgH0UEk1NgmfcN3hGihSMk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754067359; c=relaxed/simple; bh=wdE1YPqzUZZEt7nFlTwqOjm3NGELsFluaTLdGbzsN8M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MnytYDscYP6i8QIZ0DXTgjujRJjJWglhedGeMuvt/hn1kWEniMnvp9UQGr4EYT4BPd4UXuwqm5SXLeVyioWPeBfjMn+LSrioh2hY90qNRUnZDXCCTzaS+ct/qwR8GiUp84ewlPGLKZwx0hTtl4pb+POYi3XV+wXxeLw/Al10XFI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qPWPsko1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qPWPsko1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73EA5C4CEE7; Fri, 1 Aug 2025 16:55:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754067358; bh=wdE1YPqzUZZEt7nFlTwqOjm3NGELsFluaTLdGbzsN8M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qPWPsko1sNFXaciImVsTCdZfnGBe1sggpZHgGd4D0DLgJDxSPStQJMcZB0T47H/lI l9AwB0EOZvC9s3viObxFSnTaMvTCahwMj9o1c+EHVPKwzoKhoyOgLkuP902NpUtJ8w L+3jZpoCuDBT/U8TJBGRu/4osnuIKIOBg6QTR9rFR96znuOjWCQuYbUZ06qz74D46F 7CSTHtCQmTABfdfmw938dHeEGSpGXJDYpvJo9aoVYyJi6o6B2yTOfPEXUNN3/J3YwO ieiAVztqyMj/hyPEELyJTHxyvK0SsimdhBbwkLULdBnndvcC2V29Ioh+F11JqFp66l sS6W1K3ydY1Ww== Message-ID: <6ec52832-4439-4dcd-b3c2-c5f654b5bb80@kernel.org> Date: Fri, 1 Aug 2025 12:55:57 -0400 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/9] all: run black To: Daniel Gomez Cc: Luis Chamberlain , Daniel Gomez , kdevops@lists.linux.dev References: <20250730060147.182140-1-mcgrof@kernel.org> <20250730060147.182140-8-mcgrof@kernel.org> <91f83d54-8375-4016-ab53-7a210437d39b@kernel.org> <1ca365a4-13b0-4f43-8568-058e566d0ef7@kernel.org> Content-Language: en-US From: Chuck Lever Organization: kernel.org In-Reply-To: <1ca365a4-13b0-4f43-8568-058e566d0ef7@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/1/25 12:29 PM, Daniel Gomez wrote: > > > On 01/08/2025 14.55, Chuck Lever wrote: >> On 8/1/25 4:12 AM, Daniel Gomez wrote: >>> >>> >>> On 31/07/2025 14.57, Daniel Gomez wrote: >>>> On 30/07/2025 08.01, Luis Chamberlain wrote: >>>>> Run black to fix tons of styling issues with tons of Python scripts. >>>>> In order to help bots ensure they don't add odd styling we need a >>>>> convention. >>>>> >>>>> Signed-off-by: Luis Chamberlain >>>> >>>> Acked-by: Daniel Gomez >>>> >>>> FYI, I'm working on b4 check stuff mentioned in the other thread. I think this >>>> is really nice but it would be awesome to also extend it to Ansible files using >>>> the Ansible linter: >>>> >>>> ansible-lint --help >>>> {...} >>>> --fix [WRITE_LIST] Allow ansible-lint to perform auto-fixes, including YAML >>>> reformatting >> >> I use ansible-lint extensively before commit. Linting existing kdevops >> files is still a bit of jungle, so ansible-lint would have to be >> directed only at new files. > > It's wild. I've sent an RFC with this: > > git show --shortstat HEAD > 234 files changed, 5308 insertions(+), 5098 deletions(-) > git show HEAD | grep -c '^@@' > 735 > > Hopefully this will raise a bit the bar with the format. Next challenge is to > try to keep it. I generally try to fix things up as I encounter lint complaints, as I am a fan of static analysis. Even though the "actual positive" rate can be low, some discovered issues have been significant, IME. However, there is risk in making changes when static checkers throw warnings. Not infrequently, an otherwise innocent clean-up can result in unintended behavior changes. So I try to keep the churn to a minimum and test thoroughly. There have been several enormous patch series that have come through in the past week; difficult to review all of that. Even though tools like Claude and black can generate a very high quantity of patches, there's nothing that guarantees these are quality changes. I would like to see things slow down a little so us humans can have a chance to paw through them. So +1 on the use of lint tools! But also let's tread carefully. >>>> So, these changes with black/ansible-lint, etc make sense if: >>>> 1. Add b4 integration >>>> 2. Make CI run the scripts as well (make style, make check, etc) >>>> >>>> But I suspect a minimal testing may be needed. >>>> >>>> Thoughts? >>> >>> I'll send an RFC with more details. >> > -- Chuck Lever