Re: [PATCH v2 1/9] roles/guestfs: add missing bootlinux_9p: False

[Chuck Lever <cel@kernel.org>]

On 7/30/25 2:01 AM, Luis Chamberlain wrote:
> Commit 722d83a4871c41 ("bootlinux: Move 9p build tasks to a subrole")
> added a proactive directory creation as we no longer git clone right
> away, but forgot to ensure the variable is defined by default. When
> we don't enable building linux this variable is not defined. Fix this.
> 
> Fixes: 722d83a4871c41 ("bootlinux: Move 9p build tasks to a subrole")
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
>  playbooks/roles/guestfs/defaults/main.yml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/playbooks/roles/guestfs/defaults/main.yml b/playbooks/roles/guestfs/defaults/main.yml
> index eec137bd..76854d06 100644
> --- a/playbooks/roles/guestfs/defaults/main.yml
> +++ b/playbooks/roles/guestfs/defaults/main.yml
> @@ -3,3 +3,4 @@ distro_debian_based: false
>  
>  libvirt_uri_system: false
>  libvirt_enable_largeio: false
> +bootlinux_9p: False

For "Move 9p build tasks to a subrole" IIRC all Kconfig configurations
allowed "output yaml" to set bootlinux_9p, so a default was unnecessary.

Some later patch made it possible for "make menuconfig" to complete
without encountering that "output yaml" so that must be what leaves the
variable unset.


Reviewed-by: Chuck Lever <chuck.lever@oracle.com>


-- 
Chuck Lever