From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 760001369B4 for ; Wed, 30 Jul 2025 14:17:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753885056; cv=none; b=FIIZkwGUGd1f3PgOaYaygxRFeQgEDMyipZu+yvy7pJeGrWMsorQBnWXJnpTRV4vF71l/tFJLMb5hALuIBAA9qwI+BaHZTUsTnw24JaX/pwjRvlh3Y1G2oobkLcH7v7oH8eQBdWVspoa0HbtfUw0lm+OcL/uB2yLKhkQJNR13lT8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753885056; c=relaxed/simple; bh=MRavzeNga+ulVi4Ve2Rfrjnqkw5Ei06KvXmwfiow7Cg=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=YkZk1LBK5FPLobk9WnDKCZ5PXMYj1Awp62Unp/UmX67c87OJaLbkwNNsgNc9fFwFBFFevnVbX9sipWKBfGTNwk3RgFI6efxJp4bX+8H7uaKJkX1fYLrWHN35QrjX6JSKjKU0aPGbduGZ9T2whm3yWcl+kYsoNc9D5m3SzQtJ1I8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gBFBQHUP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gBFBQHUP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8154C4CEE7; Wed, 30 Jul 2025 14:17:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753885056; bh=MRavzeNga+ulVi4Ve2Rfrjnqkw5Ei06KvXmwfiow7Cg=; h=Date:Subject:To:References:From:In-Reply-To:From; b=gBFBQHUPHoevKSF2ROqTjKwHr7JN6T7t529rn5qyFLVgUdHjrsvj2qmLHsGrxapcH TTH8qiwaZRmpW/c6Lyy1nR6pofJHGAgLD87e2NxwUAWFvoG2zn84ck2cmIqdQyseJi adwKsOEhNoB8Iam82J9r9f6CmZT2qWR92hKFrNGPyZfsQHU/4WWAsMrFY+m47wgtpl f9EQ+VbsVXrmPrqycYgtAgoX4riY5kFBS+DlpuQPMsJQg+CduV+ZNB3PBsfwIlYzvT 9bbH8RsG+4q3hgY4xSxKXbQgchN/l46CpnPoeWuFr0VuVwQTpR2t32UYKMIBNB9DUr vz1NDXgZDcqWQ== Message-ID: <71cb0708-2d8e-4f2c-bb40-319efe2e1095@kernel.org> Date: Wed, 30 Jul 2025 10:17:34 -0400 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/9] roles/guestfs: add missing bootlinux_9p: False To: Luis Chamberlain , Daniel Gomez , kdevops@lists.linux.dev References: <20250730060147.182140-1-mcgrof@kernel.org> <20250730060147.182140-2-mcgrof@kernel.org> Content-Language: en-US From: Chuck Lever Organization: kernel.org In-Reply-To: <20250730060147.182140-2-mcgrof@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/30/25 2:01 AM, Luis Chamberlain wrote: > Commit 722d83a4871c41 ("bootlinux: Move 9p build tasks to a subrole") > added a proactive directory creation as we no longer git clone right > away, but forgot to ensure the variable is defined by default. When > we don't enable building linux this variable is not defined. Fix this. > > Fixes: 722d83a4871c41 ("bootlinux: Move 9p build tasks to a subrole") > Signed-off-by: Luis Chamberlain > --- > playbooks/roles/guestfs/defaults/main.yml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/playbooks/roles/guestfs/defaults/main.yml b/playbooks/roles/guestfs/defaults/main.yml > index eec137bd..76854d06 100644 > --- a/playbooks/roles/guestfs/defaults/main.yml > +++ b/playbooks/roles/guestfs/defaults/main.yml > @@ -3,3 +3,4 @@ distro_debian_based: false > > libvirt_uri_system: false > libvirt_enable_largeio: false > +bootlinux_9p: False For "Move 9p build tasks to a subrole" IIRC all Kconfig configurations allowed "output yaml" to set bootlinux_9p, so a default was unnecessary. Some later patch made it possible for "make menuconfig" to complete without encountering that "output yaml" so that must be what leaves the variable unset. Reviewed-by: Chuck Lever -- Chuck Lever