From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E2E71DFDE for ; Fri, 16 May 2025 12:51:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747399879; cv=none; b=LXPv8fABnMfCZbnfdzPYXevqEhmIsQFKGv7U2YxSwX+eveL9e6Z5P6jhNob/54TMUr3lKmdCOnBF1CkrHIxYpNTB5oRlgfQ3NmjCmL49V97FRI55szumf+exFeriM21N7HbNcr68BJnircdq/Y6FcOFMmtY33lXg/3nuFesYH20= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747399879; c=relaxed/simple; bh=eXJSgGcGKbSQUizyysdBRBWl/Z0RDv6Z5N6nauKrV4Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NyStxiAC22GU8D1dwUkE/fBIF/d1McTLnHORq8+2rkDPiiYnqfn4fih1Ia14vdnUFu0fJAN/gwD9PfxYbvJVuHKAmXt/AP5m1Bwr5C5KJ1/Y8YCa3KQTqGOa+9eBkwCBI3O5d11u0JjjMogYa5hzhaEWjSf0SL6p0yN9HgufuvI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QA73GYtt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QA73GYtt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E65C6C4CEE4; Fri, 16 May 2025 12:51:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747399878; bh=eXJSgGcGKbSQUizyysdBRBWl/Z0RDv6Z5N6nauKrV4Y=; h=Date:Reply-To:Subject:To:Cc:References:From:In-Reply-To:From; b=QA73GYttkioXpl4Wp7BHL1lDKkMroK8yG8kEC0JYZ0KbaDzWlsC3os4hVkikxCNmj 3u42yRtws+22GTUFUP6i3iOwZ5UuEytKkaV5ghPVkRGcxBAFP83a1VPunPj3+6BU00 026A3RMiF5qFCkKyOMy81FZJ+IfidUVyKHDP2IHQ/1RZtmYA3r3SRG9albzxEmhaFh 6vPl/YIpB/VFzcWOSd9lFQUSy92Lmg1UiD3hgbiaJey5IKk0V2/3upU4ZnEf9uMNbX 3saGi9xlAdhwS1KPHR/37T8yq1FmMDYMmH610u3HCz+/Gm2If+o6SAUusZwVSjiSkm OmGj3xKth7mCQ== Message-ID: <7cd31cfc-751e-41c2-a9e5-8962d842edd9@kernel.org> Date: Fri, 16 May 2025 14:51:16 +0200 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: da.gomez@kernel.org Subject: Re: [PATCH v3 01/10] playbooks: fix playbook name for all hosts plays To: Chuck Lever , Luis Chamberlain Cc: kdevops@lists.linux.dev, Daniel Gomez References: <20250505-ansible_cfg_inventory-v3-0-a153d93c35c4@samsung.com> <20250505-ansible_cfg_inventory-v3-1-a153d93c35c4@samsung.com> <6dedbabd-79b5-4350-8a11-287cc33de568@oracle.com> Content-Language: en-US From: Daniel Gomez Organization: kernel.org In-Reply-To: <6dedbabd-79b5-4350-8a11-287cc33de568@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 06/05/2025 22.39, Chuck Lever wrote: > On 5/5/25 5:24 PM, Daniel Gomez wrote: >> From: Daniel Gomez >> >> Fix name rule by naming all the playbooks that run in all hosts. >> >> https://ansible.readthedocs.io/projects/lint/rules/name/ > > Nit: name[casing] states these names must begin with an upper case > letter. Ditto for 02/10. > > Would be slightly nicer, perhaps, if these names were documentary > sentences, as they are in the roles themselves. I'm getting a bit of “buddy” assistance on some playbooks I'm less/not familiar with. Here's the first pass covering about half of them. --- a/playbooks/blktests.yml +++ b/playbooks/blktests.yml -- name: blktests +- name: Linux kernel block layer tests (blktests) --- a/playbooks/bootlinux-local.yml +++ b/playbooks/bootlinux-local.yml -- name: bootlinux-local +- name: Bootlinux (localhost only) --- a/playbooks/bringup_guestfs.yml +++ b/playbooks/bringup_guestfs.yml -- name: bringup_guestfs +- name: Bringup Guests (libguestfs) --- a/playbooks/build_qemu.yml +++ b/playbooks/build_qemu.yml -- name: build_qemu +- name: Build QEMU --- a/playbooks/common.yml +++ b/playbooks/common.yml -- name: common +- name: Common (shared role) --- a/playbooks/create_data_partition.yml +++ b/playbooks/create_data_partition.yml -- name: create_data_partition +- name: Create Directory Data Path (e.g. /data partition) --- a/playbooks/devconfig.yml +++ b/playbooks/devconfig.yml -- name: devconfig +- name: Configure developer environment on target systems --- a/playbooks/fstests.yml +++ b/playbooks/fstests.yml -- name: fstests +- name: "Filesystem testing suite setup - (x)fstests (control node only)" -- hosts: baseline:dev +- name: Filesystem testing suite setup - (x)fstests + hosts: baseline:dev --- a/playbooks/pynfs.yml +++ b/playbooks/pynfs.yml -- name: pynfs +- name: Configure and run pynfs testing workflow --- a/playbooks/reboot-limit.yml +++ b/playbooks/reboot-limit.yml -- name: reboot-limit +- name: reboot-limit stability test workflow --- a/playbooks/rxe.yml +++ b/playbooks/rxe.yml -- name: rxe +- name: Set up software-emulated RoCE RDMA over Ethernet (rxe) via udev --- a/playbooks/selftests.yml +++ b/playbooks/selftests.yml -- name: selftests +- name: Set up and run Linux kernel selftests (kselftests) --- a/playbooks/siw.yml +++ b/playbooks/siw.yml -- name: siw +- name: Set up software-emulated iWARP RDMA over TCP/IP (siw) via udev --- a/playbooks/smbd.yml +++ b/playbooks/smbd.yml -- name: smbd +- name: Set up Samba server with shared volume and system integration --- a/playbooks/sysbench.yml +++ b/playbooks/sysbench.yml -- name: sysbench +- name: Sysbench workflow --- a/playbooks/terraform.yml +++ b/playbooks/terraform.yml -- name: terraform +- name: Manage infrastructure lifecycle and SSH access with Terraform --- a/playbooks/update_etc_hosts.yml +++ b/playbooks/update_etc_hosts.yml -- name: update_etc_hosts +- name: Update target /etc/hosts with all targets and disable cloud-init --- a/playbooks/update_ssh_config_guestfs.yml +++ b/playbooks/update_ssh_config_guestfs.yml -- name: update_ssh_config_guestfs +- name: Update OpenSSH client configuration file (libguestfs)