Re: [RFC PATCH 00/31] Simplify OCI configuration menu

[Chandan Babu R <chandanbabu@kernel.org>]

On Tue, Apr 08, 2025 at 09:20:30 AM -0400, Chuck Lever wrote:
> On 4/8/25 8:42 AM, Chandan Babu R wrote:
>> On Wed, Apr 02, 2025 at 01:08:34 PM -0700, Luis Chamberlain wrote:
>>> On Wed, Apr 02, 2025 at 03:38:04PM -0400, Chuck Lever wrote:
>>>> On 4/2/25 3:21 PM, Luis Chamberlain wrote:
>>>>> On Mon, Mar 31, 2025 at 08:59:29PM -0400, cel@kernel.org wrote:
>>>>>> From: Chuck Lever <chuck.lever@oracle.com>
>>>>>> I've come up with some simplifications that can apply to all of
>>>>>> the providers, but I'd like to start with OCI because 
>>>>>
>>>>> Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
>>>>
>>>> Thanks for taking a look!
>>>>
>>>> I guess my basic concern here is that I'm changing the name of some
>>>> Kconfig variables, which would break backwards compatibility.
>>>
>>> I've addressed concerns like that befored by adding a respective kconfig
>>> value and mapping the old one to the new shiny one with an XXX to
>>> annotate we should remove the older one later. But if for cloud I
>>> suspect most users might stick to that version of kdevops and have no
>>> need to upgrade too, and so I am not sure if its needed as much as
>>> the guest / virtualization use case.
>>>
>>>> If you and Chandan feel that is not a roadblock, then I will start
>>>> committing these and the similar patches I have for the other three
>>>> major providers.
>>>
>>> My use cases of cloud are all completely ephemeral and stuck to one
>>> version of kdevops in particular because of the cost, and so I am
>>> careful to always 'make destroy' as soon as I'm done otheriwse you
>>> can economically bleed. And so I think economics drives kdevops
>>> cloud instances to be super ephemeral.
>>>
>>> So for *me*, I say go for it.
>>>
>>> But I am not sure if other folks are using kdevops for the cloud
>>> in other ways, but certainly Chandan would have good sensing on that.
>>>
>> 
>> The changes made by the patchset definitely improve the usability of OCI via
>> kdevops. Thanks for working on this.
>> 
>> Reviewed-by: Chandan Babu R <chandanbabu@kernel.org>
>
> Thanks for your review!
>
>
>> Also, Can you please include the VM.Standard.x86.Generic shape in the list of
>> shapes introduced by "[RFC PATCH 16/31] terraform/OCI: Add a shape selector
>> for Flex shapes" patch. This shape is recommended for developers from my
>> department who do not require a specific model of CPU for their work.
>
> Yes, I can do that. An alternative would be to retain the ability to
> enter an arbitrary string here (and maybe for image selection).

Yes, That would be very helpful. Thanks!

-- 
Chandan