Re: [PATCH] terraform/oci: Add VM.Standard.x86.Generic shape to available options

[Chandan Babu R <chandanbabu@kernel.org>]

On Wed, May 07, 2025 at 10:52:39 AM -0700, Luis Chamberlain wrote:
> On Wed, May 07, 2025 at 01:33:07PM -0400, Chuck Lever wrote:
>> On 5/7/25 1:05 PM, Luis Chamberlain wrote:
>> > On Wed, May 07, 2025 at 03:25:16PM +0530, Chandan Babu R wrote:
>> >> The VM.Standard.x86.Generic is another shape available for Oracle Linux kernel
>> >> developers. This commit adds this shape to the list of available flexible
>> >> shapes.
>> >>
>> >> Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
>> >> ---
>> >> Chuck,
>> >>
>> >> Kconfig's "choice" construct does not allow "free text" to be
>> >> entered. Hence, I had to add the new entry as a choice.
>> > 
>> > You can resolve this as follows?
>> > 
>> > diff --git a/terraform/oci/kconfigs/shapes/Kconfig.flex b/terraform/oci/kconfigs/shapes/Kconfig.flex
>> > index c2b3f5719c48..e8d0860aac67 100644
>> > --- a/terraform/oci/kconfigs/shapes/Kconfig.flex
>> > +++ b/terraform/oci/kconfigs/shapes/Kconfig.flex
>> > @@ -73,6 +73,7 @@ endchoice
>> >  config TERRAFORM_OCI_SHAPE
>> >  	string
>> >  	output yaml
>> > +	default "VM.Standard.x86.Generic" if TERRAFORM_OCI_SHAPE_VM_STANDARD_X86_GENERIC
>> >  	default "VM.Standard3.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD3_FLEX
>> >  	default "VM.Standard.E4.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD_E4_FLEX
>> >  	default "VM.Standard.E5.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD_E5_FLEX
>> 
>> I'm able to select the VM.Standard.x86.Generic shape by going to
>> 
>>   Bring up methods -> Node bring up methods
>> 
>> Choose Terraform then OCI, then
>> 
>>   Compute -> OCI shape family
>> 
>> and choose "Generic"
>> 
>> Is that not working?
>
> Oh never mind, I thought Chandan had an issue with using kconfig choice
> to map to string. If the respective string is already populated my
> recomendaiton is nonsense :)
>

Sorry, it was my mistake. I did not check the options under "Generic Shapes".

Sorry once again.

-- 
Chandan