From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA615EEAA for ; Thu, 8 May 2025 13:09:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746709785; cv=none; b=LG/PWqanpJFsbXQql/RPpNo5VDiJdtn7wg7ZRRTNH01CYgpIKLl9sBGmDyiz4FffzHCiNkw3xm2Qw5je6WofA70jMkqUaZnQiRQI06DQKXtzrx53i8VBzqq+Ii3XcEBgC2IYrMD/ynQdjRhl14Ou/164rZ29H42nMBgil5dJ0IU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746709785; c=relaxed/simple; bh=gGu6SwWeMIMC9NmIZXKqf+s3PlffVQ5MUwX3R7Swx3M=; h=References:From:To:Cc:Subject:Date:In-reply-to:Message-ID: MIME-Version:Content-Type; b=txIIagR7UXPhPuT+h4r8LIZyf8ev+KRPBNuHqIn19YYGyyOrcYhrm3ocbUMVVyTEhYcTMM58i+ud9RzO2Ib3khrqX0xjclnpAqg7g8GtNfFSH1ScZ4GQ3iVGXIY4I9Bf11Vl+xWRrp1KYZvaQekGixRvOo1zAm/ashfakHKoHMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jaHxecAH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jaHxecAH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9430C4CEE7; Thu, 8 May 2025 13:09:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746709785; bh=gGu6SwWeMIMC9NmIZXKqf+s3PlffVQ5MUwX3R7Swx3M=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=jaHxecAHU0VHHt55w9uf67VVCQFVJHvR/xUBPiDTgeN+xc1Ua8cKj7+xrTDOa3Eh0 J2LPBKj90BMyk+kaqcCMF6YTWMwwWu0WNxai/fwmGZZT70obnSw5QpXmxe4fQUU4Mm HrHBkArWnKbwkDug9BqgDiRKqkIz1a06p3bIs5zO3ab79xRW+1+Fs1dDazfUjO/jBv ulLyUsxz3yM7SF7VsQSPKfzOnbZBxR59g5+Th0+fdSraHQJtSfWcxots4T3g67fpGS Q7tqmX8pePOda7jcHHVH3MDq49FYNI9QoySFTykdV8X+mlCZ3r3/Gc2Uj+LjUybcSH RBMSW8zjwxjng== References: <20250507095522.1027554-1-chandanbabu@kernel.org> <0081c933-a6b3-4caa-83f3-f1a1fa53fff7@oracle.com> User-agent: mu4e 1.10.8; emacs 29.2 From: Chandan Babu R To: Chuck Lever Cc: Luis Chamberlain , kdevops@lists.linux.dev Subject: Re: [PATCH] terraform/oci: Add VM.Standard.x86.Generic shape to available options Date: Thu, 08 May 2025 18:37:10 +0530 In-reply-to: Message-ID: <87ikmbmepa.fsf@debian-BULLSEYE-live-builder-AMD64> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, May 07, 2025 at 10:52:39 AM -0700, Luis Chamberlain wrote: > On Wed, May 07, 2025 at 01:33:07PM -0400, Chuck Lever wrote: >> On 5/7/25 1:05 PM, Luis Chamberlain wrote: >> > On Wed, May 07, 2025 at 03:25:16PM +0530, Chandan Babu R wrote: >> >> The VM.Standard.x86.Generic is another shape available for Oracle Linux kernel >> >> developers. This commit adds this shape to the list of available flexible >> >> shapes. >> >> >> >> Signed-off-by: Chandan Babu R >> >> --- >> >> Chuck, >> >> >> >> Kconfig's "choice" construct does not allow "free text" to be >> >> entered. Hence, I had to add the new entry as a choice. >> > >> > You can resolve this as follows? >> > >> > diff --git a/terraform/oci/kconfigs/shapes/Kconfig.flex b/terraform/oci/kconfigs/shapes/Kconfig.flex >> > index c2b3f5719c48..e8d0860aac67 100644 >> > --- a/terraform/oci/kconfigs/shapes/Kconfig.flex >> > +++ b/terraform/oci/kconfigs/shapes/Kconfig.flex >> > @@ -73,6 +73,7 @@ endchoice >> > config TERRAFORM_OCI_SHAPE >> > string >> > output yaml >> > + default "VM.Standard.x86.Generic" if TERRAFORM_OCI_SHAPE_VM_STANDARD_X86_GENERIC >> > default "VM.Standard3.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD3_FLEX >> > default "VM.Standard.E4.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD_E4_FLEX >> > default "VM.Standard.E5.Flex" if TERRAFORM_OCI_SHAPE_VM_STANDARD_E5_FLEX >> >> I'm able to select the VM.Standard.x86.Generic shape by going to >> >> Bring up methods -> Node bring up methods >> >> Choose Terraform then OCI, then >> >> Compute -> OCI shape family >> >> and choose "Generic" >> >> Is that not working? > > Oh never mind, I thought Chandan had an issue with using kconfig choice > to map to string. If the respective string is already populated my > recomendaiton is nonsense :) > Sorry, it was my mistake. I did not check the options under "Generic Shapes". Sorry once again. -- Chandan