From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53A391F5842 for ; Mon, 25 Aug 2025 14:16:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756131398; cv=none; b=M8LcxbIGgnQxCpXfuqMg0LIcm7aYATUzEBT1pEqVyR5ZzyibZdA/dI+W+4DVRTP+ffa95CzBPO/sJp0rSlpfHFzXl7w0Nk1MMD//UTXJWPjy9TsMDoU2EPkUoO66NPKWnWIVfQCT/q7w15V10VoyDmIztSPt1nwcFCtRFnRSOag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756131398; c=relaxed/simple; bh=HAxDSvOd2pQMoSoc1vX9RO/3PjDm/gwyB8bN2eM63y0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fnjzFSe03BiDW30rmbHNSDwSFSq61YLkM90JlfWGRi6YOMJgnYTRR4SXehG3wN0dsFxE2HOaOTn8hWuwp/ZYjSJwPw25+Bsiicrd1FQo4YTXCFC1AIaQFNueqSslJ+kzKQTOyZA50ikttns1v1XwdnE6y3I6kuVJL0034IDj3fc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ljDmdSR9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ljDmdSR9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 698CEC4CEED; Mon, 25 Aug 2025 14:16:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756131397; bh=HAxDSvOd2pQMoSoc1vX9RO/3PjDm/gwyB8bN2eM63y0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ljDmdSR9/HZuHQQDd/OW989iZBcf0F4i+3j9QXbvQcWKxUDFGAu70W0u0zXcFlOBS GBgAP/IWI4etCwW3wmIxmMGq1etj3QPBczrcYcY1Z931+cA2mO4dtYREwgHcjrn+gH EVVpVtV/ajmA7sBdrcS5WQMEj+EQXH/I4Ya3G7jQ/f6JECf+yV5gZuAQuh4S7U/aUc fy1y4dB8Zovc9oFkSW0eERhe04DQAdf4SU7ZMgJO6hFi+n7HoExRfDaSma7OaMmaO9 8dytx97b3vXWSnD6U+NDGknbYM+Pb9NeDDekG3bT1OLWojJgd9FzA/udjxzeK+mC2c 5cw2E/7RgUqCg== Message-ID: <89e2f424-6cc3-4d99-9468-d8d194ee0870@kernel.org> Date: Mon, 25 Aug 2025 10:16:35 -0400 Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1] Add an Ansible requirements.yml file To: Luis Chamberlain Cc: kdevops@lists.linux.dev, Chuck Lever References: <20250824162305.16602-1-cel@kernel.org> Content-Language: en-US From: Chuck Lever Organization: kernel.org In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/25/25 4:38 AM, Luis Chamberlain wrote: > On Sun, Aug 24, 2025 at 12:23:05PM -0400, Chuck Lever wrote: >> From: Chuck Lever >> >> Commit b90d89d27659 ("Switch to the cloud.terraform.terraform >> module") introduced the use of the cloud.terraform module, and >> commit 7ccb64834eeb ("guestfs: Replace scripts/destroy_guestfs.sh >> with an Ansible playbook") introduced the use of the >> community.libvirt module. It would be friendly if kdevops could >> pull in the Ansible modules it needs transparently. >> >> The requirements.yml file is a manifest of Ansible collections that >> the project needs to run. Installation of these collections is made >> automatic by adding: >> >> ansible-galaxy install -r requirements.yml >> >> to the "make ansible_cfg" step. This mechanism can keep cached >> versions of collections up to date, and can also constrain a >> cached collection to a specific version, if that's needed. >> >> The initial file contains requirements I could find easily, and >> should be updated over time as new collection dependencies are >> introduced. >> >> See also: >> >> https://docs.ansible.com/ansible/latest/user_guide/collections_using.html >> >> Question: Can we assume that the Ansible controller has internet >> access all the time? > > That's not really an issue at all, but what I learned using galaxy stuff > was if we required *our* own stuff upstream on galaxy it was not worth > it. > > Given you're only using external stuff, then that seems sensible to me. Yes, only collections that are already in the Ansible galaxy. Any missing collections are installed into the Ansible user's home directory, so "sudo" is not needed. Also, this mechanism seems smart enough to deal with collections that are already installed in shared locations. It skips re-installing. > But now given our ongoing dialog over how to ease the pain to make it > easy to use kdevops for new folks, how would this be handled? Are we > OK with the request to phone home out? Exactly; phoning home is OK for my own use cases, but I can't answer that for anyone else's. -- Chuck Lever