Re: [PATCH v2 0/4] guestfs: bringup: add debug mode

[Chuck Lever <chuck.lever@oracle.com>]

On 5/12/25 9:36 AM, Daniel Gomez wrote:
> This has helped me during debug sessions of bringup script. "Resend"
> with minor changes.
> 
> Adding debug option in bash bringup_guestfs.sh allows to check for
> commands executions (virsh, chmod, cp, virt-sysprep, etc) and variables.
> 
> Add 3 levels of debug:
> - Disabled: This is the current behaviour and is the default.
> - set -x (debug mode 0):  Allows to print the executed commands but if
> they fail, the script continues.
> - set -euxo pipefail (debug mode 1): mode 0 + variables are printed +
> script fails if a command does not succeed.
> 
> While debugging, I noticed about small bash errors that we ignore, such
> as unbound variables. So, this also fixes the issues found while debug
> mode 1 was enabled.

Reviewed-by: Chuck Lever <chuck.lever@oracle.com>

In the long run, I think bringup_guestfs.sh should be converted to
Ansible (IaC), similar to playbooks/roles/terraform/.

Since it is a big honking shell script, the process will be less risky
to do parts of it at a time. The heavy lift will be replacing the shell
code that builds base OS images. Once that is done, what is left is
fairly straightforward, and I have a few old patches that do that part.

Unfortunately I'm running an NFS plug-fest this week, so I can't post
much at the moment.


> ---
> Changes in v2:
> * Rebase on top of latest main branch
> * Split long conditional lines into 2 
> - Link to v1: https://lore.kernel.org/all/20241015-bringup-guestfs-debug-v1-0-bd74c0c31412@samsung.com/
> 
> ---
> Daniel Gomez (4):
>       guestfs: bringup: check if domain exists
>       guestfs: bringup: fix unbound variable when debug
>       guestfs: bringup: fix user check when debug
>       guestfs: bringup: add debug mode
> 
>  kconfigs/Kconfig.guestfs   | 21 +++++++++++++++++++++
>  scripts/bringup_guestfs.sh | 38 +++++++++++++++++++++++++++-----------
>  2 files changed, 48 insertions(+), 11 deletions(-)
> ---
> base-commit: ef549598f2261ac89643d3e7a8ea0f050fc27c5f
> change-id: 20241015-bringup-guestfs-debug-775f4dbd98c1
> 
> Best regards,


-- 
Chuck Lever