Re: [PATCH v2 0/7] Add a git regression workflow

[Jeff Layton <jlayton@kernel.org>]

On Thu, 2024-01-04 at 16:04 +0000, Chuck Lever III wrote:
> 
> > On Jan 3, 2024, at 1:04 PM, Chuck Lever III <chuck.lever@oracle.com> wrote:
> > 
> > 
> > 
> > > On Jan 3, 2024, at 12:10 PM, Jeff Layton <jlayton@kernel.org> wrote:
> > > 
> > > On Wed, 2024-01-03 at 10:08 -0500, Chuck Lever wrote:
> > > > Since the last series, I've added support for tmpfs and NFS mounts,
> > > > in addition to a few other refinements and loads of testing. I'd
> > > > like a little review before I push these.
> > > > 
> > > 
> > > This all looks pretty great to me. I don't see any need to wait on
> > > merging it, if it seems to be working for you.
> > 
> > OK, I'll push later this week.
> 
> Blargh.
> 
> I pushed the gitr patches this morning, but there are still
> some problems.
> 
> I've been trying to run down the NFSv4.1 backchannel problem
> so I haven't run "make gitr-baseline" recently -- I've been
> running the test by hand on the target hosts.
> 
> But "make gitr-baseline" is still hitting this error after
> the test passes:
> 
> TASK [gitr : Save git regression test output to a file] ************************************************************************************************************************************************
> fatal: [cel]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'stdout_lines'. 'dict object' has no attribute 'stdout_lines'\n\nThe error appears to be in '/home/cel/src/kdevops/playbooks/roles/gitr/tasks/main.yml': line 162, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Save git regression test output to a file\n  ^ here\n"}
> 
> I can't seem to nail down why stdout_lines does not exist,
> because sometimes it /does/ exist.
> 
> My Ansible fu is not strong.
> 
> 


---------------8<-------------------
- name: Run the full git regression suite
  tags: [ 'run_tests' ]
  community.general.make:
    chdir: "{{ gitr_mnt }}/git"
    target: "test"
    jobs: "{{ nproc.stdout }}"
  register: gitr_results
  failed_when: False
  changed_when: False

...

- name: Save git regression test output to a file
  tags: [ 'copy_results' ]
  ansible.builtin.copy:
    content: "{{ gitr_results.stdout_lines|join('\n') }}"
    dest: "{{ gitr_mnt }}/gitr.stdout"
---------------8<-------------------

Looking at the first play, you have "failed_when: False". Is it possible
the first play failed and didn't register a result? I'd look closely at
what's happening in that play, in any case...

-- 
Jeff Layton <jlayton@kernel.org>