public inbox for kdevops@lists.linux.dev
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: Daniel Gomez <da.gomez@kernel.org>, Luis Chamberlain <mcgrof@kernel.org>
Cc: kdevops@lists.linux.dev, Daniel Gomez <da.gomez@samsung.com>
Subject: Re: [PATCH v2 09/15] bootlinux: fix os detection for 9p build dependency installation
Date: Sat, 8 Nov 2025 15:56:31 -0500	[thread overview]
Message-ID: <8fec69d8-3e7c-4210-a180-b7f1732312e3@oracle.com> (raw)
In-Reply-To: <e991c6f3-6442-4542-9dde-9f674c07c7a9@kernel.org>

On 11/8/25 3:12 PM, Daniel Gomez wrote:
>> The way I tried to deal with that was to use "delegate_to:". But I think
>> you might have advanced a different mechanism, and I missed the
>> subtleties of that. Or, maybe providing execution locale information on
>> the Ansible command line just isn't appropriate in these cases. I
>> haven't thought it through.
> This is where it gets tricky. I've just found out that delegated tasks to a
> host that is not included in the scope (such as localhost), do not have gathered
> facts.

This is surprising, but explains a lot. I didn't know this either!


> https://docs.ansible.com/ansible/latest/playbook_guide/
> playbooks_delegation.html#delegating-facts
> 
> That explains why ansible_os_family returns the guest fact (e.g. RedHat
> guest), not the localhost fact (e.g. Debian host) when we import_tasks:
> install-deps/main.yml in build/9p.yml.
> 
> The use of distro_yada_based in patch "bootlinux: fix os detection for 9p build
> dependency installation" allows to access the fact (os family) via Kconfig for
> the localhost. But breaks builder and targets sub-roles.
> 
>> I'm very happy to help drill into the 9p case that was not working for
>> you, instead of standing nearby lobbing uninformed suggestions.
>> Meanwhile, I'll keep a patch that reverts 0e9c8ac8bc68 in my private
>> tree.
>>
> Thanks Chuck. I think the correct approach is to revert patch 0e9c8ac8
> "bootlinux: fix os detection for 9p build dependency installation" upstream,
> while we try to sort this out in 9p.
> 
> For the revert part, please push:
> Acked-by: Daniel Gomez <da.gomez@samsung.com>
> 
> FYI, I'm already working on a solution using delegate_facts + hostvars as
> described in the Ansible documentation link above. That seems to be the right
> approach. I'll send something soon for testing.

For expediency, I had a patch that reverted just the install-deps/
main.yml hunk. Testing a full revert of 0e9c8ac8bc68 now, before
pushing.


-- 
Chuck Lever

  reply	other threads:[~2025-11-08 20:56 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-29 12:40 [PATCH v2 00/15] Fedora on Debian Daniel Gomez
2025-10-29 12:40 ` [PATCH v2 01/15] base_image: restore locales-all installation for Debian Trixie Daniel Gomez
2025-10-29 12:40 ` [PATCH v2 02/15] guestfs: fix Kconfig indentation style Daniel Gomez
2025-10-29 12:40 ` [PATCH v2 03/15] guestfs: remove unused bringup debug Kconfig options Daniel Gomez
2025-10-29 12:40 ` [PATCH v2 04/15] guestfs: fix spelling errors and Debian capitalization Daniel Gomez
2025-10-29 12:40 ` [PATCH v2 05/15] base_image: set selinux to permissive for fedora on debian hosts Daniel Gomez
2025-10-29 12:40 ` [PATCH v2 06/15] ansible_provisioning: fix help text indentation style Daniel Gomez
2025-10-29 12:40 ` [PATCH v2 07/15] devconfig: fix undefined custom repos/packages variables Daniel Gomez
2025-10-29 12:40 ` [PATCH v2 08/15] devconfig: fix Ansible boolean conditional for custom repos Daniel Gomez
2025-10-29 12:40 ` [PATCH v2 09/15] bootlinux: fix os detection for 9p build dependency installation Daniel Gomez
2025-11-07 19:22   ` Chuck Lever
2025-11-07 20:00     ` Daniel Gomez
2025-11-07 20:17       ` Chuck Lever
2025-11-07 20:47         ` Daniel Gomez
2025-11-07 20:53           ` Chuck Lever
2025-11-07 23:20             ` Daniel Gomez
2025-11-07 23:24               ` Daniel Gomez
2025-11-08 16:11               ` Chuck Lever
2025-11-08 20:12                 ` Daniel Gomez
2025-11-08 20:56                   ` Chuck Lever [this message]
2025-10-29 12:40 ` [PATCH v2 10/15] selftests: " Daniel Gomez
2025-10-29 12:40 ` [PATCH v2 11/15] guestfs: generate fedora distribution-specific hostname prefixes Daniel Gomez
2025-10-29 12:40 ` [PATCH v2 12/15] defconfigs: add fedora-41 fragment for guestfs Daniel Gomez
2025-10-29 12:40 ` [PATCH v2 13/15] defconfigs: add debian-13 " Daniel Gomez
2025-10-29 12:40 ` [PATCH v2 14/15] github: add guest OS selection for CI testing Daniel Gomez
2025-10-29 12:40 ` [PATCH v2 15/15] guestfs: increase SSH config timeout for Fedora on Debian hosts Daniel Gomez
2025-10-29 13:49 ` [PATCH v2 00/15] Fedora on Debian Chuck Lever
2025-10-29 14:16 ` Daniel Gomez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8fec69d8-3e7c-4210-a180-b7f1732312e3@oracle.com \
    --to=chuck.lever@oracle.com \
    --cc=da.gomez@kernel.org \
    --cc=da.gomez@samsung.com \
    --cc=kdevops@lists.linux.dev \
    --cc=mcgrof@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox