Re: [PATCH v2 7/9] all: run black

[Chuck Lever <cel@kernel.org>]

On 8/1/25 4:12 AM, Daniel Gomez wrote:
> 
> 
> On 31/07/2025 14.57, Daniel Gomez wrote:
>> On 30/07/2025 08.01, Luis Chamberlain wrote:
>>> Run black to fix tons of styling issues with tons of Python scripts.
>>> In order to help bots ensure they don't add odd styling we need a
>>> convention.
>>>
>>> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
>>
>> Acked-by: Daniel Gomez <da.gomez@samsung.com>
>>
>> FYI, I'm working on b4 check stuff mentioned in the other thread. I think this
>> is really nice but it would be awesome to also extend it to Ansible files using
>> the Ansible linter:
>>
>> ansible-lint --help
>> {...}
>> --fix [WRITE_LIST]    Allow ansible-lint to perform auto-fixes, including YAML
>> reformatting

I use ansible-lint extensively before commit. Linting existing kdevops
files is still a bit of jungle, so ansible-lint would have to be
directed only at new files.


>> So, these changes with black/ansible-lint, etc make sense if:
>> 1. Add b4 integration
>> 2. Make CI run the scripts as well (make style, make check, etc)
>>
>> But I suspect a minimal testing may be needed.
>>
>> Thoughts?
> 
> I'll send an RFC with more details.

-- 
Chuck Lever